Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: too many private members #5826

Closed
gopherbot opened this issue Jul 1, 2013 · 9 comments
Closed

x/crypto/ssh: too many private members #5826

gopherbot opened this issue Jul 1, 2013 · 9 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 1, 2013

by jeremy.f.stephens:

I'm experimenting with crypto/ssh in order to implement X11 forwarding for a project. To
enable x11 forwarding, the server initiates a channel open message. However, most of the
internal functions used to open channels and to send messages are private. This makes
crypto/ssh unusable for this purpose.

Is it reasonable to export more functions so that users can create custom channels (not
just x11 channels)?
@davecheney
Copy link
Contributor

@davecheney davecheney commented Jul 2, 2013

Comment 1:

Yes, this should be possible. Ideally the current Dial and NewSession should become
helpers on top of a more general facility.
I cannot commit to a time frame on this, proposals happily received.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 3, 2013

Comment 2 by jeremy.f.stephens:

All of the message types can be made public. There are so many though, maybe it's a good
idea to create a sub-package for those. What do you think?
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 3, 2013

Comment 3 by jeremy.f.stephens:

There is also a lot of marshaling code that is used throughout. The main marshal
functions are in the messages source file, so if the messages are put into their own
package, it would be necessary to export the marshaling functions (perhaps in another
sub-package).
@hanwen
Copy link
Contributor

@hanwen hanwen commented Oct 26, 2013

Comment 5:

Jeremy, I'm collecting ideas on how to fix the SSH package. If you're interested, please
comment on
https://docs.google.com/document/d/1yVmyfDxWbnIhDkk4ypNSVjV8KL_GOsfCcr-ZcDpDup4/edit?usp=sharing
@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2013

Comment 6:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 7:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 8:

Labels changed: added repo-crypto.

@hanwen
Copy link
Contributor

@hanwen hanwen commented Apr 12, 2014

Comment 9:

this should be fixed in go.crypto/ssh . You can use the code for agent forwarding as an
example
http://godoc.org/code.google.com/p/go.crypto/ssh/agent#ForwardToAgent
@mikioh mikioh changed the title go.crypto/ssh: too many private members ssh: too many private members Jan 7, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title ssh: too many private members x/crypto/ssh: too many private members Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-crypto label Apr 14, 2015
@hanwen
Copy link
Contributor

@hanwen hanwen commented Aug 12, 2015

@ianlancetaylor this bug is obsolete.

@hanwen hanwen closed this Aug 13, 2015
@golang golang locked and limited conversation to collaborators Aug 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.