x/crypto/ssh: too many private members

[gopherbot]

by jeremy.f.stephens:

I'm experimenting with crypto/ssh in order to implement X11 forwarding for a project. To
enable x11 forwarding, the server initiates a channel open message. However, most of the
internal functions used to open channels and to send messages are private. This makes
crypto/ssh unusable for this purpose.

Is it reasonable to export more functions so that users can create custom channels (not
just x11 channels)?

[davecheney]

Comment 1:

Yes, this should be possible. Ideally the current Dial and NewSession should become
helpers on top of a more general facility.
I cannot commit to a time frame on this, proposals happily received.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

[gopherbot]

Comment 2 by jeremy.f.stephens:

All of the message types can be made public. There are so many though, maybe it's a good
idea to create a sub-package for those. What do you think?

[gopherbot]

Comment 3 by jeremy.f.stephens:

There is also a lot of marshaling code that is used throughout. The main marshal
functions are in the messages source file, so if the messages are put into their own
package, it would be necessary to export the marshaling functions (perhaps in another
sub-package).

[hanwen]

Comment 5:

Jeremy, I'm collecting ideas on how to fix the SSH package. If you're interested, please
comment on
https://docs.google.com/document/d/1yVmyfDxWbnIhDkk4ypNSVjV8KL_GOsfCcr-ZcDpDup4/edit?usp=sharing

[rsc]

Comment 6:

Labels changed: added go1.3maybe.

[rsc]

Comment 7:

Labels changed: added release-none, removed go1.3maybe.

[rsc]

Comment 8:

Labels changed: added repo-crypto.

[hanwen]

Comment 9:

this should be fixed in go.crypto/ssh . You can use the code for agent forwarding as an
example
http://godoc.org/code.google.com/p/go.crypto/ssh/agent#ForwardToAgent

[hanwen]

@ianlancetaylor this bug is obsolete.