Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestFileCloseRace failures with connection reset by peer #58276

Open
gopherbot opened this issue Feb 2, 2023 · 3 comments
Open

net: TestFileCloseRace failures with connection reset by peer #58276

gopherbot opened this issue Feb 2, 2023 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Feb 2, 2023

#!watchflakes
post <- pkg == "net" && test == "TestFileCloseRace" && `connection reset by peer`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestFileCloseRace (0.00s)
    file_test.go:321: dial tcp 127.0.0.1:65102: connect: connection reset by peer

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 2, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestFileCloseRace"
2023-02-02 19:39 netbsd-amd64-9_3 go@fcd0e096 net.TestFileCloseRace (log)
--- FAIL: TestFileCloseRace (0.00s)
    file_test.go:321: dial tcp 127.0.0.1:65102: connect: connection reset by peer

watchflakes

@bcmills bcmills changed the title net: TestFileCloseRace failures net: TestFileCloseRace failures with connection reset by peer Feb 3, 2023
@bcmills bcmills added this to the Backlog milestone Feb 3, 2023
@bcmills
Copy link
Member

bcmills commented Feb 3, 2023

@golang/netbsd, this is the first we've seen of this failure mode, and it looks to me like a bug somewhere in the (Go or kernel) network stack.

The handler reads a byte from the connection before closing it, so I don't see why Dial should ever fail with ECONNRESET.
(https://cs.opensource.google/go/go/+/master:src/net/file_test.go;l=306-308;drc=b55cbbb9e76969d67fbc6e264a584ad18c2f95fa)

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestFileCloseRace" && `connection reset by peer`
2023-03-24 02:45 netbsd-amd64-9_3 go@33b63480 net.TestFileCloseRace (log)
--- FAIL: TestFileCloseRace (0.01s)
    file_test.go:321: dial tcp 127.0.0.1:64962: connect: connection reset by peer

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

2 participants