Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: failure to build on linux/riscv64 #58307

Closed
mknyszek opened this issue Feb 3, 2023 · 3 comments
Closed

x/build: failure to build on linux/riscv64 #58307

mknyszek opened this issue Feb 3, 2023 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Feb 3, 2023

https://build.golang.org/log/441fa832fa6ef64f5d9f6bc6e6d04d232a5e1f12

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 3, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 3, 2023
@mknyszek
Copy link
Contributor Author

mknyszek commented Feb 3, 2023

(Just noting this down for a comment in some x/build code. I don't mean to imply this necessarily should work. Feel free to close.)

@dmitshur
Copy link
Contributor

dmitshur commented Feb 3, 2023

x/build is exempt from Go 1 compat and even the release policy as documented at the top of README; if the failing platform isn't something we want to go out our way to support (e.g. we only support coordinator on linux/amd64 where it runs, and darwin for convenience of development), we can just leave them out.

But this one is probably easier to fix than to ignore, i.e., just need to update to a newer version of that dependency.

build $ GOOS=linux GOARCH=riscv64 go build ./...
# github.com/prometheus/procfs
../../../../pkg/mod/github.com/prometheus/procfs@v0.2.0/cpuinfo.go:71:9: undefined: parseCPUInfo
build $ go get github.com/prometheus/procfs
go: upgraded github.com/prometheus/procfs v0.2.0 => v0.9.0
go: upgraded golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4 => v0.1.0
go: upgraded golang.org/x/sys v0.1.0 => v0.3.0
build $ go mod tidy
build $ GOOS=linux GOARCH=riscv64 go build ./...
build $ echo $?
0

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 3, 2023
@gopherbot
Copy link

Change https://go.dev/cl/479696 mentions this issue: go.mod: update contrib.go.opencensus.io/exporter/prometheus to v0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

3 participants