cmd/go/internal/modfetch: TestCodeRepo/gopkg.in_natefinch_lumberjack.v2/latest failing

[prattmic]

#!watchflakes
post <- pkg == "cmd/go/internal/modfetch" && log ~ `lumberjack\.v2` && date < "2023-03-01"

Failed on https://go.dev/cl/466858.

https://storage.googleapis.com/go-build-log/a1d4a977/linux-amd64-longtest_5b4a2f7a.log

--- FAIL: TestCodeRepo (0.00s)
    --- FAIL: TestCodeRepo/gopkg.in_natefinch_lumberjack.v2/latest (6.74s)
        coderepo_test.go:609: info.Version = "v2.2.1", want "v2.0.0-20170531160350-a96e63847dc3"
        coderepo_test.go:612: info.Name = "4cb27fcfbb0f35cb48c542c5ea80b7c1d18933d0", want "a96e63847dc3c67d17befa69c303767e2f84e54f"
        coderepo_test.go:615: info.Short = "4cb27fcfbb0f", want "a96e63847dc3"
        coderepo_test.go:618: info.Time = 2023-02-06 19:38:14 +0000 UTC, want 2017-05-31 16:03:50 +0000 UTC
--- FAIL: TestCodeRepoVersions (0.21s)
    --- FAIL: TestCodeRepoVersions/parallel (0.00s)
        --- FAIL: TestCodeRepoVersions/parallel/gopkg.in_natefinch_lumberjack.v2 (0.00s)
            coderepo_test.go:827: Versions(""):
                have &{0xc000159400 [v2.0.0 v2.2.0 v2.2.1]}
                want [v2.0.0]
FAIL
FAIL	cmd/go/internal/modfetch	34.757s
FAIL

It sounds like this test depends on lumberjack being an abandoned project? But it just tagged a new version: https://pkg.go.dev/gopkg.in/natefinch/lumberjack.v2?tab=versions

cc @bcmills

[dr2chase]

I think this might instead be linked to gopkg.in flakiness?
https://go.dev/cl/466857 seemed to fix the problem.

[prattmic]

I believe that https://go.dev/cl/466857 "fixes" this given that it skips this test, but I don't think this is flakiness. This test asserts that gopkg.in/natefinch/lumberjack.v2@latest is v2.0.0, but it simply isn't anymore:

$ go get gopkg.in/natefinch/lumberjack.v2@latest
go: downloading gopkg.in/natefinch/lumberjack.v2 v2.2.1
go: added gopkg.in/natefinch/lumberjack.v2 v2.2.1

[bcmills]

Let's remove those test cases. If/when we move the gopkg.in tests to the hermetic test-local server (#54503), we can re-enable them without external dependencies at that point.

[bcmills]

@gopherbot, please backport to Go 1.20 and 1.19. These tests are broken due to benign external changes.

[gopherbot]

Change https://go.dev/cl/466860 mentions this issue: cmd/go: remove tests that assume lack of new versions of external modules

[gopherbot]

Backport issue(s) opened: #58449 (for 1.19), #58450 (for 1.20).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

[gopherbot]

Change https://go.dev/cl/466861 mentions this issue: [release-branch.go1.20] cmd/go: remove tests that assume lack of new versions of external modules