Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: panic: flow control update exceeds maximum window size #58456

Open
WillSewell opened this issue Feb 10, 2023 · 2 comments
Open

x/net/http2: panic: flow control update exceeds maximum window size #58456

WillSewell opened this issue Feb 10, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@WillSewell
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.19.5 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19.5"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1132651924=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Calling golang.org/x/net/http2.transportResponseBody.Close sometimes results in

panic: flow control update exceeds maximum window size
goroutine 242605551 [running]:
golang.org/x/net/http2.(*inflow).add(...)
        /go-tmp/src/github.com/monzo/wearedev/vendor/golang.org/x/net/http2/flow.go:42
golang.org/x/net/http2.transportResponseBody.Close({0x13b6580?})
        /go-tmp/src/github.com/monzo/wearedev/vendor/golang.org/x/net/http2/transport.go:2562 +0x298

I can see this panic was recently added here.

What did you expect to see?

An error to be returned.

What did you see instead?

A panic.

@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 10, 2023
@seankhliao
Copy link
Member

cc @neild @tombergan

@seankhliao seankhliao added this to the Unreleased milestone Feb 10, 2023
@bcmills
Copy link
Contributor

bcmills commented Feb 10, 2023

Possibly related to #57578?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants