x/pkgsite: internal folders/packages handled differently on top-level versus inside packages?

[thediveo]

Example project where I notice this (inconsistent?) behavior: https://pkg.go.dev/github.com/thediveo/lxkns#section-directories

• there is a top-level internal directories node rendered at the end of the directories list.
• there is no cmd/internal directory rendered for the package in the repository: https://github.com/thediveo/lxkns/tree/master/cmd/internal

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36

Screenshot

What did you do?

Navigate to https://pkg.go.dev/github.com/thediveo/lxkns#section-directories

What did you expect to see?

The cmd directory node to contain a sub node named internal.

What did you see instead?

No such sub node named internal inside cmd, while there correctly is a top-level internal node.

[findleyr]

This appears to be only a property of the nav. The directory is there:
https://pkg.go.dev/github.com/thediveo/lxkns@v0.26.1/cmd/internal

[jamalc]

This is working as intended (CL 297109), but I agree it does seem inconsistent. Given #44356 (comment), maybe what we really want is to hide internal packages in the standard library but not third party modules.

[jamalc]

Any thoughts on a toggle for internal directory visibility? I've moved the top level internal directory back into regular alphabetical order in this example. I don't see a reason to treat it differently from other internal directories but someone may disagree.

[findleyr]

I like the toggle idea.

If I'm browsing my own code, I want to see internal. If I'm browsing other people's code, I don't want to see internal. Based on this heuristic, perhaps we should make it the default to show internal packages for cmd/pkgsite.

[gopherbot]

Change https://go.dev/cl/476616 mentions this issue: static,internal: add toggle for internal directories on doc pages

[thediveo]

Thank you very much!