Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: cmd/go gets error "copy_file_range: function not implemented" [1.20 backport] #58627

Closed
gopherbot opened this issue Feb 21, 2023 · 2 comments
Closed

os: cmd/go gets error "copy_file_range: function not implemented" [1.20 backport] #58627

gopherbot opened this issue Feb 21, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.2

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #58592 to be considered for backport to the next 1.20 minor release.

@gopherbot Please open a backport to 1.20.

On some systems copy_file_range appears to fail with ENOSYS, even though it seems that it shouldn't. On those systems the go tool doesn't work at all.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 21, 2023
@gopherbot gopherbot mentioned this issue Feb 21, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.2 milestone Feb 21, 2023
@thanm thanm added the CherryPickApproved Used during the release process for point releases label Feb 22, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 22, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/470316 mentions this issue: [release-branch.go1.20] Revert "internal/poll: drop redundant ENOSYS in CopyFileRange"

@gopherbot
Copy link
Contributor Author

Closed by merging 1acd39c to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Feb 22, 2023
@ianlancetaylor
[release-branch.go1.20] Revert "internal/poll: drop redundant ENOSYS …
1acd39c 
…in CopyFileRange"

This reverts CL 428555.

Reason for revert: It appears that even a newer kernel can get
ENOSYS from copy_file_range.

For #58592
Fixes #58627

Change-Id: Ib8dd1be61544f54bf652a99dc0b449109f8f50ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/470316
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 3, 2023
@ianlancetaylor @romaindoumenc
[release-branch.go1.20] Revert "internal/poll: drop redundant ENOSYS …
0eb0be3 
…in CopyFileRange"

This reverts CL 428555.

Reason for revert: It appears that even a newer kernel can get
ENOSYS from copy_file_range.

For golang#58592
Fixes golang#58627

Change-Id: Ib8dd1be61544f54bf652a99dc0b449109f8f50ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/470316
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.2
Development

No branches or pull requests
2 participants
@gopherbot @thanm