Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestCgoTracebackSigpanic fails on android/arm64 and android/arm #58794

Open
bcmills opened this issue Feb 28, 2023 · 3 comments
Open
Assignees
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. arch-arm64 compiler/runtime Issues related to the Go compiler and/or runtime. mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Feb 28, 2023

In CL 472096, I am experimenting with enabling tests that use go build on android, because I don't see a good reason not to.

However, runtime.TestCgoTracebackSigpanic seems to fail when run on that platform (https://storage.googleapis.com/go-build-log/8970bcfa/android-arm64-corellium_f7cf8915.log):

--- FAIL: TestCgoTracebackSigpanic (2.10s)
    crash_cgo_test.go:519: /data/data/com.termux/files/home/tmpdir/workdir-host-android-arm64-corellium-android/tmp/go-build2337918989/testprogcgo.exe TracebackSigpanic: signal: segmentation fault
    crash_cgo_test.go:520: 
    crash_cgo_test.go:523: did not see "runtime.sigpanic" in output
FAIL
FAIL	runtime	58.095s

I don't think this is particularly important to fix and don't plan to investigate it myself, but I'm filing this issue to have something to refer to in a test skip.

(CC @golang/android)

@bcmills bcmills added OS-Android NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. mobile Android, iOS, and x/mobile compiler/runtime Issues related to the Go compiler and/or runtime. labels Feb 28, 2023
@bcmills bcmills added this to the Backlog milestone Feb 28, 2023
@bcmills bcmills changed the title runtime: TestCgoTracebackSigpanic fails on android/arm64 runtime: TestCgoTracebackSigpanic fails on android/arm64 and android/arm Mar 1, 2023
@bcmills bcmills added arch-arm64 arch-arm Issues solely affecting the 32-bit arm architecture. labels Mar 1, 2023
@mknyszek
Copy link
Contributor

mknyszek commented Mar 8, 2023

In triage, we're thinking maybe Android has something weird about its libc? All this test is checking that we can get a stack trace from a panic in cgo. Cherry's gonna take a look.

@gopherbot
Copy link

Change https://go.dev/cl/475075 mentions this issue: runtime: skip tests that fail on android/arm64

@gopherbot
Copy link

Change https://go.dev/cl/472455 mentions this issue: all: skip tests that fail on android/arm64

gopherbot pushed a commit that referenced this issue Mar 10, 2023
Many of the tests skipped platforms that build PIE binaries by
default, but (still) lack a central function to report which platforms
those are.

Some of the tests assumed (but did not check for) internal linking
support, or invoked `go tool link` directly without properly
configuring the external linker.

A few of the tests seem to be triggering latent bugs in the linker.

For #58806.
For #58807.
For #58794.

Change-Id: Ie4d06b1597f404590ad2abf978d4c363647407ac
Reviewed-on: https://go-review.googlesource.com/c/go/+/472455
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. arch-arm64 compiler/runtime Issues related to the Go compiler and/or runtime. mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Projects
Development

No branches or pull requests

4 participants