Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: change the max allowed number of methods on a type #58805

Closed
zigo101 opened this issue Mar 1, 2023 · 2 comments
Closed

cmd/compile: change the max allowed number of methods on a type #58805

zigo101 opened this issue Mar 1, 2023 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Unfortunate
Milestone

Comments

@zigo101
Copy link

zigo101 commented Mar 1, 2023

Someone encountered a too many methods on *** compiler error: https://twitter.com/magiconair/status/1630589195856097280

It looks now the limit is 65535. Maybe the limit should be enlarged.

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 1, 2023
@ianlancetaylor
Copy link
Contributor

This doesn't have to be a proposal.

This would require changing the mcount and xcount fields in reflect.uncommonType. I don't think it's worth it. 64K should be enough for everyone.

@ianlancetaylor ianlancetaylor changed the title cmd/compile: proposal: change the max allowed number of methods on a type cmd/compile: change the max allowed number of methods on a type Mar 1, 2023
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 1, 2023
@dmitshur dmitshur added this to the Backlog milestone Mar 1, 2023
@mknyszek
Copy link
Contributor

mknyszek commented Mar 8, 2023

It looks like the original poster also agrees that 64K should be enough. I'm inclined to close this. (https://twitter.com/magiconair/status/1630871487216332801)

@mknyszek mknyszek closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2023
@golang golang locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Unfortunate
Projects
None yet
Development

No branches or pull requests

5 participants