Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: missing added in label for type in runtime/cgo package #58853

Open
jamalc opened this issue Mar 3, 2023 · 1 comment
Open

x/pkgsite: missing added in label for type in runtime/cgo package #58853

jamalc opened this issue Mar 3, 2023 · 1 comment

Comments

@jamalc
Copy link

jamalc commented Mar 3, 2023

What is the URL of the page with the issue?

https://pkg.go.dev/runtime/cgo

Screenshot

Screenshot 2023-03-03 at 2 33 28 PM

What did you expect to see?

A label indicating that type Handle was added in go1.17.

What did you see instead?

No label.

@jamalc jamalc added the pkgsite label Mar 3, 2023
@jamalc jamalc added this to the pkgsite/later milestone Mar 3, 2023
@jamalc
Copy link
Author

jamalc commented Mar 3, 2023

Its WAI that this label doesn't show on the doc page (https://go.googlesource.com/pkgsite/+/refs/heads/master/internal/godoc/render.go#173). Handle was added in the earliest version of this package containing any API so we hide the label.

  • We should probably remove "containing any API" from the consideration: if a package existed but had no API in an earlier version, then it's worth noting when new API was added.
  • We should probably mark at the top of package docs the first module version that introduced the package. Both of these are general, not specific to the "Go" module.

Another example to consider: https://pkg.go.dev/net/netip was created in go1.18 and does not include added in go1.18 for any symbols. We might continue to hide the labels for net/netip because this package was new in go1.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant