Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestGoListCmdOnlyShowsCommands failures #58918

Closed
gopherbot opened this issue Mar 7, 2023 · 5 comments
Closed

cmd/go: TestGoListCmdOnlyShowsCommands failures #58918

gopherbot opened this issue Mar 7, 2023 · 5 comments
Assignees
@bcmills
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Mar 7, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "cmd/go" && test == "TestGoListCmdOnlyShowsCommands" && `test timed out while running command`

Issue created automatically to collect these failures.

Example (log):

vcs-test.golang.org rerouted to http://127.0.0.1:54480
https://vcs-test.golang.org rerouted to https://127.0.0.1:54481
go test proxy running at GOPROXY=http://127.0.0.1:54482/mod
--- FAIL: TestGoListCmdOnlyShowsCommands (16.25s)
    go_test.go:1126: running testgo [list cmd]
    exec.go:146: test timed out while running command: /tmp/buildlet/tmp/cmd-go-test-2779377144/tmpdir69193264/testbin/go list cmd
    go_test.go:1126: standard error:
    go_test.go:1126: SIGQUIT: quit
        PC=0x7ff81f8423ea m=0 sigcode=0

...
        r13    0x0
        r14    0x120100001300
        r15    0x1200
        rip    0x7ff81f8423ea
        rflags 0x247
        cs     0x7
        fs     0x0
        gs     0x0

    go_test.go:1126: go [list cmd] failed unexpectedly in /tmp/buildlet/go/src/cmd/go: exit status 2

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 7, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test == "TestGoListCmdOnlyShowsCommands"
2023-02-28 12:45 darwin-amd64-race go@aef8a8cd cmd/go.TestGoListCmdOnlyShowsCommands (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54480
https://vcs-test.golang.org rerouted to https://127.0.0.1:54481
go test proxy running at GOPROXY=http://127.0.0.1:54482/mod
--- FAIL: TestGoListCmdOnlyShowsCommands (16.25s)
    go_test.go:1126: running testgo [list cmd]
    exec.go:146: test timed out while running command: /tmp/buildlet/tmp/cmd-go-test-2779377144/tmpdir69193264/testbin/go list cmd
    go_test.go:1126: standard error:
    go_test.go:1126: SIGQUIT: quit
        PC=0x7ff81f8423ea m=0 sigcode=0

...
        r13    0x0
        r14    0x120100001300
        r15    0x1200
        rip    0x7ff81f8423ea
        rflags 0x247
        cs     0x7
        fs     0x0
        gs     0x0

    go_test.go:1126: go [list cmd] failed unexpectedly in /tmp/buildlet/go/src/cmd/go: exit status 2

— watchflakes

@bcmills bcmills self-assigned this Mar 7, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels Mar 7, 2023
@bcmills bcmills added this to the Go1.21 milestone Mar 7, 2023
@bcmills bcmills mentioned this issue Mar 7, 2023
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/474137 mentions this issue: cmd/go: don't run slow tests on non-longtest builders

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/474137 mentions this issue: cmd/go: avoid running slow tests on non-longtest builders

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/474580 mentions this issue: [release-branch.go1.20] cmd/go: avoid running slow tests on non-longtest builders

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/474581 mentions this issue: [release-branch.go1.19] cmd/go: avoid running slow tests on non-longtest builders

gopherbot pushed a commit that referenced this issue Mar 9, 2023
@cagedmantis
[release-branch.go1.19] cmd/go: avoid running slow tests on non-longt…
fbf4c04 
…est builders

Also annotate calls to tooSlow with specific reasons.

This will somewhat reduce test coverage on the 'darwin' builders until
we have darwin 'longtest' builders (#35678,#49055), but still seems
worthwhile to avoid alert fatigue from tests that really shouldn't be
running in the short configurations.

Updates #58918.
Updates #58919.
Fixes #58937.

Change-Id: I0000f0084b262beeec3eca3e9b8a45d61fab4313
Reviewed-on: https://go-review.googlesource.com/c/go/+/474137
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9f532dd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/474581
gopherbot pushed a commit that referenced this issue Mar 9, 2023
@cagedmantis
[release-branch.go1.20] cmd/go: avoid running slow tests on non-longt…
b852f39 
…est builders

Also annotate calls to tooSlow with specific reasons.

This will somewhat reduce test coverage on the 'darwin' builders until
we have darwin 'longtest' builders (#35678,#49055), but still seems
worthwhile to avoid alert fatigue from tests that really shouldn't be
running in the short configurations.

Updates #58918.
Updates #58919.
Fixes #58938.

Change-Id: I0000f0084b262beeec3eca3e9b8a45d61fab4313
Reviewed-on: https://go-review.googlesource.com/c/go/+/474137
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9f532dd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/474580
@golang golang locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot