Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/coverage: slice bounds out of range in (*emitState).VisitFuncs #58936

Open
bcmills opened this issue Mar 8, 2023 · 3 comments
Open
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Mar 8, 2023

#!watchflakes
post <- log ~ `panic: runtime error: slice bounds out of range` && log ~ `\s*runtime/coverage\.\(\*emitState\)\.VisitFuncs`

(Pulled out from #55311 (comment).)

2023-02-27 19:43 linux-arm64-longtest go@002bc94e cmd/go.TestScript (log)
vcs-test.golang.org rerouted to http://127.0.0.1:40571
https://vcs-test.golang.org rerouted to https://127.0.0.1:44117
go test proxy running at GOPROXY=http://127.0.0.1:39707/mod
2023/02/27 20:09:52 http: TLS handshake error from 127.0.0.1:39140: read tcp 127.0.0.1:44117->127.0.0.1:39140: read: connection reset by peer
2023/02/27 20:09:52 http: TLS handshake error from 127.0.0.1:39110: EOF
2023/02/27 20:09:52 http: TLS handshake error from 127.0.0.1:39170: EOF
2023/02/27 20:09:55 http: TLS handshake error from 127.0.0.1:51238: EOF
--- FAIL: TestScript (0.07s)
    --- FAIL: TestScript/cover_pkgall_imports (5.98s)
        script_test.go:134: 2023-02-27T20:10:24Z
...
            panic: runtime error: slice bounds out of range [:4294970564] with capacity 28534

            goroutine 1 [running]:
            panic({0x1ca960?, 0x40000160f0?})
            	/tmp/workdir/go/src/runtime/panic.go:1015 +0x5cc fp=0x40000cb330 sp=0x40000cb280 pc=0x7206c
            runtime.goPanicSliceAcap(0x100000cc4, 0x6f76)
            	/tmp/workdir/go/src/runtime/panic.go:139 +0xa8 fp=0x40000cb370 sp=0x40000cb330 pc=0x6f118
            runtime/coverage.(*emitState).VisitFuncs(0x40000aa140, 0x4000028770)
            	/tmp/workdir/go/src/runtime/coverage/emit.go:541 +0x698 fp=0x40000cb4b0 sp=0x40000cb370 pc=0x162c98
            internal/coverage/encodecounter.(*CoverageDataWriter).writeCounters(0x40000789c0, {0x20e438, 0x40000aa140})
...
            testing.(*M).Run.func4()
            	/tmp/workdir/go/src/testing/testing.go:1901 +0x28 fp=0x40000cbc90 sp=0x40000cbc70 pc=0x17da78
            testing.(*M).Run(0x40000aa0a0)
            	/tmp/workdir/go/src/testing/testing.go:1948 +0xe70 fp=0x40000cbee0 sp=0x40000cbc90 pc=0x17d770
            main.main()
            	_testmain.go:78 +0x1f0 fp=0x40000cbf70 sp=0x40000cbee0 pc=0x19b620
            runtime.main()
            	/tmp/workdir/go/src/runtime/proc.go:250 +0x398 fp=0x40000cbfd0 sp=0x40000cbf70 pc=0x76628
            runtime.goexit()
            	/tmp/workdir/go/src/runtime/asm_arm64.s:1172 +0x4 fp=0x40000cbfd0 sp=0x40000cbfd0 pc=0xcd644

I feel like this might already have a fix CL, but I can't seem to find it..?

(attn @thanm)

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. compiler/runtime Issues related to the Go compiler and/or runtime. labels Mar 8, 2023
@thanm thanm self-assigned this Mar 8, 2023
@thanm
Copy link
Contributor

thanm commented Mar 8, 2023

Thanks, I will take a look.

@mknyszek mknyszek added this to the Go1.21 milestone Mar 15, 2023
@mknyszek
Copy link
Contributor

mknyszek commented Jun 9, 2023

Hey @thanm, doing a sweep over all Go 1.21 issues. Any updates here? Is this resolved? Thanks.

@thanm
Copy link
Contributor

thanm commented Jun 9, 2023

This is still unresolved as far as I know. Thanks.

@gopherbot gopherbot modified the milestones: Go1.21, Go1.22 Aug 8, 2023
@gopherbot gopherbot modified the milestones: Go1.22, Go1.23 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Development

No branches or pull requests

4 participants