Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: timeout on darwin-amd64-race builder [1.19 backport] #58937

Closed
gopherbot opened this issue Mar 8, 2023 · 2 comments
Closed

cmd/go: timeout on darwin-amd64-race builder [1.19 backport] #58937

gopherbot opened this issue Mar 8, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

@bcmills requested issue #58929 to be considered for backport to the next 1.19 minor release.

Hmm, this was on release-branch.go1.20. I think that CL will backport cleanly.

@gopherbot, please backport to Go 1.19 and 1.20. These failures may affect release testing, and the fix is test-only.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 8, 2023
@gopherbot gopherbot added this to the Go1.19.8 milestone Mar 8, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go CherryPickApproved Used during the release process for point releases labels Mar 8, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 8, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/474581 mentions this issue: [release-branch.go1.19] cmd/go: avoid running slow tests on non-longtest builders

@gopherbot
Copy link
Author

Closed by merging fbf4c04 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Mar 9, 2023
…est builders

Also annotate calls to tooSlow with specific reasons.

This will somewhat reduce test coverage on the 'darwin' builders until
we have darwin 'longtest' builders (#35678,#49055), but still seems
worthwhile to avoid alert fatigue from tests that really shouldn't be
running in the short configurations.

Updates #58918.
Updates #58919.
Fixes #58937.

Change-Id: I0000f0084b262beeec3eca3e9b8a45d61fab4313
Reviewed-on: https://go-review.googlesource.com/c/go/+/474137
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9f532dd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/474581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants