Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vuln/cmd/govulncheck: add tests for exit codes #58945

Closed
julieqiu opened this issue Mar 9, 2023 · 1 comment
Closed

x/vuln/cmd/govulncheck: add tests for exit codes #58945

julieqiu opened this issue Mar 9, 2023 · 1 comment
Assignees
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone

Comments

@julieqiu
Copy link
Member

julieqiu commented Mar 9, 2023

We should test to make sure -json and default modes return the correct exit codes.

@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Mar 9, 2023
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Mar 9, 2023
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 9, 2023
@julieqiu julieqiu modified the milestones: vuln/unplanned, vuln/v0.1.0 Apr 7, 2023
@julieqiu julieqiu self-assigned this Apr 13, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/482345 mentions this issue: cmd,internal/scan: consolidate error handling for flags

gopherbot pushed a commit to golang/vuln that referenced this issue Apr 17, 2023
Consolidate error handling for parsing flags to validateConfig. Add
tests for the various error outputs.

For golang/go#58945
Fixes golang/go#59139

Change-Id: Ic43f30b17dc830698bce62a6177c45ee4bfb8567
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/482345
Auto-Submit: Julie Qiu <julieqiu@google.com>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Development

No branches or pull requests

3 participants