Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Support pseudoversion semver-timestamp-commit_hash on about pages #59054

Closed
juspence opened this issue Mar 15, 2023 · 2 comments
Closed

Comments

@juspence
Copy link

juspence commented Mar 15, 2023

What is the URL of the page with the issue?

https://pkg.go.dev/about#adding-a-package (if a doc bug)
https://pkg.go.dev/cloud.google.com/go@v0.102.2-0.20220627142403-5be6d33a57cc (if a code bug)

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

Screenshot

Screenshot from 2023-03-15 16-08-27

What did you do?

I visited the below pages, which have version info and a downloadable artifact like I expect:
https://proxy.golang.org/cloud.google.com/go/@v/v0.102.2-0.20220627142403-5be6d33a57cc.info
https://proxy.golang.org/cloud.google.com/go/@v/v0.102.2-0.20220627142403-5be6d33a57cc.zip

I also visited https://pkg.go.dev/cloud.google.com/go@v0.102.2-0.20220627142403-5be6d33a57cc, which does not have any information about this package version.

Note that v0.102.2-0.20220627142403-5be6d33a57cc is still a valid semver, and everything after the first dash is part of the semver "pre-release identifier": https://semver.org/#spec-item-9

What did you expect to see?

Package version info / other metadata should be displayed on https://pkg.go.dev/cloud.google.com/go@v0.102.2-0.20220627142403-5be6d33a57cc

The behavior should be the same as this page for the same package but a different version: https://pkg.go.dev/cloud.google.com/go@v0.102.1

What did you see instead?

Oops! We couldn't find “cloud.google.com/go@v0.102.2-0.20220627142403-5be6d33a57cc”.

Check that you entered the URL correctly, try fetching it following the instructions here, or request to add “cloud.google.com/go@v0.102.2-0.20220627142403-5be6d33a57cc” to pkg.go.dev.

There is also a button labeled Request “cloud.google.com/go@v0.102.2-0.20220627142403-5be6d33a57cc”, but clicking this does not solve the issue. The package is still not available on pkg.go.dev even after waiting.

Maybe this is expected and these pseudoversions are not supported on the pkg.go.dev about pages, even though they are present on the proxy.golang.org and the index.golang.org pages. In that case, I think that https://pkg.go.dev/about#adding-a-package should be updated with a note that explains this:
Adding a package

Data for the site is downloaded from proxy.golang.org. We monitor the Go Module Index regularly for new packages to add to pkg.go.dev. If you don’t see a package on pkg.go.dev, you can add it by doing one of the following (note):

Visiting that page on pkg.go.dev, and clicking the “Request” button. For example:
https://pkg.go.dev/example.com/my/module

Making a request to proxy.golang.org for the module version, to any endpoint specified by the [Module proxy protocol](https://pkg.go.dev/cmd/go/#hdr-Module_proxy_protocol). For example:
https://proxy.golang.org/example.com/my/module/@v/v1.0.0.info

(note): Note that pseudoversions of packages, like v0.0.0-20220315123456-abcdeffedcba, are not supported.

@gopherbot gopherbot added this to the Unreleased milestone Mar 15, 2023
@juspence juspence changed the title x/pkgsite: Support pseudoversion tag-timestamp-commit_hash on about pages x/pkgsite: Support pseudoversion semver-timestamp-commit_hash on about pages Mar 15, 2023
@seankhliao
Copy link
Member

I see the pages are there now

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2023
@juspence
Copy link
Author

juspence commented Mar 16, 2023

Indeed they are. Could we update the 404 page to note how long this loading might take? I didn't see it within an hour if memory serves, so I assumed the load failed. Maybe worded like below:

Oops! We couldn't find “cloud.google.com/go@v0.102.2-0.20220627142403-5be6d33a57cc”.

Check that you entered the URL correctly, try fetching it following the instructions here, or request to add “cloud.google.com/go@v0.102.2-0.20220627142403-5be6d33a57cc” to pkg.go.dev. Note this may take up to several hours.

@golang golang locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants