Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log/slog: arg to Record.Attrs should return bool #59060

Open
jba opened this issue Mar 15, 2023 · 0 comments
Open

log/slog: arg to Record.Attrs should return bool #59060

jba opened this issue Mar 15, 2023 · 0 comments
Assignees
@jba
Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.21

Comments

@jba
Copy link
Contributor

jba commented Mar 15, 2023

The Record.Attrs method currently accepts an argument of type func(Attr).
For future consistency with iteration over func values, it should accept func(Attr) bool.
@jba jba self-assigned this Mar 15, 2023
@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 15, 2023
@cherrymui cherrymui added this to the Go1.21 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jba jba

Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@cherrymui @jba