/ go Public
x/tools/gopls: don't hang in allImportsFixes #59216
Issues related to the Go language server, gopls.
Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1
This label describes issues relating to any tools in the x/tools repository.
Thanks to the newly improved trace view, I have noticed that sometimes my gopls gets into a state where it hangs behind 'allImportFixes'. I expect this is the source of the often reported bug of 'waiting for code actions' from VS Code
Sample trace below, where AllImportsFixes took 3s for x/tools. (by comparison, type-checking all of x/tools from scratch takes ~3s).
I don't think we should ever wait a significant amount of time for allImportsFixes. goimports is already imprecise and/or nondeterministic, depending on the state of the module cache.
The text was updated successfully, but these errors were encountered: