Skip to content

cmd/compile: crypto/elliptic build error under -linkshared mode [1.20 backport] #59236

Closed

Description

@gopherbot

@cuonglm requested issue #58966 to be considered for backport to the next 1.20 minor release.

@gopherbot please backport this issue to go1.20

Activity

  1. added
    CherryPickCandidateUsed during the release process for point releases
    compiler/runtimeIssues related to the Go compiler and/or runtime.
    on Mar 25, 2023
  2. added this to the Go1.20.3 milestone on Mar 25, 2023
  3. cuonglm commented on Mar 25, 2023

    @cuonglm
    Member

    The issue affects projects built with -linkshared, and can be seen in real world projects.

    cc @cherrymui @mdempsky

  4. gopherbot commented on Mar 25, 2023

    @gopherbot
    ContributorAuthor

    Change https://go.dev/cl/479355 mentions this issue: [release-branch.go1.20] cmd/compile: re-compile instantiated generic methods in linkshared mode

  5. cuonglm commented on Mar 29, 2023

    @cuonglm
    Member
  6. heschi commented on Mar 29, 2023

    @heschi
    Contributor

    Even though this affects generics, the fix seems safe, since it only applies to linkshared. Approved.

  7. added a commit that references this issue on Mar 29, 2023
    94c02a3
  8. mdempsky commented on Mar 29, 2023

    @mdempsky
    Contributor

    Even though this affects generics

    FWIW, the compiler team's concerns with generics backports was largely specific to the Go 1.18 release. Especially since Go 1.20, I think we can treat generics issues the same as any other compiler/language issue.

  9. gopherbot commented on Mar 29, 2023

    @gopherbot
    ContributorAuthor

    Closed by merging 94c02a3 to release-branch.go1.20.

  10. locked and limited conversation to collaborators on Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CherryPickApprovedUsed during the release process for point releasesFrozenDueToAgecompiler/runtimeIssues related to the Go compiler and/or runtime.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions