-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: package removal request for github.com/vinegarhq/vinegar and github.com/vinegar-dev/vinegar #59278
Comments
Hi, this package removal request includes removing github.com/vinegarhq/vinegar, but you say that you want to github.com/vinegarhq/vinegar to be available? That is not how removal requests work, I'm afraid: we can only remove paths entirely, not selected versions. To remove selected versions, you will need to use module retraction: https://go.dev/ref/mod#go-mod-file-retract Can you please look into this, and let us know if you are able to achieve what you want with module retraction? |
We currently have a versioning issue, which means the pkgsite has an old 1.0.0 version cached from February, while we currently have a new 1.0.0 from March. Will retracting 1.0.0 remove both versions or just one? Additionally, the github organization name changed, so github.com/vinegar-dev/vinegar is safe to remove. |
Just to reiterate, we are unsure what to specify to retract (as we have two 1.0.0s) but we are OK with the vinegar-dev link being removed. |
Nevermind, the version retraction is a moot point. We have v1.0.1 now, so we will simply retract the other versions. However, we still need github.com/vinegar-dev/vinegar removed. Thanks |
This is done. |
Could you also remove the import path Thanks. |
Retracting v1.0.0 will prevent the Go command from resolving v1.0.0. @apprehensions you should be able remove github.com/vinegarhq/vinegar/v2 using module retraction. Just retract v2.3.5. |
(note that this retraction must be done with a v2 module: see for example #59577 (comment)). It is probably not a good idea to exclude the v2 prefix, as if you ever decided to publish a v2 version in the future the exclusion would prevent it from being visible on pkg.go.dev. |
|
What is the path of the package that you would like to have removed?
github.com/vinegarhq/vinegar
Are you the owner of this package?
Yes
What is the reason that you could not retract this package instead?
Currently, there are two vinegar packages, github.com/vinegarhq/vinegar and github.com/vinegar-dev/vinegar, both of which are outdated. Previously, we failed to follow the go recommendations for v2 releases which caused issues with the pkgsite, so we have reset our versioning back to v1.0.0. Ideally, we would like for there to be a singular
github.com/vinegarhq/vinegar
package with only the new v1.0.0 release available.The text was updated successfully, but these errors were encountered: