net/http: TestTransportRemovesDeadIdleConnections failures

[gopherbot]

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportRemovesDeadIdleConnections" && `expected a different connection`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportRemovesDeadIdleConnections (0.00s)
    --- FAIL: TestTransportRemovesDeadIdleConnections/h1 (0.05s)
        transport_test.go:775: expected a different connection between requests. got "127.0.0.1:57295" both times

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportRemovesDeadIdleConnections"

2023-04-04 16:59 dragonfly-amd64-622 go@20374d1d net/http.TestTransportRemovesDeadIdleConnections (log)

--- FAIL: TestTransportRemovesDeadIdleConnections (0.00s)
    --- FAIL: TestTransportRemovesDeadIdleConnections/h1 (0.05s)
        transport_test.go:775: expected a different connection between requests. got "127.0.0.1:57295" both times

— watchflakes

[bcmills]

I think this test is just bogus. It is assuming that the port used for the first connection will not be reused when dialing the second connection.

(CC @neild)

[gopherbot]

Change https://go.dev/cl/482175 mentions this issue: net/http: drop client address comparison in TestTransportRemovesDeadIdleConnections