text/template: Improved template check

[gopherbot]

by kaixinlaoshu2008:

What steps will reproduce the problem?

template.Must(...) [no error]
template.Execute(...) [error]

And I confirm that the background code is correct

What is the expected output?

show the webpage

What do you see instead?

error

Which compiler are you using (5g, 6g, 8g, gccgo)?

8g

Which operating system are you using?

win7

Which version are you using?  (run 'go version')

go1.1

Please provide any additional information below.

I later found that the reasons:One more  <script> on the web page.
so i sugges improving template check

[rsc]

Comment 1:

This report does not contain enough information to act upon.

Status changed to Invalid.

[gopherbot]

Comment 2 by kaixinlaoshu2008:

1.load template(*.htm)
fileInfoArr, err := ioutil.ReadDir(TEMPLATE_DIR)
    if err != nil {
        panic(err)
        return
    }
    var templateName, templatePath string
    for _, fileInfo := range fileInfoArr {
        templateName = fileInfo.Name()
        if ext := path.Ext(templateName); ext != ".htm" {
            continue
        }
        templatePath = TEMPLATE_DIR + "/" + templateName
        //log.Println("Loading template:", templatePath)
        t := template.Must(template.ParseFiles(templatePath))
        templates[templateName] = t
    }
//Call the function
func renderHtml(w http.ResponseWriter, tmpl string, locals map[string]interface{}) (err
error) {
    log.Printf("read templates:" + tmpl)
    tmpl += ".htm"
    err = templates[tmpl].Execute(w, locals)
    return
}
2.load auth.htm
    renderHtml(w, "auth", map[string]interface{}{
        "error": err_info,
        "Id": id,
    })
when One more  <script> on auth.htm, template.Execute error and the page cannot
show.

[adg]

Comment 3:

What error messages do you get?

Status changed to WaitingForReply.

[rsc]

Comment 4:

Labels changed: added go1.3maybe.

[rsc]

Comment 6:

Labels changed: added release-none, removed go1.3maybe.

[rsc]

Comment 7:

Labels changed: added repo-main.

[davecheney]

Comment 8:

Status changed to TimedOut.