Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: don't discard errors computing diagnostics #59487

Open
adonovan opened this issue Apr 7, 2023 · 0 comments
Open

x/tools/gopls: don't discard errors computing diagnostics #59487

adonovan opened this issue Apr 7, 2023 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@adonovan
Copy link
Member

adonovan commented Apr 7, 2023 •
edited
Loading

The diagnostics logic in gopls must deal with many kinds of error, but ultimately they all get merely written to the server log because there is no place to show them to the user. But this means serious internal errors such as the one reported in #58152 (comment) (whose root cause is #59289) are only detected this way.

We should make sure to use bug.Report for internal errors (bugs), and think about other ways to gather up errors (e.g. serious misconfiguration) so that they don't get neglected.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 7, 2023
@gopherbot gopherbot added this to the Unreleased milestone Apr 7, 2023
@hyangah hyangah modified the milestones: Unreleased, gopls/later Apr 13, 2023
@hyangah hyangah added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@hyangah @adonovan @gopherbot