Skip to content

x/tools/gopls: don't discard errors computing diagnostics #59487

Description

@adonovan

The diagnostics logic in gopls must deal with many kinds of error, but ultimately they all get merely written to the server log because there is no place to show them to the user. But this means serious internal errors such as the one reported in #58152 (comment) (whose root cause is #59289) are only detected this way.

We should make sure to use bug.Report for internal errors (bugs), and think about other ways to gather up errors (e.g. serious misconfiguration) so that they don't get neglected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions