-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: go buildid actionID part is not reproducible with clean cache #59553
Comments
A few more notes:
|
See golang/go#59553 The problem is that `buildid` is not reproducible for Talos builds with Go 1.20+. Remove the `buildid` until the issue is resolved to make builds reproducible. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
yes, we do use generics, but go1.19 doesn't show this behavior. What is the best way for me to check for this? I'm not sure how can I easily see what goes into
For this case I was building on latest Ubuntu, so pretty much gcc which ships with it. But I tried with |
@smira if you build Go from the current development branch I believe you'll see the problem is fixed. |
@rcs thank you, verfied with We'll be waiting for go1.20.4! |
See golang/go#59553 The problem is that `buildid` is not reproducible for Talos builds with Go 1.20+. Remove the `buildid` until the issue is resolved to make builds reproducible. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com> (cherry picked from commit bd1cff3)
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes, but it looks like it's a regression from go1.19.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
The buildid stays the same.
What did you see instead?
The buildid changes every time I run a build with a clean cache.
The
contentID
part stays the same, butactionID
is always different.I can't reproduce it with other Go programs, but Talos source code exhibits this issue.
If I repeat the same steps e.g. with
go1.19.4
, the buildid stays the same.I noticed this issue initially with our Dockerized build environment, but I reduced it down to a single binary.
If inspected with
diffoscope
, the only actual difference in the binary is thebuildid
itself:The text was updated successfully, but these errors were encountered: