Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: package removal request for fauna/faunadb-go/v5 #59577

Closed
adambollen opened this issue Apr 12, 2023 · 5 comments
Closed

x/pkgsite: package removal request for fauna/faunadb-go/v5 #59577

adambollen opened this issue Apr 12, 2023 · 5 comments
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone

Comments

@adambollen
Copy link

What is the path of the package that you would like to have removed?

https://pkg.go.dev/github.com/fauna/faunadb-go/v5 (only deprecating v5; other versions remain untouched)

Are you the owner of this package?

Yes, I'm an engineer with Fauna, Inc.; I've been tasked with deprecating the v5 version of our drivers.

What is the reason that you could not retract this package instead?

We have deleted the branch that hosted the v5 version of our drivers and we don't intend to push a new version in the v5 path, so retracting isn't feasible.

@gopherbot gopherbot added this to the Unreleased milestone Apr 12, 2023
@bcmills
Copy link
Contributor

bcmills commented Apr 12, 2023

We have deleted the branch that hosted the v5 version of our drivers and we don't intend to push a new version in the v5 path, so retracting isn't feasible.

Why not push a new version in order to publish the retract directive and deprecation notice?

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Apr 12, 2023
@adambollen
Copy link
Author

Thanks for the quick reply, @bcmills . As mentioned, the branch from which we released this v5 version doesn't exist anymore and we aren't planning on releasing any more versions in the v5 path.

Here's the go.mod for our v4 path: https://github.com/fauna/faunadb-go/blob/v4/go.mod - my understanding is that if I updated the file temporarily to point to the v5 path and published a retraction of 5.0.0-beta, that would necessarily push a new v5 version, correct? And my guess is that I can't simply add the retract directive to the current go.mod (that points at v4) to retract a v5 version.

Appreciate any help you can provide; if I've made a wrong assumption (I'm not a golang expert), let me know. Thanks!

@bcmills
Copy link
Contributor

bcmills commented Apr 12, 2023

As mentioned, the branch from which we released this v5 version doesn't exist anymore and we aren't planning on releasing any more versions in the v5 path.

You don't need to recreate the whole branch to publish a v5 version. (All it takes is a single commit with a version tag, and if it has an explicit tag it doesn't even need to be reachable from any branch that remains.)

@bcmills
Copy link
Contributor

bcmills commented Apr 12, 2023

my understanding is that if I updated the file temporarily to point to the v5 path and published a retraction of 5.0.0-beta, that would necessarily push a new v5 version, correct?

Yes, you would need to publish a new v5 version (like v5.0.0-deprecated) and have its retract directive include that version as well (so that v5.0.0-deprecated retracts itself along with all previous versions of its path).

@bcmills bcmills removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Apr 12, 2023
@adambollen
Copy link
Author

my understanding is that if I updated the file temporarily to point to the v5 path and published a retraction of 5.0.0-beta, that would necessarily push a new v5 version, correct?

Yes, you would need to publish a new v5 version (like v5.0.0-deprecated) and have its retract directive include that version as well (so that v5.0.0-deprecated retracts itself along with all previous versions of its path).

Ah, I think this was my misunderstanding; I presumed that I couldn't retract the version I was also publishing. I'll go that route. Thanks!

@findleyr findleyr added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label Apr 13, 2023
@jamalc jamalc closed this as completed Apr 28, 2023
@golang golang locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants