x/crypto: preferredKexAlgos in golang.org/x/crypto/ssh includes SHA1 #59593
Labels
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Built an SSH server using
x/crypto/ssh
, and ranssh -vvv
to connect to it.What did you expect to see?
I expected the server to present KEX algorithms excluding any using SHA1.
What did you see instead?
The default algorithms used by the ssh server appears to be configured here:
https://github.com/golang/crypto/blob/1faeef9713563c936e077b84e4c3a0f3cac0fbe4/ssh/common.go#L62-L68
Does it make sense to remove
kexAlgoDH14SHA1
from the preferred KEX algorithm list? I note that NIST has announced SHA1's retirement, and GitHub discontinued SSH SHA1 support way back in 2018.The text was updated successfully, but these errors were encountered: