Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/goimports: move custom group imports set with "-local" flag to bottom of imports with no spaces. #59597

Open
effinsky opened this issue Apr 13, 2023 · 1 comment
Open

x/tools/cmd/goimports: move custom group imports set with "-local" flag to bottom of imports with no spaces. #59597

effinsky opened this issue Apr 13, 2023 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@effinsky
Copy link

Imports mal-grouped:

Screenshot 2023-04-13 at 11 00 57

Current behavior of running goimports -local 'github.com/shi**' is:
Screenshot 2023-04-13 at 11 01 17

Desired behavior is:
Screenshot 2023-04-13 at 11 02 02

This is from neovim with vim-go. I don't think it's a config problem. I have run the cmd in the shell on the file as well, with same results.

Thanks!
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Apr 13, 2023
@gopherbot gopherbot added this to the Unreleased milestone Apr 13, 2023
@dr2chase
Copy link
Contributor

@heschi @bradfitz

@dr2chase dr2chase added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dr2chase @gopherbot @effinsky