Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime, cmd/compile: share more constants #59670

Open
aclements opened this issue Apr 17, 2023 · 26 comments
Open

runtime, cmd/compile: share more constants #59670

aclements opened this issue Apr 17, 2023 · 26 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone

Comments

@aclements
Copy link
Member

CL 462115 merged a few constants that were duplicated between several runtime-related and toolchain-related packages into a single internal/abi package. This is an internal cleanup tracking issue for merging more of these constants.

@aclements aclements added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 17, 2023
@aclements aclements added this to the Unplanned milestone Apr 17, 2023
@aclements aclements self-assigned this Apr 17, 2023
@gopherbot
Copy link

Change https://go.dev/cl/485195 mentions this issue: cmd/commonconst: find duplicated constants

@aclements
Copy link
Member Author

aclements commented Apr 17, 2023

For anyone curious, here are the duplicated constants my little tool found. Some of these are only coincidental, but most are real duplicates.

ABIInternal          cmd/internal/obj/link.go:681:2
LinkInternal         cmd/link/internal/ld/config.go:86:2

AMD64                cmd/internal/sys/arch.go:15:2
AMD64                cmd/link/internal/loadelf/ldelf.go:965:3

ARM64                cmd/internal/sys/arch.go:17:2
ARM64                cmd/link/internal/loadelf/ldelf.go:967:3

BRANCH               cmd/internal/obj/arm64/a.out.go:331:2
BRANCH               cmd/internal/obj/loong64/a.out.go:193:2
BRANCH               cmd/internal/obj/ppc64/a.out.go:349:2
stmtBranch           cmd/compile/internal/noder/codes.go:24:2

BlkRefFlags          cmd/internal/goobj/objfile.go:195:2
ScoreFlags           cmd/compile/internal/ssa/schedule.go:24:2

FuncAlign            cmd/internal/obj/loong64/asm.go:31:2
funcAlign            cmd/link/internal/arm/l.go:68:2
FuncAlign            cmd/link/internal/mips/l.go:67:2

HashSize             cmd/internal/goobj/objfile.go:372:7
hashSize             cmd/compile/internal/staticdata/embed.go:150:9

Hunknown             cmd/internal/objabi/head.go:39:2
EscUnknown           cmd/compile/internal/ir/node.go:594:2
unknown              cmd/compile/internal/ssa/prove.go:16:2

Invalid              internal/reflectlite/type.go:78:2
Invalid              (PUBLIC) reflect/type.go:244:2
OpInvalid            cmd/compile/internal/ssa/opGen.go:338:2
undoInvalid          cmd/compile/internal/ssa/poset.go:45:2
invalid              cmd/compile/internal/types2/operand.go:22:2
Invalid              cmd/compile/internal/types2/basic.go:11:2

LABEL                cmd/internal/obj/arm64/a.out.go:328:2
LABEL                cmd/internal/obj/loong64/a.out.go:190:2
LABEL                cmd/internal/obj/ppc64/a.out.go:346:2
stmtLabel            cmd/compile/internal/noder/codes.go:17:2

LC_CODE_SIGNATURE    cmd/internal/codesign/codesign.go:43:7
LC_CODE_SIGNATURE    cmd/link/internal/ld/macho.go:159:2

LINE_BASE            cmd/internal/obj/dwarf.go:21:2
LINE_BASE            cmd/link/internal/ld/dwarf.go:1098:2

LINE_RANGE           cmd/internal/obj/dwarf.go:22:2
LINE_RANGE           cmd/link/internal/ld/dwarf.go:1099:2

Loong64              cmd/internal/sys/arch.go:19:2
LOONG64              cmd/link/internal/loadelf/ldelf.go:969:3

MIPS64               cmd/internal/sys/arch.go:21:2
MIPS64               cmd/link/internal/loadelf/ldelf.go:971:3

N_ABS                cmd/link/internal/ld/xcoff.go:188:2
N_ABS                cmd/internal/objfile/xcoff.go:34:4
N_ABS                cmd/internal/objfile/pe.go:40:4

N_DEBUG              cmd/link/internal/ld/xcoff.go:187:2
N_DEBUG              cmd/internal/objfile/xcoff.go:35:4
N_DEBUG              cmd/internal/objfile/pe.go:41:4

OPCODE_BASE          cmd/internal/obj/dwarf.go:24:2
OPCODE_BASE          cmd/link/internal/ld/dwarf.go:1101:2

OP_ADD               cmd/internal/obj/ppc64/asm9.go:2307:2
OP_ADD               cmd/link/internal/ppc64/asm.go:1237:9

OP_ADDI              cmd/internal/obj/ppc64/asm9.go:2308:2
OP_ADDI              cmd/link/internal/ppc64/asm.go:1263:9

OP_ADDIS             cmd/internal/obj/ppc64/asm9.go:2309:2
OP_ADDIS             cmd/link/internal/ppc64/asm.go:563:11

PC_RANGE             cmd/internal/obj/dwarf.go:23:2
PC_RANGE             cmd/link/internal/ld/dwarf.go:1100:2

PPC64                cmd/internal/sys/arch.go:22:2
PPC64                cmd/link/internal/loadelf/ldelf.go:972:3

Pointer              internal/reflectlite/type.go:100:2
Pointer              (PUBLIC) reflect/type.go:266:2

RISCV64              cmd/internal/sys/arch.go:23:2
RISCV64              cmd/link/internal/loadelf/ldelf.go:973:3

R_CALLIND            cmd/internal/objabi/reloctype.go:57:2
Zcallind             cmd/internal/obj/x86/asm6.go:208:2

RefNameSize          cmd/internal/goobj/objfile.go:507:7
frameSize            cmd/internal/obj/riscv/obj.go:750:9
frameSize            cmd/internal/obj/s390x/objz.go:596:9

S390X                cmd/internal/sys/arch.go:24:2
S390X                cmd/link/internal/loadelf/ldelf.go:974:3

STEXT                cmd/internal/objabi/symkind.go:46:2
STEXT                cmd/link/internal/sym/symkind.go:45:2

StackAlign           runtime/internal/sys/consts.go:36:7
maxAlign             runtime/chan.go:28:2
APCALIGN             cmd/internal/obj/link.go:423:2
maxAlign             cmd/link/internal/arm/l.go:66:2
funcAlign            cmd/link/internal/loong64/l.go:10:2
funcAlign            cmd/link/internal/mips64/l.go:67:2
funcAlign            cmd/link/internal/riscv64/l.go:10:2

TFUNCARGS            cmd/compile/internal/types/type.go:71:2
funcAlign            cmd/link/internal/amd64/l.go:36:2

_ArgsSizeUnknown     runtime/symtab.go:316:2
ArgsSizeUnknown      cmd/internal/objabi/funcdata.go:32:2

_DT_NULL             runtime/vdso_linux.go:28:2
_AT_NULL             runtime/os_linux.go:216:2
C_NULL               cmd/link/internal/ld/xcoff.go:201:2

_FUNCDATA_ArgInfo    runtime/symtab.go:312:2
FUNCDATA_ArgInfo     cmd/internal/objabi/funcdata.go:24:2

_FUNCDATA_ArgLiveInfo runtime/symtab.go:313:2
FUNCDATA_ArgLiveInfo cmd/internal/objabi/funcdata.go:25:2

_FUNCDATA_ArgsPointerMaps runtime/symtab.go:307:2
FUNCDATA_ArgsPointerMaps cmd/internal/objabi/funcdata.go:19:2

_FUNCDATA_InlTree    runtime/symtab.go:310:2
FUNCDATA_InlTree     cmd/internal/objabi/funcdata.go:22:2

_FUNCDATA_LocalsPointerMaps runtime/symtab.go:308:2
FUNCDATA_LocalsPointerMaps cmd/internal/objabi/funcdata.go:20:2

_FUNCDATA_OpenCodedDeferInfo runtime/symtab.go:311:2
FUNCDATA_OpenCodedDeferInfo cmd/internal/objabi/funcdata.go:23:2

_FUNCDATA_StackObjects runtime/symtab.go:309:2
FUNCDATA_StackObjects cmd/internal/objabi/funcdata.go:21:2

_FUNCDATA_WrapInfo   runtime/symtab.go:314:2
FUNCDATA_WrapInfo    cmd/internal/objabi/funcdata.go:26:2

_PCDATA_ArgLiveIndex runtime/symtab.go:305:2
PCDATA_ArgLiveIndex  cmd/internal/objabi/funcdata.go:17:2

_PCDATA_InlTreeIndex runtime/symtab.go:304:2
PCDATA_InlTreeIndex  cmd/internal/objabi/funcdata.go:16:2

_PCDATA_Restart1     runtime/symtab.go:329:2
PCDATA_Restart1      cmd/internal/objabi/funcdata.go:46:2

_PCDATA_Restart2     runtime/symtab.go:330:2
PCDATA_Restart2      cmd/internal/objabi/funcdata.go:47:2

_PCDATA_RestartAtEntry runtime/symtab.go:334:2
PCDATA_RestartAtEntry cmd/internal/objabi/funcdata.go:50:2

_PCDATA_StackMapIndex runtime/symtab.go:303:2
PCDATA_StackMapIndex cmd/internal/objabi/funcdata.go:15:2

_PCDATA_UnsafePoint  runtime/symtab.go:302:2
PCDATA_UnsafePoint   cmd/internal/objabi/funcdata.go:14:2

_PCDATA_UnsafePointSafe runtime/symtab.go:321:2
PCDATA_UnsafePointSafe cmd/internal/objabi/funcdata.go:38:2

_PCDATA_UnsafePointUnsafe runtime/symtab.go:322:2
PCDATA_UnsafePointUnsafe cmd/internal/objabi/funcdata.go:39:2

_PROT_NONE           runtime/defs_linux_amd64.go:13:2
REG_NONE             cmd/internal/obj/util.go:17:7
REG_NONE             cmd/internal/obj/wasm/a.out.go:264:2
REG_NONE             cmd/internal/obj/x86/a.out.go:36:2
RV_NONE              cmd/link/internal/sym/reloc.go:17:2

_PROT_READ           runtime/defs_linux_amd64.go:14:2
SR_READ              cmd/internal/obj/arm64/sysRegEnc.go:442:2

_PROT_WRITE          runtime/defs_linux_amd64.go:15:2
SR_WRITE             cmd/internal/obj/arm64/sysRegEnc.go:443:2

_SHN_UNDEF           runtime/vdso_linux.go:38:2
N_UNDEF              cmd/link/internal/ld/xcoff.go:189:2
N_UNDEF              cmd/internal/objfile/pe.go:39:4
N_UNDEF              cmd/internal/objfile/xcoff.go:33:4

_StackBig            runtime/stack.go:93:2
StackBig             cmd/internal/objabi/stack.go:14:2

_StackSmall          runtime/stack.go:107:2
StackSmall           cmd/internal/objabi/stack.go:15:2

_dotdotdot           runtime/traceback.go:645:3
_dotdotdot           cmd/compile/internal/ssagen/ssa.go:6758:3

_endAgg              runtime/traceback.go:644:3
_endAgg              cmd/compile/internal/ssagen/ssa.go:6757:3

_endSeq              runtime/traceback.go:642:3
_endSeq              cmd/compile/internal/ssagen/ssa.go:6755:3

_offsetTooLarge      runtime/traceback.go:646:3
_offsetTooLarge      cmd/compile/internal/ssagen/ssa.go:6759:3

_startAgg            runtime/traceback.go:643:3
_startAgg            cmd/compile/internal/ssagen/ssa.go:6756:3

align                cmd/compile/internal/base/timings.go:208:8
minAlign             cmd/link/internal/amd64/l.go:35:2
minAlign             cmd/link/internal/arm/l.go:67:2
minAlign             cmd/link/internal/arm64/l.go:66:2
minAlign             cmd/link/internal/loong64/l.go:9:2
MinAlign             cmd/link/internal/mips/l.go:66:2
minAlign             cmd/link/internal/mips64/l.go:66:2
minAlign             cmd/link/internal/ppc64/l.go:66:2
minAlign             cmd/link/internal/riscv64/l.go:9:2
minAlign             cmd/link/internal/x86/l.go:35:2

bothDir              internal/reflectlite/type.go:193:2
BothDir              (PUBLIC) reflect/type.go:360:2

boundsIndex          runtime/error.go:127:2
BoundsIndex          cmd/compile/internal/ssa/op.go:462:2

boundsSlice3Acap     runtime/error.go:134:2
BoundsSliceAcapU     cmd/compile/internal/ssa/op.go:467:2

boundsSlice3Alen     runtime/error.go:133:2
BoundsSliceAcap      cmd/compile/internal/ssa/op.go:466:2

boundsSlice3B        runtime/error.go:135:2
BoundsSliceB         cmd/compile/internal/ssa/op.go:468:2

boundsSlice3C        runtime/error.go:136:2
BoundsSliceBU        cmd/compile/internal/ssa/op.go:469:2

boundsSliceAcap      runtime/error.go:130:2
BoundsSliceAlen      cmd/compile/internal/ssa/op.go:464:2

bucketCnt            runtime/map.go:67:2
bucketSize           reflect/type.go:2230:2
BUCKETSIZE           cmd/compile/internal/reflectdata/reflect.go:75:2
BucketSize           cmd/link/internal/ld/dwarf.go:861:2

cutoff               cmd/internal/obj/objfile.go:308:7
cutoff               cmd/link/internal/ld/data.go:1337:7

debugPcln            runtime/symtab.go:601:7
debugChan            runtime/chan.go:30:2
debug                cmd/compile/internal/typecheck/iexport.go:272:2
debugPhi             cmd/compile/internal/ssagen/phi.go:25:7
debug                cmd/compile/internal/syntax/parser.go:14:7
debug                cmd/compile/internal/types2/check.go:21:7
debug                cmd/compile/internal/types2/initorder.go:25:8

flagAddr             internal/reflectlite/value.go:72:2
flagAddr             reflect/value.go:78:2

flagEmbedRO          internal/reflectlite/value.go:70:2
flagEmbedRO          reflect/value.go:76:2

flagIndir            internal/reflectlite/value.go:71:2
flagIndir            reflect/value.go:77:2

flagKindWidth        internal/reflectlite/value.go:67:2
flagKindWidth        reflect/value.go:73:2

flagMethod           internal/reflectlite/value.go:73:2
flagMethod           reflect/value.go:79:2

flagMethodShift      internal/reflectlite/value.go:74:2
flagMethodShift      reflect/value.go:80:2

flagRO               internal/reflectlite/value.go:75:2
flagRO               reflect/value.go:81:2

flagStickyRO         internal/reflectlite/value.go:69:2
flagStickyRO         reflect/value.go:75:2

funcAlign            cmd/internal/obj/arm64/asm7.go:63:2
funcAlign            cmd/internal/obj/s390x/asmz.go:55:2
loopAlign            cmd/internal/obj/x86/asm6.go:63:2
funcAlign            cmd/link/internal/arm64/l.go:67:2
funcAlign            cmd/link/internal/ppc64/l.go:67:2
funcAlign            cmd/link/internal/s390x/l.go:67:2
funcAlign            cmd/link/internal/x86/l.go:36:2

funcFlag_ASM         runtime/symtab.go:392:2
FuncFlag_ASM         cmd/internal/objabi/funcid.go:16:2

funcFlag_SPWRITE     runtime/symtab.go:389:2
FuncFlag_SPWRITE     cmd/internal/objabi/funcid.go:15:2

funcFlag_TOPFRAME    runtime/symtab.go:380:2
FuncFlag_TOPFRAME    cmd/internal/objabi/funcid.go:14:2

funcID_abort         runtime/symtab.go:346:2
FuncID_abort         cmd/internal/objabi/funcid.go:28:2

funcID_asmcgocall    runtime/symtab.go:347:2
FuncID_asmcgocall    cmd/internal/objabi/funcid.go:29:2

funcID_asyncPreempt  runtime/symtab.go:348:2
FuncID_asyncPreempt  cmd/internal/objabi/funcid.go:30:2

funcID_cgocallback   runtime/symtab.go:349:2
FuncID_cgocallback   cmd/internal/objabi/funcid.go:31:2

funcID_debugCallV2   runtime/symtab.go:350:2
FuncID_debugCallV2   cmd/internal/objabi/funcid.go:32:2

funcID_gcBgMarkWorker runtime/symtab.go:351:2
FuncID_gcBgMarkWorker cmd/internal/objabi/funcid.go:33:2

funcID_goexit        runtime/symtab.go:352:2
FuncID_goexit        cmd/internal/objabi/funcid.go:34:2

funcID_gogo          runtime/symtab.go:353:2
FuncID_gogo          cmd/internal/objabi/funcid.go:35:2

funcID_gopanic       runtime/symtab.go:354:2
FuncID_gopanic       cmd/internal/objabi/funcid.go:36:2

funcID_handleAsyncEvent runtime/symtab.go:355:2
FuncID_handleAsyncEvent cmd/internal/objabi/funcid.go:37:2

funcID_mcall         runtime/symtab.go:356:2
FuncID_mcall         cmd/internal/objabi/funcid.go:38:2

funcID_morestack     runtime/symtab.go:357:2
FuncID_morestack     cmd/internal/objabi/funcid.go:39:2

funcID_mstart        runtime/symtab.go:358:2
FuncID_mstart        cmd/internal/objabi/funcid.go:40:2

funcID_normal        runtime/symtab.go:345:2
FuncID_normal        cmd/internal/objabi/funcid.go:27:2

funcID_panicwrap     runtime/symtab.go:359:2
FuncID_panicwrap     cmd/internal/objabi/funcid.go:41:2

funcID_rt0_go        runtime/symtab.go:360:2
FuncID_rt0_go        cmd/internal/objabi/funcid.go:42:2

funcID_runfinq       runtime/symtab.go:361:2
FuncID_runfinq       cmd/internal/objabi/funcid.go:43:2

funcID_runtime_main  runtime/symtab.go:362:2
FuncID_runtime_main  cmd/internal/objabi/funcid.go:44:2

funcID_sigpanic      runtime/symtab.go:363:2
FuncID_sigpanic      cmd/internal/objabi/funcid.go:45:2

funcID_systemstack   runtime/symtab.go:364:2
FuncID_systemstack   cmd/internal/objabi/funcid.go:46:2

funcID_systemstack_switch runtime/symtab.go:365:2
FuncID_systemstack_switch cmd/internal/objabi/funcid.go:47:2

funcID_wrapper       runtime/symtab.go:366:2
FuncID_wrapper       cmd/internal/objabi/funcid.go:48:2

kindArray            runtime/typekind.go:24:2
Array                internal/reflectlite/type.go:95:2
Array                (PUBLIC) reflect/type.go:261:2
KindArray            cmd/internal/objabi/typekind.go:27:2
kindArray            cmd/link/internal/ld/decodesym.go:98:2

kindBool             runtime/typekind.go:8:2
KindBool             cmd/internal/objabi/typekind.go:11:2

kindChan             runtime/typekind.go:25:2
KindChan             cmd/internal/objabi/typekind.go:28:2
kindChan             cmd/link/internal/ld/decodesym.go:99:2

kindComplex128       runtime/typekind.go:23:2
Complex128           internal/reflectlite/type.go:94:2
Complex128           (PUBLIC) reflect/type.go:260:2
KindComplex128       cmd/internal/objabi/typekind.go:26:2
Complex128           cmd/compile/internal/types2/basic.go:29:2

kindComplex64        runtime/typekind.go:22:2
Complex64            internal/reflectlite/type.go:93:2
Complex64            (PUBLIC) reflect/type.go:259:2
KindComplex64        cmd/internal/objabi/typekind.go:25:2
Complex64            cmd/compile/internal/types2/basic.go:28:2

kindDirectIface      runtime/typekind.go:35:2
kindDirectIface      internal/reflectlite/type.go:382:2
kindDirectIface      reflect/type.go:629:2
KindDirectIface      cmd/internal/objabi/typekind.go:37:2

kindFloat32          runtime/typekind.go:20:2
Float32              internal/reflectlite/type.go:91:2
Float32              (PUBLIC) reflect/type.go:257:2
KindFloat32          cmd/internal/objabi/typekind.go:23:2
Float32              cmd/compile/internal/types2/basic.go:26:2

kindFloat64          runtime/typekind.go:21:2
Float64              internal/reflectlite/type.go:92:2
Float64              (PUBLIC) reflect/type.go:258:2
KindFloat64          cmd/internal/objabi/typekind.go:24:2
Float64              cmd/compile/internal/types2/basic.go:27:2

kindFunc             runtime/typekind.go:26:2
KindFunc             cmd/internal/objabi/typekind.go:29:2
kindFunc             cmd/link/internal/ld/decodesym.go:100:2

kindGCProg           runtime/typekind.go:36:2
kindGCProg           internal/reflectlite/type.go:383:2
kindGCProg           reflect/type.go:630:2
KindGCProg           cmd/internal/objabi/typekind.go:38:2

kindInt              runtime/typekind.go:9:2
KindInt              cmd/internal/objabi/typekind.go:12:2

kindInt16            runtime/typekind.go:11:2
Int16                internal/reflectlite/type.go:82:2
Int16                (PUBLIC) reflect/type.go:248:2
KindInt16            cmd/internal/objabi/typekind.go:14:2
TUINT16              cmd/compile/internal/types/type.go:35:2
Int16                cmd/compile/internal/types2/basic.go:17:2

kindInt32            runtime/typekind.go:12:2
Int32                internal/reflectlite/type.go:83:2
Int32                (PUBLIC) reflect/type.go:249:2
KindInt32            cmd/internal/objabi/typekind.go:15:2
TINT32               cmd/compile/internal/types/type.go:36:2
Int32                cmd/compile/internal/types2/basic.go:18:2

kindInt64            runtime/typekind.go:13:2
Int64                internal/reflectlite/type.go:84:2
Int64                (PUBLIC) reflect/type.go:250:2
KindInt64            cmd/internal/objabi/typekind.go:16:2
Int64                cmd/compile/internal/types2/basic.go:19:2

kindInt8             runtime/typekind.go:10:2
KindInt8             cmd/internal/objabi/typekind.go:13:2

kindInterface        runtime/typekind.go:27:2
Interface            internal/reflectlite/type.go:98:2
Interface            (PUBLIC) reflect/type.go:264:2
KindInterface        cmd/internal/objabi/typekind.go:30:2
kindInterface        cmd/link/internal/ld/decodesym.go:101:2

kindMap              runtime/typekind.go:28:2
KindMap              cmd/internal/objabi/typekind.go:31:2
kindMap              cmd/link/internal/ld/decodesym.go:102:2

kindMask             runtime/typekind.go:37:2
flagKindMask         internal/reflectlite/value.go:68:2
kindMask             internal/reflectlite/type.go:384:2
flagKindMask         reflect/value.go:74:2
kindMask             reflect/type.go:631:2
KindMask             cmd/internal/objabi/typekind.go:39:2
wordMask             cmd/compile/internal/bitvec/bv.go:15:2
kindMask             cmd/link/internal/ld/decodesym.go:106:2

kindPtr              runtime/typekind.go:29:2
KindPtr              cmd/internal/objabi/typekind.go:32:2
kindPtr              cmd/link/internal/ld/decodesym.go:103:2

kindSlice            runtime/typekind.go:30:2
Slice                internal/reflectlite/type.go:101:2
Slice                (PUBLIC) reflect/type.go:267:2
KindSlice            cmd/internal/objabi/typekind.go:33:2
kindSlice            cmd/link/internal/ld/decodesym.go:104:2

kindString           runtime/typekind.go:31:2
String               internal/reflectlite/type.go:102:2
String               (PUBLIC) reflect/type.go:268:2
KindString           cmd/internal/objabi/typekind.go:34:2

kindStruct           runtime/typekind.go:32:2
Struct               internal/reflectlite/type.go:103:2
Struct               (PUBLIC) reflect/type.go:269:2
KindStruct           cmd/internal/objabi/typekind.go:35:2
kindStruct           cmd/link/internal/ld/decodesym.go:105:2

kindUint             runtime/typekind.go:14:2
KindUint             cmd/internal/objabi/typekind.go:17:2

kindUint16           runtime/typekind.go:16:2
Uint16               internal/reflectlite/type.go:87:2
Uint16               (PUBLIC) reflect/type.go:253:2
KindUint16           cmd/internal/objabi/typekind.go:19:2
Uint16               cmd/compile/internal/types2/basic.go:22:2

kindUint32           runtime/typekind.go:17:2
Uint32               internal/reflectlite/type.go:88:2
Uint32               (PUBLIC) reflect/type.go:254:2
KindUint32           cmd/internal/objabi/typekind.go:20:2
Uint32               cmd/compile/internal/types2/basic.go:23:2

kindUint64           runtime/typekind.go:18:2
Uint64               internal/reflectlite/type.go:89:2
Uint64               (PUBLIC) reflect/type.go:255:2
KindUint64           cmd/internal/objabi/typekind.go:21:2
Uint64               cmd/compile/internal/types2/basic.go:24:2

kindUint8            runtime/typekind.go:15:2
Uint8                internal/reflectlite/type.go:86:2
Uint8                (PUBLIC) reflect/type.go:252:2
KindUint8            cmd/internal/objabi/typekind.go:18:2
Uint8                cmd/compile/internal/types2/basic.go:21:2

kindUintptr          runtime/typekind.go:19:2
Uintptr              internal/reflectlite/type.go:90:2
Uintptr              (PUBLIC) reflect/type.go:256:2
KindUintptr          cmd/internal/objabi/typekind.go:22:2
Uintptr              cmd/compile/internal/types2/basic.go:25:2

kindUnsafePointer    runtime/typekind.go:33:2
UnsafePointer        internal/reflectlite/type.go:104:2
UnsafePointer        (PUBLIC) reflect/type.go:270:2
KindUnsafePointer    cmd/internal/objabi/typekind.go:36:2

limit                runtime/traceback.go:650:3
limit                cmd/compile/internal/ssagen/ssa.go:6764:3

maxDepth             runtime/traceback.go:651:3
maxDepth             cmd/compile/internal/ssagen/ssa.go:6765:3

maxElemSize          runtime/map.go:80:2
MAXELEMSIZE          cmd/compile/internal/reflectdata/reflect.go:77:2

maxKeySize           runtime/map.go:79:2
maxKeySize           reflect/type.go:2231:2
MAXKEYSIZE           cmd/compile/internal/reflectdata/reflect.go:76:2
MaxKeySize           cmd/link/internal/ld/dwarf.go:859:2

maxLen               runtime/traceback.go:652:3
maxLen               cmd/compile/internal/ssagen/ssa.go:6772:3

maxPtrmaskBytes      reflect/type.go:2893:7
maxPtrmaskBytes      cmd/compile/internal/reflectdata/reflect.go:1552:7

maxValSize           reflect/type.go:2232:2
MaxValSize           cmd/link/internal/ld/dwarf.go:860:2

maxZero              runtime/map.go:1423:7
maxZero              reflect/value.go:3193:7

minfunc              runtime/symtab.go:579:7
MINFUNC              cmd/link/internal/ld/lib.go:272:2

pageSize             runtime/string.go:529:8
pageSize             cmd/internal/codesign/codesign.go:40:2
pageSize             cmd/link/internal/ld/pe.go:1478:8

pcbucketsize         runtime/symtab.go:580:7
BUCKETSIZE           cmd/link/internal/ld/pcln.go:826:2

recvDir              internal/reflectlite/type.go:191:2
RecvDir              (PUBLIC) reflect/type.go:358:2

selectDefault        runtime/select.go:538:2
SelectDefault        (PUBLIC) reflect/value.go:2954:2

selectRecv           runtime/select.go:537:2
SelectRecv           (PUBLIC) reflect/value.go:2953:2

selectSend           runtime/select.go:536:2
SelectSend           (PUBLIC) reflect/value.go:2952:2

sendDir              internal/reflectlite/type.go:192:2
SendDir              (PUBLIC) reflect/type.go:359:2

sigSending           runtime/sigqueue.go:65:2
InitPending          cmd/compile/internal/pkginit/initorder.go:61:2

stackFromSystem      runtime/stack.go:122:2
STACKSYSTEM          cmd/internal/objabi/stack.go:12:2
StackSystem          cmd/internal/objabi/stack.go:13:2

tagObject            runtime/heapdump.go:47:2
MH_OBJECT            cmd/link/internal/ld/macho.go:122:2

tflagExtraStar       runtime/type.go:26:2
tflagExtraStar       internal/reflectlite/type.go:137:2
tflagExtraStar       reflect/type.go:304:2
tflagExtraStar       cmd/compile/internal/reflectdata/reflect.go:682:2
tflagExtraStar       cmd/link/internal/ld/decodesym.go:31:2

tflagNamed           runtime/type.go:27:2
tflagNamed           internal/reflectlite/type.go:140:2
tflagNamed           reflect/type.go:307:2
tflagNamed           cmd/compile/internal/reflectdata/reflect.go:683:2

tflagRegularMemory   runtime/type.go:28:2
tflagRegularMemory   internal/reflectlite/type.go:144:2
tflagRegularMemory   reflect/type.go:311:2
tflagRegularMemory   cmd/compile/internal/reflectdata/reflect.go:684:2

tflagUncommon        runtime/type.go:25:2
tflagUncommon        internal/reflectlite/type.go:131:2
tflagUncommon        reflect/type.go:298:2
tflagUncommon        cmd/compile/internal/reflectdata/reflect.go:681:2
tflagUncommon        cmd/link/internal/ld/decodesym.go:30:2

tmpStringBufSize     runtime/string.go:16:7
tmpstringbufsize     cmd/compile/internal/walk/walk.go:21:7

wordShift            cmd/compile/internal/bitvec/bv.go:16:2
C_SHIFT              cmd/internal/obj/arm/a.out.go:148:2

writeLegacyFormat    cmd/compile/internal/gc/util.go:41:10
writeLegacyFormat    cmd/link/internal/ld/main.go:435:10

@gopherbot
Copy link

Change https://go.dev/cl/485495 mentions this issue: internal/abi, runtime, cmd: merge funcID_* consts into internal/abi

@gopherbot
Copy link

Change https://go.dev/cl/485496 mentions this issue: internal/abi, runtime, cmd: merge funcFlag_* consts into internal/abi

@gopherbot
Copy link

Change https://go.dev/cl/485497 mentions this issue: internal/abi, runtime, cmd: merge PCDATA_* and FUNCDATA_* consts into internal/abi

@gopherbot
Copy link

Change https://go.dev/cl/486381 mentions this issue: runtime: tidy _Stack* constant naming

@gopherbot
Copy link

Change https://go.dev/cl/486379 mentions this issue: internal/abi, runtime, cmd: merge StackSmall, StackBig consts into internal/abi

@gopherbot
Copy link

Change https://go.dev/cl/486380 mentions this issue: runtime, cmd: rationalize StackLimit and StackGuard

gopherbot pushed a commit that referenced this issue Apr 20, 2023
…ternal/abi

For #59670.

Change-Id: I04a17079b351b9b4999ca252825373c17afb8a88
Reviewed-on: https://go-review.googlesource.com/c/go/+/486379
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
gopherbot pushed a commit that referenced this issue Apr 20, 2023
The current definitions of StackLimit and StackGuard only indirectly
specify the NOSPLIT stack limit and duplicate a literal constant
(928). Currently, they define the stack guard delta, and from there
compute the NOSPLIT limit.

Rationalize these by defining a new constant, abi.StackNosplitBase,
which consolidates and directly specifies the NOSPLIT stack limit (in
the default case). From this we then compute the stack guard delta,
inverting the relationship between these two constants. While we're
here, we rename StackLimit to StackNosplit to make it clearer what's
being limited.

This change does not affect the values of these constants in the
default configuration. It does slightly change how
StackGuardMultiplier values other than 1 affect the constants, but
this multiplier is a pretty rough heuristic anyway.

                    before after
stackNosplit           800   800
_StackGuard            928   928
stackNosplit -race    1728  1600
_StackGuard -race     1856  1728

For #59670.

Change-Id: Ibe20825ebe0076bbd7b0b7501177b16c9dbcb79e
Reviewed-on: https://go-review.googlesource.com/c/go/+/486380
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Apr 20, 2023
For #59670.

Change-Id: I4476d6f92663e8a825d063d6e6a7fc9a2ac99d4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/486381
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/486975 mentions this issue: internal/abi, runtime, cmd: merge StackSmall, StackBig consts into internal/abi

@gopherbot
Copy link

Change https://go.dev/cl/486977 mentions this issue: runtime: tidy _Stack* constant naming

@gopherbot
Copy link

Change https://go.dev/cl/486976 mentions this issue: runtime, cmd: rationalize StackLimit and StackGuard

gopherbot pushed a commit that referenced this issue Apr 21, 2023
For #59670.

Change-Id: I517e97ea74cf232e5cfbb77b127fa8804f74d84b
Reviewed-on: https://go-review.googlesource.com/c/go/+/485495
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
gopherbot pushed a commit that referenced this issue Apr 21, 2023
For #59670.

Change-Id: Ie784ba4dd2701e4f455e1abde4a6bfebee4b1387
Reviewed-on: https://go-review.googlesource.com/c/go/+/485496
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Auto-Submit: Austin Clements <austin@google.com>
gopherbot pushed a commit that referenced this issue Apr 21, 2023
… internal/abi

We also rename the constants related to unsafe-points: currently, they
follow the same naming scheme as the PCDATA table indexes, but are not
PCDATA table indexes.

For #59670.

Change-Id: I06529fecfae535be5fe7d9ac56c886b9106c74fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/485497
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
gopherbot pushed a commit that referenced this issue Apr 21, 2023
…ternal/abi

For #59670.

Change-Id: I91448363be2fc678964ce119d85cd5fae34a14da
Reviewed-on: https://go-review.googlesource.com/c/go/+/486975
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Auto-Submit: Austin Clements <austin@google.com>
gopherbot pushed a commit that referenced this issue Apr 21, 2023
The current definitions of StackLimit and StackGuard only indirectly
specify the NOSPLIT stack limit and duplicate a literal constant
(928). Currently, they define the stack guard delta, and from there
compute the NOSPLIT limit.

Rationalize these by defining a new constant, abi.StackNosplitBase,
which consolidates and directly specifies the NOSPLIT stack limit (in
the default case). From this we then compute the stack guard delta,
inverting the relationship between these two constants. While we're
here, we rename StackLimit to StackNosplit to make it clearer what's
being limited.

This change does not affect the values of these constants in the
default configuration. It does slightly change how
StackGuardMultiplier values other than 1 affect the constants, but
this multiplier is a pretty rough heuristic anyway.

                    before after
stackNosplit           800   800
_StackGuard            928   928
stackNosplit -race    1728  1600
_StackGuard -race     1856  1728

For #59670.

Change-Id: Ia94094c5e47897e7c088d24b4a5e33f5c2768db5
Reviewed-on: https://go-review.googlesource.com/c/go/+/486976
Auto-Submit: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Apr 21, 2023
For #59670.

Change-Id: I0efa743edc08e48dc8d906803ba45e9f641369db
Reviewed-on: https://go-review.googlesource.com/c/go/+/486977
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/494795 mentions this issue: internal/abi: update type name in comment

gopherbot pushed a commit that referenced this issue May 17, 2023
method -> Method

For #59670

Change-Id: I78e0410f3d5094aa12b2f3ccd6735fec0d696190
Reviewed-on: https://go-review.googlesource.com/c/go/+/494795
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
@aclements
Copy link
Member Author

This is much better than it was! Taking another pass through the common constants, I think these could still be merged:

_dotdotdot src/runtime/traceback.go:657:3
_dotdotdot src/cmd/compile/internal/ssagen/ssa.go:6767:3

_endAgg src/runtime/traceback.go:656:3
_endAgg src/cmd/compile/internal/ssagen/ssa.go:6766:3

_endSeq src/runtime/traceback.go:654:3
_endSeq src/cmd/compile/internal/ssagen/ssa.go:6764:3

_offsetTooLarge src/runtime/traceback.go:658:3
_offsetTooLarge src/cmd/compile/internal/ssagen/ssa.go:6768:3

_startAgg src/runtime/traceback.go:655:3
_startAgg src/cmd/compile/internal/ssagen/ssa.go:6765:3

boundsIndex src/runtime/error.go:127:2
BoundsIndex src/cmd/compile/internal/ssa/op.go:462:2

boundsSlice3Acap src/runtime/error.go:134:2
BoundsSliceAcapU src/cmd/compile/internal/ssa/op.go:467:2

boundsSlice3Alen src/runtime/error.go:133:2
BoundsSliceAcap src/cmd/compile/internal/ssa/op.go:466:2

boundsSlice3B src/runtime/error.go:135:2
BoundsSliceB src/cmd/compile/internal/ssa/op.go:468:2

boundsSlice3C src/runtime/error.go:136:2
BoundsSliceBU src/cmd/compile/internal/ssa/op.go:469:2

boundsSliceAcap src/runtime/error.go:130:2
BoundsSliceAlen src/cmd/compile/internal/ssa/op.go:464:2

bucketCnt src/runtime/map.go:67:2
bucketSize src/reflect/type.go:1953:2
BUCKETSIZE src/cmd/compile/internal/reflectdata/reflect.go:75:2
BucketSize src/cmd/link/internal/ld/dwarf.go:861:2

flagAddr src/internal/reflectlite/value.go:73:2
flagAddr src/reflect/value.go:79:2

flagEmbedRO src/internal/reflectlite/value.go:71:2
flagEmbedRO src/reflect/value.go:77:2

flagIndir src/internal/reflectlite/value.go:72:2
flagIndir src/reflect/value.go:78:2

flagKindWidth src/internal/reflectlite/value.go:68:2
flagKindWidth src/reflect/value.go:74:2

flagMethod src/internal/reflectlite/value.go:74:2
flagMethod src/reflect/value.go:80:2

flagMethodShift src/internal/reflectlite/value.go:75:2
flagMethodShift src/reflect/value.go:81:2

flagRO src/internal/reflectlite/value.go:76:2
flagRO src/reflect/value.go:82:2

flagStickyRO src/internal/reflectlite/value.go:70:2
flagStickyRO src/reflect/value.go:76:2

kindArray src/runtime/typekind.go:24:2
Array (PUBLIC) src/reflect/type.go:261:2
KindArray src/cmd/internal/objabi/typekind.go:27:2
kindArray src/cmd/link/internal/ld/decodesym.go:86:2

kindBool src/runtime/typekind.go:8:2
KindBool src/cmd/internal/objabi/typekind.go:11:2

kindChan src/runtime/typekind.go:25:2
KindChan src/cmd/internal/objabi/typekind.go:28:2
kindChan src/cmd/link/internal/ld/decodesym.go:87:2

kindComplex128 src/runtime/typekind.go:23:2
Complex128 (PUBLIC) src/reflect/type.go:260:2
KindComplex128 src/cmd/internal/objabi/typekind.go:26:2
Complex128 src/cmd/compile/internal/types2/basic.go:29:2

kindComplex64 src/runtime/typekind.go:22:2
Complex64 (PUBLIC) src/reflect/type.go:259:2
KindComplex64 src/cmd/internal/objabi/typekind.go:25:2
Complex64 src/cmd/compile/internal/types2/basic.go:28:2

kindDirectIface src/runtime/typekind.go:35:2
kindDirectIface src/reflect/type.go:435:2
KindDirectIface src/cmd/internal/objabi/typekind.go:37:2

kindFloat32 src/runtime/typekind.go:20:2
Float32 (PUBLIC) src/reflect/type.go:257:2
KindFloat32 src/cmd/internal/objabi/typekind.go:23:2
Float32 src/cmd/compile/internal/types2/basic.go:26:2

kindFloat64 src/runtime/typekind.go:21:2
Float64 (PUBLIC) src/reflect/type.go:258:2
KindFloat64 src/cmd/internal/objabi/typekind.go:24:2
Float64 src/cmd/compile/internal/types2/basic.go:27:2

kindFunc src/runtime/typekind.go:26:2
KindFunc src/cmd/internal/objabi/typekind.go:29:2
kindFunc src/cmd/link/internal/ld/decodesym.go:88:2

kindGCProg src/runtime/typekind.go:36:2
kindGCProg src/reflect/type.go:436:2
KindGCProg src/cmd/internal/objabi/typekind.go:38:2

kindInt src/runtime/typekind.go:9:2
KindInt src/cmd/internal/objabi/typekind.go:12:2

kindInt16 src/runtime/typekind.go:11:2
Int16 (PUBLIC) src/reflect/type.go:248:2
KindInt16 src/cmd/internal/objabi/typekind.go:14:2

kindInt32 src/runtime/typekind.go:12:2
Int32 (PUBLIC) src/reflect/type.go:249:2
KindInt32 src/cmd/internal/objabi/typekind.go:15:2

kindInt64 src/runtime/typekind.go:13:2
Int64 (PUBLIC) src/reflect/type.go:250:2
KindInt64 src/cmd/internal/objabi/typekind.go:16:2

kindInt8 src/runtime/typekind.go:10:2
KindInt8 src/cmd/internal/objabi/typekind.go:13:2

kindInterface src/runtime/typekind.go:27:2
Interface src/internal/reflectlite/type.go:84:2
Interface (PUBLIC) src/reflect/type.go:264:2
KindInterface src/cmd/internal/objabi/typekind.go:30:2
kindInterface src/cmd/link/internal/ld/decodesym.go:89:2

kindMap src/runtime/typekind.go:28:2
KindMap src/cmd/internal/objabi/typekind.go:31:2
kindMap src/cmd/link/internal/ld/decodesym.go:90:2

kindMask src/runtime/typekind.go:37:2
flagKindMask src/internal/reflectlite/value.go:69:2
kindMask src/reflect/type.go:437:2
flagKindMask src/reflect/value.go:75:2
KindMask src/cmd/internal/objabi/typekind.go:39:2
kindMask src/cmd/link/internal/ld/decodesym.go:94:2

kindPtr src/runtime/typekind.go:29:2
KindPtr src/cmd/internal/objabi/typekind.go:32:2
kindPtr src/cmd/link/internal/ld/decodesym.go:91:2

kindSlice src/runtime/typekind.go:30:2
Slice src/internal/reflectlite/type.go:85:2
Slice (PUBLIC) src/reflect/type.go:267:2
KindSlice src/cmd/internal/objabi/typekind.go:33:2
kindSlice src/cmd/link/internal/ld/decodesym.go:92:2

kindString src/runtime/typekind.go:31:2
String src/internal/reflectlite/type.go:86:2
String (PUBLIC) src/reflect/type.go:268:2
KindString src/cmd/internal/objabi/typekind.go:34:2

kindStruct src/runtime/typekind.go:32:2
Struct src/internal/reflectlite/type.go:87:2
Struct (PUBLIC) src/reflect/type.go:269:2
KindStruct src/cmd/internal/objabi/typekind.go:35:2
kindStruct src/cmd/link/internal/ld/decodesym.go:93:2

kindUint src/runtime/typekind.go:14:2
KindUint src/cmd/internal/objabi/typekind.go:17:2

kindUint16 src/runtime/typekind.go:16:2
Uint16 (PUBLIC) src/reflect/type.go:253:2
KindUint16 src/cmd/internal/objabi/typekind.go:19:2
Uint16 src/cmd/compile/internal/types2/basic.go:22:2

kindUint32 src/runtime/typekind.go:17:2
Uint32 (PUBLIC) src/reflect/type.go:254:2
KindUint32 src/cmd/internal/objabi/typekind.go:20:2
Uint32 src/cmd/compile/internal/types2/basic.go:23:2

kindUint64 src/runtime/typekind.go:18:2
Uint64 (PUBLIC) src/reflect/type.go:255:2
KindUint64 src/cmd/internal/objabi/typekind.go:21:2
Uint64 src/cmd/compile/internal/types2/basic.go:24:2

kindUint8 src/runtime/typekind.go:15:2
Uint8 (PUBLIC) src/reflect/type.go:252:2
KindUint8 src/cmd/internal/objabi/typekind.go:18:2
Uint8 src/cmd/compile/internal/types2/basic.go:21:2

kindUintptr src/runtime/typekind.go:19:2
Uintptr (PUBLIC) src/reflect/type.go:256:2
KindUintptr src/cmd/internal/objabi/typekind.go:22:2
Uintptr src/cmd/compile/internal/types2/basic.go:25:2

kindUnsafePointer src/runtime/typekind.go:33:2
UnsafePointer (PUBLIC) src/reflect/type.go:270:2
KindUnsafePointer src/cmd/internal/objabi/typekind.go:36:2

limit src/runtime/traceback.go:662:3
limit src/cmd/compile/internal/ssagen/ssa.go:6773:3

maxDepth src/runtime/traceback.go:663:3
maxDepth src/cmd/compile/internal/ssagen/ssa.go:6774:3

maxElemSize src/runtime/map.go:80:2
MAXELEMSIZE src/cmd/compile/internal/reflectdata/reflect.go:77:2

maxInt64 src/runtime/string.go:354:2
maxInt64 src/cmd/compile/internal/types2/sizes.go:199:9
maxInt64 src/cmd/compile/internal/noder/sizes.go:134:9

maxKeySize src/runtime/map.go:79:2
maxKeySize src/reflect/type.go:1954:2
MAXKEYSIZE src/cmd/compile/internal/reflectdata/reflect.go:76:2
MaxKeySize src/cmd/link/internal/ld/dwarf.go:859:2

maxLen src/runtime/traceback.go:664:3
maxLen src/cmd/compile/internal/ssagen/ssa.go:6781:3

maxPtrmaskBytes src/reflect/type.go:2617:7
maxPtrmaskBytes src/cmd/compile/internal/reflectdata/reflect.go:1550:7

maxValSize src/reflect/type.go:1955:2
MaxValSize src/cmd/link/internal/ld/dwarf.go:860:2

maxZero src/runtime/map.go:1439:7
maxZero src/reflect/value.go:3239:7

minfunc src/runtime/symtab.go:501:7
MINFUNC src/cmd/link/internal/ld/lib.go:276:2

pcbucketsize src/runtime/symtab.go:502:7
BUCKETSIZE src/cmd/link/internal/ld/pcln.go:805:2

selectDefault src/runtime/select.go:538:2
SelectDefault (PUBLIC) src/reflect/value.go:2987:2

selectRecv src/runtime/select.go:537:2
SelectRecv (PUBLIC) src/reflect/value.go:2986:2

selectSend src/runtime/select.go:536:2
SelectSend (PUBLIC) src/reflect/value.go:2985:2

@gopherbot
Copy link

Change https://go.dev/cl/543655 mentions this issue: internal/abi, runtime, reflect, cmd: merge maxZero const into internal/abi

qiulaidongfeng added a commit to qiulaidongfeng/go that referenced this issue Jan 6, 2024
gopherbot pushed a commit that referenced this issue Jan 22, 2024
For #59670

Change-Id: If2b05b1ba30b607b518577b0e11ba5a0b07999c5
GitHub-Last-Rev: a664aa1
GitHub-Pull-Request: #64906
Reviewed-on: https://go-review.googlesource.com/c/go/+/553276
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Jan 23, 2024
…ernal/abi

For #59670

Change-Id: I651e211650e69989c598ab16202105bc6e68d67e
GitHub-Last-Rev: fba087a
GitHub-Pull-Request: #64776
Reviewed-on: https://go-review.googlesource.com/c/go/+/550615
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit that referenced this issue Jan 23, 2024
…/abi

For #59670

Change-Id: Iec85ee7312bb566b3f1224424f7d27bf4e408b13
GitHub-Last-Rev: c620abf
GitHub-Pull-Request: #64905
Reviewed-on: https://go-review.googlesource.com/c/go/+/553295
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
qiulaidongfeng added a commit to qiulaidongfeng/go that referenced this issue Jan 24, 2024
gopherbot pushed a commit that referenced this issue Jan 26, 2024
…l/abi

For #59670

Change-Id: I63a6e2cfaf9eec03866ea61064164a059fc42bb2
GitHub-Last-Rev: a3aa46a
GitHub-Pull-Request: #64773
Reviewed-on: https://go-review.googlesource.com/c/go/+/550595
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
gopherbot pushed a commit that referenced this issue Jan 26, 2024
…al/abi

For #59670

Change-Id: I248bad2d2f9d05903b80022e52a795ff7a4fae93
GitHub-Last-Rev: df6a7bf
GitHub-Pull-Request: #64775
Reviewed-on: https://go-review.googlesource.com/c/go/+/550596
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
qiulaidongfeng added a commit to qiulaidongfeng/go that referenced this issue Jan 27, 2024
qiulaidongfeng added a commit to qiulaidongfeng/go that referenced this issue Jan 30, 2024
For golang#59670

Change-Id: I48a6fca4154591bef8df4364230295e826bd8730
@gopherbot
Copy link

Change https://go.dev/cl/559435 mentions this issue: runtime,reflect: merge select* const into internal/abi

qiulaidongfeng added a commit to qiulaidongfeng/go that referenced this issue Jan 30, 2024
For golang#59670

Change-Id: I53e100362325472fd16a986c49ad94bb2c77244f
@gopherbot
Copy link

Change https://go.dev/cl/559475 mentions this issue: runtime,cmd/link: merge pcbucketsize const into internal/abi

@qiulaidongfeng
Copy link
Member

@gopherbot
Copy link

Change https://go.dev/cl/562298 mentions this issue: all: use kind* of abi

qiulaidongfeng added a commit to qiulaidongfeng/go that referenced this issue Feb 13, 2024
qiulaidongfeng added a commit to qiulaidongfeng/go that referenced this issue Feb 16, 2024
For golang#59670

Change-Id: I53e100362325472fd16a986c49ad94bb2c77244f
gopherbot pushed a commit that referenced this issue Feb 16, 2024
For #59670

Change-Id: I6343bacd3126fe6381a2e73be10f61691792824d
GitHub-Last-Rev: bbab8d1
GitHub-Pull-Request: #65373
Reviewed-on: https://go-review.googlesource.com/c/go/+/559475
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
qiulaidongfeng added a commit to qiulaidongfeng/go that referenced this issue Feb 17, 2024
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
For golang#59670

Change-Id: If2b05b1ba30b607b518577b0e11ba5a0b07999c5
GitHub-Last-Rev: a664aa1
GitHub-Pull-Request: golang#64906
Reviewed-on: https://go-review.googlesource.com/c/go/+/553276
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
…ernal/abi

For golang#59670

Change-Id: I651e211650e69989c598ab16202105bc6e68d67e
GitHub-Last-Rev: fba087a
GitHub-Pull-Request: golang#64776
Reviewed-on: https://go-review.googlesource.com/c/go/+/550615
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
…/abi

For golang#59670

Change-Id: Iec85ee7312bb566b3f1224424f7d27bf4e408b13
GitHub-Last-Rev: c620abf
GitHub-Pull-Request: golang#64905
Reviewed-on: https://go-review.googlesource.com/c/go/+/553295
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
…l/abi

For golang#59670

Change-Id: I63a6e2cfaf9eec03866ea61064164a059fc42bb2
GitHub-Last-Rev: a3aa46a
GitHub-Pull-Request: golang#64773
Reviewed-on: https://go-review.googlesource.com/c/go/+/550595
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
…al/abi

For golang#59670

Change-Id: I248bad2d2f9d05903b80022e52a795ff7a4fae93
GitHub-Last-Rev: df6a7bf
GitHub-Pull-Request: golang#64775
Reviewed-on: https://go-review.googlesource.com/c/go/+/550596
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
For golang#59670

Change-Id: I6343bacd3126fe6381a2e73be10f61691792824d
GitHub-Last-Rev: bbab8d1
GitHub-Pull-Request: golang#65373
Reviewed-on: https://go-review.googlesource.com/c/go/+/559475
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
gopherbot pushed a commit that referenced this issue Feb 20, 2024
… into internal/abi

For #59670

Change-Id: I5c0a463f54208db215683f11e6454d0178edda3c
GitHub-Last-Rev: 6963f3c
GitHub-Pull-Request: #64904
Reviewed-on: https://go-review.googlesource.com/c/go/+/553275
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
gopherbot pushed a commit that referenced this issue Feb 27, 2024
…l/abi

For #59670

Change-Id: I9265e033bf3a84c3dc7b4a5d52c0df9672435f0d
GitHub-Last-Rev: 8e40990
GitHub-Pull-Request: #64774
Reviewed-on: https://go-review.googlesource.com/c/go/+/550117
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit that referenced this issue Apr 2, 2024
For #59670

Change-Id: Id66e102f13e529dd041b68ce869026a56f0a1b9b
GitHub-Last-Rev: 43aa937
GitHub-Pull-Request: #65564
Reviewed-on: https://go-review.googlesource.com/c/go/+/562298
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Austin Clements <austin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Development

No branches or pull requests

3 participants