Repository navigation
html/template: improper handling of empty HTML attributes #59722
Description
Activity
@gopherbot please open backport issues for this security fix
Backport issue(s) opened: #59815 (for 1.19), #59816 (for 1.20).
Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.
Change https://go.dev/cl/491357 mentions this issue:
[release-branch.go1.19] html/template: emit filterFailsafe for empty unquoted attr valueChange https://go.dev/cl/491358 mentions this issue:
[release-branch.go1.20] html/template: emit filterFailsafe for empty unquoted attr value- changed the title
[-]security: fix CVE-2023-29400[/-][+]html/template: improper santization of CSS values[/+]on May 2, 2023 - changed the title
[-]html/template: improper santization of CSS values[/-][+]html/template: improper handling of empty HTML attributes[/+]on May 2, 2023 Change https://go.dev/cl/491617 mentions this issue:
html/template: emit filterFailsafe for empty unquoted attr value- added a commit that references this issue
on Apr 29, 2024 - locked and limited conversation to collaborators
on May 1, 2024
Templates containing actions in unquoted HTML attributes (e.g. "attr={{.}}") executed with empty input could result in output that would have unexpected results when parsed due to HTML normalization rules. This may allow injection of arbitrary attributes into tags.
Thanks to Juho Nurminen of Mattermost for reporting this issue.
This is CVE-2023-29400 and Go issue https://go.dev/issue/59722.
/cc @golang/security and @golang/release