Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types, types2: extract package paths (use package names) for internal tests automatically #59736

Closed
griesemer opened this issue Apr 20, 2023 · 1 comment
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@griesemer
Copy link
Contributor

The internal test support functions require a path and a source string. Typically the path is not very helpful (such as "p.go" or ".") and almost always unhelpful when a test fails.

Instead, if the path is simply the package name of the source, the path doesn't need to be explicitly provided and error reports are more useful. This will simplify writing tests and improve test output, leading to increased development velocity.

Tracking issue.

@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 20, 2023
@griesemer griesemer added this to the Go1.21 milestone Apr 20, 2023
@griesemer griesemer self-assigned this Apr 20, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/486617 mentions this issue: go/types, types2: extract package name from test sources automatically

@golang golang locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants