Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: TestEmptyDwarfRanges and TestScopeRanges fail on ios-arm64-corellium #59939

Closed
bcmills opened this issue May 3, 2023 · 5 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-iOS GOOS=ios
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented May 3, 2023

https://storage.googleapis.com/go-build-log/d11befbe/ios-arm64-corellium_f53b1ad2.log (a TryBot on CL 491660):

--- FAIL: TestEmptyDwarfRanges (0.98s)
    scope_test.go:498: decoding dwarf section info at offset 0x0: too short
--- FAIL: TestScopeRanges (1.01s)
    scope_test.go:234: decoding dwarf section info at offset 0x0: too short
FAIL
FAIL	cmd/compile/internal/dwarfgen	1.038s
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 3, 2023
@bcmills bcmills added OS-iOS GOOS=ios compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed compiler/runtime Issues related to the Go compiler and/or runtime. labels May 3, 2023
@bcmills bcmills added this to the Backlog milestone May 3, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/491835 mentions this issue: cmd/compile/internal/dwarfgen: skip TestEmptyDwarfRanges and TestScopeRanges on platforms that require external linking

@cherrymui
Copy link
Member

On iOS we don't combine the DWARF info into the binary, as the kernel doesn't like such a binary (https://cs.opensource.google/go/go/+/master:src/cmd/link/internal/ld/lib.go;l=1389). So we cannot find the DWARF section from the binary. I think it is okay to skip the test on iOS.

@bcmills
Copy link
Contributor Author

bcmills commented May 3, 2023

@cherrymui, the code you linked seems to apply to all darwin platforms — would this also apply to GOOS=darwin if external linking is forced on?

@bcmills
Copy link
Contributor Author

bcmills commented May 3, 2023

Oh, I guess that's the machoPlatform == PLATFORM_MACOS part of the check. (Are all of the platforms that aren't PLATFORM_MACOS considered ios?)

@cherrymui
Copy link
Member

Yeah, machoPlatform == PLATFORM_MACOS limits it to macOS. There are also iOS simulator, tvOS, etc. I believe they all need to use GOOS=ios.

@golang golang locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-iOS GOOS=ios
Projects
None yet
Development

No branches or pull requests

3 participants