Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestSehUnwind failures #60053

Closed
gopherbot opened this issue May 8, 2023 · 8 comments
Closed

runtime: TestSehUnwind failures #60053

gopherbot opened this issue May 8, 2023 · 8 comments
Assignees
@qmuntal
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Go1.21

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "runtime" && test == "TestSehUnwind"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestSehUnwind (0.00s)
    runtime-seh_windows_test.go:132: wanted [runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3 runtime_test.TestSehUnwind], got [runtime_test.sehCallers runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3]

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 8, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSehUnwind"
2023-05-08 15:53 windows-amd64-longtest go@5cad8d41 runtime.TestSehUnwind (log) 
--- FAIL: TestSehUnwind (0.00s)
    runtime-seh_windows_test.go:132: wanted [runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3 runtime_test.TestSehUnwind], got [runtime_test.sehCallers runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3]

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 8, 2023
@qmuntal qmuntal self-assigned this May 8, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSehUnwind"
2023-05-11 13:45 windows-amd64-longtest go@3ee12d57 runtime.TestSehUnwind (log) 
--- FAIL: TestSehUnwind (0.00s)
    runtime-seh_windows_test.go:132: wanted [runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3 runtime_test.TestSehUnwind], got [runtime_test.sehCallers runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3]

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSehUnwind"
2023-05-11 23:47 windows-amd64-longtest go@7db6d8a2 runtime.TestSehUnwind (log) 
--- FAIL: TestSehUnwind (0.00s)
    runtime-seh_windows_test.go:132: wanted [runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3 runtime_test.TestSehUnwind], got [runtime_test.sehCallers runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3]

— watchflakes

@qmuntal
Copy link
Member

qmuntal commented May 12, 2023

I can reproduce this failure locally by running
go test -run TestSehUnwind -gcflags=runtime=-d=maymorestack=runtime.mayMoreStackMove ./runtime.

It's related to mayMoreStackMove, still don't know the culprit.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSehUnwind"
2023-05-17 14:46 windows-amd64-longtest go@b7e767b0 runtime.TestSehUnwind (log) 
--- FAIL: TestSehUnwind (0.00s)
    runtime-seh_windows_test.go:132: wanted [runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3 runtime_test.TestSehUnwind], got [runtime_test.sehCallers runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3]

— watchflakes

@mknyszek mknyszek added this to the Go1.21 milestone May 17, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/496140 mentions this issue: runtime: fix TestSehUnwind

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSehUnwind"
2023-05-19 17:41 windows-amd64-longtest go@dc4993e7 runtime.TestSehUnwind (log) 
--- FAIL: TestSehUnwind (0.00s)
    runtime-seh_windows_test.go:132: wanted [runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3 runtime_test.TestSehUnwind], got [runtime_test.sehCallers runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3]

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSehUnwind"
2023-05-20 21:53 windows-amd64-longtest go@b950cc8f runtime.TestSehUnwind (log) 
--- FAIL: TestSehUnwind (0.00s)
    runtime-seh_windows_test.go:132: wanted [runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3 runtime_test.TestSehUnwind], got [runtime_test.sehCallers runtime_test.sehCallers runtime_test.sehf4 runtime_test.sehf3]

— watchflakes

@github-project-automation github-project-automation bot moved this from Todo to Done in Go Compiler / Runtime May 22, 2023
@golang golang locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@qmuntal qmuntal

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
Test Flakes
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@mknyszek @qmuntal @gopherbot