cherrymui opened this issue
May 16, 2023
· 3 comments
Labels
Buildersx/build issues (builders, bots, dashboards)NeedsFixThe path to resolution is known, but the work has not been done.recurringIssues that should never be closed, but moved to the next milestone once fixed in the current one.
CL https://golang.org/cl/451292 adds a default profile of the compiler, so we can build the compiler with PGO. As the compiler's source code evolves, we may want to periodically update the profile.
cherrymui
added
recurring
Issues that should never be closed, but moved to the next milestone once fixed in the current one.
and removed
compiler/runtime
Issues related to the Go compiler and/or runtime.
labels
May 16, 2023
We discussed this in the release team meeting today. The plan is to add this as a relui step, to be performed as part of creating rc1. We can also run the step as a one-off if necessary (e.g., after any major compiler refactoring).
Ideally we can shrink the profile a little. Currently it's ~350K, which is just big enough to be a little annoying to update regularly in git.
cc @golang/release
aclements
changed the title
cmd/compile: periodically update compiler's PGO profile
cmd/compile: update compiler's PGO profile as part of rc1 relui flow
May 23, 2023
We should discuss whether to try to get it done for this cycle. On the one hand it's not very necessary, but on the other it might be best to strike while the iron is hot.
dmitshur
changed the title
cmd/compile: update compiler's PGO profile as part of rc1 relui flow
cmd/compile, x/build/cmd/relui: update compiler's PGO profile as part of rc1 relui flow
May 25, 2023
Buildersx/build issues (builders, bots, dashboards)NeedsFixThe path to resolution is known, but the work has not been done.recurringIssues that should never be closed, but moved to the next milestone once fixed in the current one.
5 participants
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
CL https://golang.org/cl/451292 adds a default profile of the compiler, so we can build the compiler with PGO. As the compiler's source code evolves, we may want to periodically update the profile.
cc @prattmic @aclements
The text was updated successfully, but these errors were encountered: