Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestRequestBodyLimit failures #60264

Open
gopherbot opened this issue May 17, 2023 · 2 comments
Open

net/http: TestRequestBodyLimit failures #60264

gopherbot opened this issue May 17, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestBodyLimit"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRequestBodyLimit (3.16s)
    --- FAIL: TestRequestBodyLimit/h1 (3.12s)
        main_test.go:161: Test appears to have leaked a Transport:
            internal/poll.runtime_Semacquire(0x4a63d320?)
            	/tmp/buildlet/go/src/runtime/sema.go:67 +0x25
            internal/poll.(*FD).Close(0xc000328200)
            	/tmp/buildlet/go/src/internal/poll/fd_unix.go:116 +0x65
            net.(*netFD).Close(0xc000328200)
            	/tmp/buildlet/go/src/net/fd_posix.go:37 +0x32
            net.(*conn).Close(0xc00004e058)
...
            testing.(*T).Run(0xc000300d00, {0x14c13ab?, 0x27?}, 0xc0003f2060)
            	/tmp/buildlet/go/src/testing/testing.go:1649 +0x3c8
            net/http_test.run[...](0xc000300d00, 0x15114f0, {0x0, 0x0, 0x1087ecf})
            	/tmp/buildlet/go/src/net/http/clientserver_test.go:82 +0x26f
            net/http_test.TestRequestBodyLimit(0x12ac9e0?)
            	/tmp/buildlet/go/src/net/http/serve_test.go:2982 +0x2b
            testing.tRunner(0xc000300d00, 0x1510138)
            	/tmp/buildlet/go/src/testing/testing.go:1595 +0xff
            created by testing.(*T).Run in goroutine 1
            	/tmp/buildlet/go/src/testing/testing.go:1648 +0x3ad

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 17, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestBodyLimit"
2023-05-16 19:46 darwin-amd64-longtest go@b3d1cce3 net/http.TestRequestBodyLimit (log)
--- FAIL: TestRequestBodyLimit (3.16s)
    --- FAIL: TestRequestBodyLimit/h1 (3.12s)
        main_test.go:161: Test appears to have leaked a Transport:
            internal/poll.runtime_Semacquire(0x4a63d320?)
            	/tmp/buildlet/go/src/runtime/sema.go:67 +0x25
            internal/poll.(*FD).Close(0xc000328200)
            	/tmp/buildlet/go/src/internal/poll/fd_unix.go:116 +0x65
            net.(*netFD).Close(0xc000328200)
            	/tmp/buildlet/go/src/net/fd_posix.go:37 +0x32
            net.(*conn).Close(0xc00004e058)
...
            testing.(*T).Run(0xc000300d00, {0x14c13ab?, 0x27?}, 0xc0003f2060)
            	/tmp/buildlet/go/src/testing/testing.go:1649 +0x3c8
            net/http_test.run[...](0xc000300d00, 0x15114f0, {0x0, 0x0, 0x1087ecf})
            	/tmp/buildlet/go/src/net/http/clientserver_test.go:82 +0x26f
            net/http_test.TestRequestBodyLimit(0x12ac9e0?)
            	/tmp/buildlet/go/src/net/http/serve_test.go:2982 +0x2b
            testing.tRunner(0xc000300d00, 0x1510138)
            	/tmp/buildlet/go/src/testing/testing.go:1595 +0xff
            created by testing.(*T).Run in goroutine 1
            	/tmp/buildlet/go/src/testing/testing.go:1648 +0x3ad

watchflakes

@bcmills
Copy link
Member

bcmills commented May 17, 2023

(attn @neild)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

2 participants