net/http: TestRequestBodyLimit failures due to leaked Transports

[gopherbot]

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestBodyLimit" && `Test appears to have leaked a Transport` && date < "2023-08-26"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRequestBodyLimit (3.16s)
    --- FAIL: TestRequestBodyLimit/h1 (3.12s)
        main_test.go:161: Test appears to have leaked a Transport:
            internal/poll.runtime_Semacquire(0x4a63d320?)
            	/tmp/buildlet/go/src/runtime/sema.go:67 +0x25
            internal/poll.(*FD).Close(0xc000328200)
            	/tmp/buildlet/go/src/internal/poll/fd_unix.go:116 +0x65
            net.(*netFD).Close(0xc000328200)
            	/tmp/buildlet/go/src/net/fd_posix.go:37 +0x32
            net.(*conn).Close(0xc00004e058)
...
            testing.(*T).Run(0xc000300d00, {0x14c13ab?, 0x27?}, 0xc0003f2060)
            	/tmp/buildlet/go/src/testing/testing.go:1649 +0x3c8
            net/http_test.run[...](0xc000300d00, 0x15114f0, {0x0, 0x0, 0x1087ecf})
            	/tmp/buildlet/go/src/net/http/clientserver_test.go:82 +0x26f
            net/http_test.TestRequestBodyLimit(0x12ac9e0?)
            	/tmp/buildlet/go/src/net/http/serve_test.go:2982 +0x2b
            testing.tRunner(0xc000300d00, 0x1510138)
            	/tmp/buildlet/go/src/testing/testing.go:1595 +0xff
            created by testing.(*T).Run in goroutine 1
            	/tmp/buildlet/go/src/testing/testing.go:1648 +0x3ad

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestBodyLimit"

2023-05-16 19:46 darwin-amd64-longtest go@b3d1cce3 net/http.TestRequestBodyLimit (log)

--- FAIL: TestRequestBodyLimit (3.16s)
    --- FAIL: TestRequestBodyLimit/h1 (3.12s)
        main_test.go:161: Test appears to have leaked a Transport:
            internal/poll.runtime_Semacquire(0x4a63d320?)
            	/tmp/buildlet/go/src/runtime/sema.go:67 +0x25
            internal/poll.(*FD).Close(0xc000328200)
            	/tmp/buildlet/go/src/internal/poll/fd_unix.go:116 +0x65
            net.(*netFD).Close(0xc000328200)
            	/tmp/buildlet/go/src/net/fd_posix.go:37 +0x32
            net.(*conn).Close(0xc00004e058)
...
            testing.(*T).Run(0xc000300d00, {0x14c13ab?, 0x27?}, 0xc0003f2060)
            	/tmp/buildlet/go/src/testing/testing.go:1649 +0x3c8
            net/http_test.run[...](0xc000300d00, 0x15114f0, {0x0, 0x0, 0x1087ecf})
            	/tmp/buildlet/go/src/net/http/clientserver_test.go:82 +0x26f
            net/http_test.TestRequestBodyLimit(0x12ac9e0?)
            	/tmp/buildlet/go/src/net/http/serve_test.go:2982 +0x2b
            testing.tRunner(0xc000300d00, 0x1510138)
            	/tmp/buildlet/go/src/testing/testing.go:1595 +0xff
            created by testing.(*T).Run in goroutine 1
            	/tmp/buildlet/go/src/testing/testing.go:1648 +0x3ad

— watchflakes

[bcmills]

(attn @neild)

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestBodyLimit"

2023-06-05 19:18 darwin-amd64-longtest go@5db1e99b net/http.TestRequestBodyLimit (log)

--- FAIL: TestRequestBodyLimit (14.19s)
    --- FAIL: TestRequestBodyLimit/h1 (3.10s)
        main_test.go:161: Test appears to have leaked a Transport:
            internal/poll.runtime_Semacquire(0x49b7be98?)
            	/tmp/buildlet/go/src/runtime/sema.go:67 +0x25
            internal/poll.(*FD).Close(0xc0001a8280)
            	/tmp/buildlet/go/src/internal/poll/fd_unix.go:113 +0x65
            net.(*netFD).Close(0xc0001a8280)
            	/tmp/buildlet/go/src/net/fd_posix.go:37 +0x32
            net.(*conn).Close(0xc0002ca058)
...
            testing.(*T).Run(0xc0001b44e0, {0x14cd8c9?, 0x27?}, 0xc00024c270)
            	/tmp/buildlet/go/src/testing/testing.go:1649 +0x3c8
            net/http_test.run[...](0xc0001b44e0, 0x151e210, {0x0, 0x0, 0x6afa30c6a0000000})
            	/tmp/buildlet/go/src/net/http/clientserver_test.go:82 +0x26f
            net/http_test.TestRequestBodyLimit(0x12b6620?)
            	/tmp/buildlet/go/src/net/http/serve_test.go:2982 +0x2b
            testing.tRunner(0xc0001b44e0, 0x151ce40)
            	/tmp/buildlet/go/src/testing/testing.go:1595 +0xff
            created by testing.(*T).Run in goroutine 1
            	/tmp/buildlet/go/src/testing/testing.go:1648 +0x3ad

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestBodyLimit"

2023-06-06 19:22 darwin-amd64-longtest go@e23273dd net/http.TestRequestBodyLimit (log)

--- FAIL: TestRequestBodyLimit (3.22s)
    --- FAIL: TestRequestBodyLimit/h1 (3.14s)
        main_test.go:161: Test appears to have leaked a Transport:
            internal/poll.runtime_Semacquire(0x49d1e048?)
            	/tmp/buildlet/go/src/runtime/sema.go:67 +0x25
            internal/poll.(*FD).Close(0xc000022480)
            	/tmp/buildlet/go/src/internal/poll/fd_unix.go:113 +0x65
            net.(*netFD).Close(0xc000022480)
            	/tmp/buildlet/go/src/net/fd_posix.go:37 +0x32
            net.(*conn).Close(0xc0000960a0)
...
            testing.(*T).Run(0xc0002569c0, {0x14cdd29?, 0x27?}, 0xc0001625d0)
            	/tmp/buildlet/go/src/testing/testing.go:1649 +0x3c8
            net/http_test.run[...](0xc0002569c0, 0x151e770, {0x0, 0x0, 0x108940f})
            	/tmp/buildlet/go/src/net/http/clientserver_test.go:82 +0x26f
            net/http_test.TestRequestBodyLimit(0x18?)
            	/tmp/buildlet/go/src/net/http/serve_test.go:2982 +0x2b
            testing.tRunner(0xc0002569c0, 0x151d3a0)
            	/tmp/buildlet/go/src/testing/testing.go:1595 +0xff
            created by testing.(*T).Run in goroutine 1
            	/tmp/buildlet/go/src/testing/testing.go:1648 +0x3ad

— watchflakes

[bcmills]

Given the timing of the failures in the report, this is looking like a Go 1.21 regression. Marking as release-blocker at least until we can determine whether it is new.

[eliben]

@neild PTAL

[gopherbot]

Change https://go.dev/cl/501309 mentions this issue: net/http: close response body in TestRequestBodyLimit