New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: test failures due to rename
permission errors on linux-amd64-wsl
#60266
Comments
(Extracted from #56194 (comment) and #55324 (comment).) @qmuntal, I'm surprised to see these errors in the WSL environment. I know that renaming is non-atomic (and often fails) on Windows via the Win32 APIs, but I would expect WSL to provide POSIX |
Found new dashboard test flakes for:
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@46847c63 x/tools/gopls/internal/regtest/misc.TestRenamePackage_NestedModule (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@46847c63 x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateBlankImport (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@46847c63 x/tools/gopls/internal/regtest/misc.TestRenamePackage_IntermediateTestVariant (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@8e8303e1 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@8e8303e1 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@8e8303e1 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Nesting (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@57e31898 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@57e31898 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@57e31898 x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateBlankImport (log)
|
One possible workaround would be to move the Windows+macOS version of robustio.Rename to a common function called renameRetry and have the Windows+macOS Rename delegate to it; and on Linux, delegate to it if the rename system call fails and |
Don't know how WSL is implemented, but I would expect
If this end up being a host issue, then using robustio won't help. Lets wait till |
Found new dashboard test flakes for:
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@dc0179bf x/tools/gopls/internal/regtest/misc.TestRenamePackageWithConflicts (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@dc0179bf x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@268d2f7c x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@949d0f4f x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@949d0f4f x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateImport (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@1b896bff x/tools/gopls/internal/regtest/misc.TestRenamePackageWithConflicts (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@1b896bff x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@1b896bff x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@e9f1bb96 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
|
(attn @golang/wsl; CC @findleyr @adonovan)
The text was updated successfully, but these errors were encountered: