Skip to content

runtime: TestSetNonblock failures #60273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue May 17, 2023 · 8 comments
Closed

runtime: TestSetNonblock failures #60273

gopherbot opened this issue May 17, 2023 · 8 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.21

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "runtime" && test == "TestSetNonblock"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestSetNonblock (0.00s)
    nbpipe_pipe_test.go:31: O_NONBLOCK not set in reader flags 0x4000c8

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 17, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSetNonblock"
2023-05-17 18:18 darwin-amd64-10_15 go@93477f07 runtime.TestSetNonblock (log) 
--- FAIL: TestSetNonblock (0.00s)
    nbpipe_pipe_test.go:31: O_NONBLOCK not set in reader flags 0x4000c8

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 17, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSetNonblock"
2023-05-17 22:11 darwin-amd64-10_15 go@0b86a04d runtime.TestSetNonblock (log) 
--- FAIL: TestSetNonblock (0.00s)
    nbpipe_pipe_test.go:31: O_NONBLOCK not set in reader flags 0x4000c8

— watchflakes

@tklauser
Copy link
Member

I can reproduce this reliably on darwin/amd64 with macOS 12.6. I think this is because of the fcntl changes in https://go.dev/cl/495075. I'm going to send a fix.

/cc @ianlancetaylor

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/496139 mentions this issue: runtime: don't consider positive fcntl return value an error on darwin/amd64

@bcmills
Copy link
Contributor

bcmills commented May 18, 2023

This is a regression in Go 1.21 that can cause spurious errors within the runtime package, so marking as release-blocker.

@bcmills bcmills added this to the Go1.21 milestone May 18, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSetNonblock"
2023-05-19 20:19 darwin-amd64-10_15 go@656a20a5 runtime.TestSetNonblock (log) 
--- FAIL: TestSetNonblock (0.00s)
    nbpipe_pipe_test.go:31: O_NONBLOCK not set in reader flags 0x4000c8

— watchflakes

@ianlancetaylor
Copy link
Contributor

Should be fixed now.

@ianlancetaylor ianlancetaylor closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestSetNonblock"
2023-05-17 14:43 darwin-amd64-nocgo go@c890d40d runtime.TestSetNonblock (log) 
--- FAIL: TestSetNonblock (0.00s)
    nbpipe_pipe_test.go:31: O_NONBLOCK not set in reader flags 0x4000c8

— watchflakes

@golang golang locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
Test Flakes
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
4 participants
@tklauser @ianlancetaylor @bcmills @gopherbot