Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: retracted tags still show up as latest for flashbots/mev-boost-relay #60336

Closed
metachris opened this issue May 22, 2023 · 5 comments
Closed

x/pkgsite: retracted tags still show up as latest for flashbots/mev-boost-relay #60336

metachris opened this issue May 22, 2023 · 5 comments
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@metachris
Copy link

The repository https://github.com/flashbots/mev-boost-relay retracted the latest 5 tags and we published a new version v0.24.0

But the retracted tags still show up as "latest" on https://pkg.go.dev/github.com/flashbots/mev-boost-relay

Shouldn't v0.24.0 be used as latest tag now?
@gopherbot gopherbot added this to the Unreleased milestone May 22, 2023
@metachris metachris changed the title x/pkgsite: retracted tags still show up as latest x/pkgsite: retracted tags still show up as latest for flashbots/mev-boost-relay May 22, 2023
@metachris metachris changed the title x/pkgsite: retracted tags still show up as latest for flashbots/mev-boost-relay x/pkgsite: retracted tags still show up as latest for flashbots/mev-boost-relay May 22, 2023
@bcmills
Copy link
Contributor

bcmills commented May 22, 2023

Retractions are loaded from the latest tagged version of the module (necessarily ignoring retractions).

In order to retract v1.15.2, you will need to tag a higher version (v1.15.3?) and fetch that tag through the module proxy.

(Presumably you will also want v1.15.3 to retract itself, so don't forget to add it to the retract list.)

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 22, 2023
@metachris
Copy link
Author

Oh I see! Will try this. Would pkg.go.dev then fall back to using v0.24.0 as latest?

@bcmills
Copy link
Contributor

bcmills commented May 22, 2023

I would expect so, yes.

@metachris
Copy link
Author

works, thanks!

notrepo05 added a commit to pivotal-cf/kiln that referenced this issue Jun 7, 2023
@notrepo05 @pabloarodas
dev ops: retract major versions
66d1868 
 - versions can only retract lower or equal versions. so we're
   going to push a v1.0.1 tag that retracts itself and v1.0.0

   see golang/go#60336

Co-authored-by: Nick Rohn <nrohn@vmware.com>
Co-authored-by: Pablo Rodas <prodas@vmware.com>
@notrepo05 notrepo05 mentioned this issue Jun 7, 2023
Merged
notrepo05 added a commit to pivotal-cf/kiln that referenced this issue Jun 7, 2023
@notrepo05 @pabloarodas
dev ops: retract major versions
104b38d 
 - versions can only retract lower or equal versions. so we're
   going to push a v1.0.1 tag that retracts itself and v1.0.0

   see golang/go#60336

Co-authored-by: Nick Rohn <nrohn@vmware.com>
Co-authored-by: Pablo Rodas <prodas@vmware.com>
@notrepo05
Copy link

Thanks @metachris

@golang golang locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@metachris @notrepo05 @bcmills @gopherbot