Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: apparent livelock in TestScript/install_cmd_gobin via setPGOProfilePath #60428

Closed
bcmills opened this issue May 25, 2023 · 23 comments
Closed

cmd/go: apparent livelock in TestScript/install_cmd_gobin via setPGOProfilePath #60428

bcmills opened this issue May 25, 2023 · 23 comments
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.21

Comments

@bcmills
Copy link
Member

bcmills commented May 25, 2023 •
edited 

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. GoCommand cmd/go release-blocker labels May 25, 2023
@bcmills bcmills added this to the Go1.21 milestone May 25, 2023
@bcmills
Copy link
Member Author

bcmills commented May 25, 2023

(CC @cherrymui @prattmic @matloob)

@bcmills bcmills mentioned this issue May 25, 2023
Open
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-23 18:36 darwin-amd64-race go@db83768f cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54073
https://vcs-test.golang.org rerouted to https://127.0.0.1:54074
go test proxy running at GOPROXY=http://127.0.0.1:54075/mod
--- FAIL: TestScript (1.32s)
    --- FAIL: TestScript/install_cmd_gobin (88.42s)
        script_test.go:134: 2023-05-23T19:22:47Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3365219634/tmpdir3900810638/install_cmd_gobin830696299
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (0.829s)
...
            r12    0x16
            r13    0x0
            r14    0x160100001700
            r15    0x1600
            rip    0x7ff81d0a43ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-23 21:46 darwin-amd64-race go@26f25692 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54107
https://vcs-test.golang.org rerouted to https://127.0.0.1:54108
go test proxy running at GOPROXY=http://127.0.0.1:54109/mod
--- FAIL: TestScript (1.37s)
    --- FAIL: TestScript/install_cmd_gobin (127.74s)
        script_test.go:134: 2023-05-23T22:48:36Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-656456106/tmpdir1033576980/install_cmd_gobin2859759841
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.621s)
...
            r12    0x16
            r13    0x0
            r14    0x340100003500
            r15    0x3400
            rip    0x7ff80ebed3ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-24 01:03 darwin-amd64-race go@bdc5533f cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54450
https://vcs-test.golang.org rerouted to https://127.0.0.1:54451
go test proxy running at GOPROXY=http://127.0.0.1:54452/mod
--- FAIL: TestScript (1.31s)
    --- FAIL: TestScript/install_cmd_gobin (129.97s)
        script_test.go:134: 2023-05-24T13:40:54Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-2252801935/tmpdir3931416096/install_cmd_gobin1463591760
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.779s)
...
            r12    0x16
            r13    0x0
            r14    0x210100002200
            r15    0x2100
            rip    0x7ff818d493ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-24 14:13 darwin-amd64-race go@227e7126 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54835
https://vcs-test.golang.org rerouted to https://127.0.0.1:54836
go test proxy running at GOPROXY=http://127.0.0.1:54837/mod
--- FAIL: TestScript (1.40s)
    --- FAIL: TestScript/install_cmd_gobin (136.53s)
        script_test.go:134: 2023-05-24T15:17:48Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3701757274/tmpdir383451206/install_cmd_gobin952385878
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.969s)
...
            r12    0x16
            r13    0x0
            r14    0x260100002700
            r15    0x2600
            rip    0x7ff8065653ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-24 16:23 darwin-amd64-race go@0adcc5ac cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54668
https://vcs-test.golang.org rerouted to https://127.0.0.1:54669
go test proxy running at GOPROXY=http://127.0.0.1:54670/mod
--- FAIL: TestScript (1.33s)
    --- FAIL: TestScript/install_cmd_gobin (292.19s)
        script_test.go:134: 2023-05-24T17:08:46Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-2855942853/tmpdir3622800469/install_cmd_gobin2166615547
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.444s)
...
    --- FAIL: TestScript/build_cache_disabled (5.51s)
        script_test.go:134: 2023-05-24T17:13:32Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-2855942853/tmpdir3622800469/build_cache_disabled4046413907
        script_test.go:154: 
            # The build cache is required to build anything. It also may be needed to
            # initialize the build system, which is needed for commands like 'go env'.
            # However, there are lots of commands the cache is not needed for, and we
            # shouldn't require it when it won't be used.
            #
            # TODO(golang.org/issue/39882): commands below should work, too.
...
            r12    0x16
            r13    0x0
            r14    0x300100003100
            r15    0x2900
            rip    0x7ff80bfb43ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: build_GOTMPDIR.txt:9: go build -x hello.go: exit status 2
2023-05-24 17:35 darwin-amd64-race go@bfdd3bf3 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54731
https://vcs-test.golang.org rerouted to https://127.0.0.1:54732
go test proxy running at GOPROXY=http://127.0.0.1:54733/mod
--- FAIL: TestScript (1.46s)
    --- FAIL: TestScript/std_vendor (6.82s)
        script_test.go:134: 2023-05-24T18:25:45Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3477820836/tmpdir369273225/std_vendor1113160434
        script_test.go:154: 
            > env GO111MODULE=off
            > [!compiler:gc] skip
...
    --- FAIL: TestScript/mod_tidy_downgrade_ambiguous (0.29s)
        script_test.go:134: 2023-05-24T18:25:52Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3477820836/tmpdir369273225/mod_tidy_downgrade_ambiguous2267180424
        script_test.go:154: 
        script_test.go:154: FAIL: mod_tidy_downgrade_ambiguous.txt:0: context deadline exceeded
    --- FAIL: TestScript/mod_bad_domain (1.22s)
        script_test.go:134: 2023-05-24T18:25:51Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3477820836/tmpdir369273225/mod_bad_domain516355299
        script_test.go:154: 
            > env GO111MODULE=on
...
    --- FAIL: TestScript/mod_vendor (1.25s)
        script_test.go:134: 2023-05-24T18:25:54Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3477820836/tmpdir369273225/mod_vendor2845891677
        script_test.go:154: 
        script_test.go:154: FAIL: mod_vendor.txt:0: context deadline exceeded
    --- FAIL: TestScript/build_overlay (0.75s)
        script_test.go:134: 2023-05-24T18:25:54Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3477820836/tmpdir369273225/build_overlay1913783566
        script_test.go:154: 
        script_test.go:154: FAIL: build_overlay.txt:0: context deadline exceeded
2023-05-24 20:26 darwin-amd64-race go@a7cb7df4 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:53908
https://vcs-test.golang.org rerouted to https://127.0.0.1:53909
go test proxy running at GOPROXY=http://127.0.0.1:53910/mod
--- FAIL: TestScript (1.38s)
    --- FAIL: TestScript/install_cmd_gobin (294.43s)
        script_test.go:134: 2023-05-24T21:30:25Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-2215793321/tmpdir2452437996/install_cmd_gobin1117947173
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.567s)
...
    --- FAIL: TestScript/version_buildvcs_nested (0.06s)
        script_test.go:134: 2023-05-24T21:35:19Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-2215793321/tmpdir2452437996/version_buildvcs_nested2043057666
        script_test.go:154: 
        script_test.go:154: FAIL: version_buildvcs_nested.txt:0: context deadline exceeded
    --- FAIL: TestScript/test_match_only_subtests_parallel (15.92s)
        script_test.go:134: 2023-05-24T21:35:03Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-2215793321/tmpdir2452437996/test_match_only_subtests_parallel2325072796
        script_test.go:154: 
            # Matches only subtests, parallel (15.735s)
...
            r12    0xc0001bb6d8
            r13    0x21a1f40
            r14    0xc0000081a0
            r15    0x1f
            rip    0x7ff80bfffeda
            rflags 0x246
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: build_GOTMPDIR.txt:9: go build -x hello.go: exit status 2
2023-05-24 20:58 darwin-amd64-race go@9b57b335 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54556
https://vcs-test.golang.org rerouted to https://127.0.0.1:54557
go test proxy running at GOPROXY=http://127.0.0.1:54558/mod
--- FAIL: TestScript (1.26s)
    --- FAIL: TestScript/mod_tidy_convergence_loop (8.34s)
        script_test.go:134: 2023-05-24T21:46:14Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-4214878877/tmpdir672237590/mod_tidy_convergence_loop1419118342
        script_test.go:154: 
            # This test demonstrates a simple case in which 'go mod tidy' may resolve a
            # missing package, only to remove that package when resolving its dependencies.
...
    --- FAIL: TestScript/install_cmd_gobin (315.57s)
        script_test.go:134: 2023-05-24T21:41:07Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-4214878877/tmpdir672237590/install_cmd_gobin4252469576
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.507s)
            # Check that tools are installed to $GOTOOLDIR, not $GOBIN. (314.023s)
            > go list -f '{{.Target}}' cmd/compile
            [stderr]
            SIGQUIT: quit
...
            r12    0x16
            r13    0x0
            r14    0x240100002500
            r15    0x2400
            rip    0x7ff80baba3ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-24 23:23 linux-s390x-ibm-race go@08458804 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:42201
https://vcs-test.golang.org rerouted to https://127.0.0.1:41649
go test proxy running at GOPROXY=http://127.0.0.1:33027/mod
--- FAIL: TestScript (1.20s)
    --- FAIL: TestScript/install_cmd_gobin (749.08s)
        script_test.go:134: 2023-05-25T00:24:23Z
        script_test.go:136: $WORK=/data/golang/workdir/tmp/cmd-go-test-1506702209/tmpdir935125935/install_cmd_gobin2334811832
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (3.344s)
            # Check that tools are installed to $GOTOOLDIR, not $GOBIN. (745.735s)
            > go list -f '{{.Target}}' cmd/compile
            [stderr]
            SIGQUIT: quit
            PC=0x10a33c8 m=0 sigcode=0

            r0   0x0	r1   0xee
            r2   0x23158e8	r3   0x80
            r4   0x0	r5   0x0
            r6   0x0	r7   0x0
            r8   0x7	r9   0x0
            r10  0x0	r11  0x80
            r12  0x1	r13  0x2314b60
            r14  0x1058792	r15  0x3fff7bfe950
            pc   0x10a33c8	link 0x1058792
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-24 23:56 darwin-amd64-race go@6b020be6 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54008
https://vcs-test.golang.org rerouted to https://127.0.0.1:54009
go test proxy running at GOPROXY=http://127.0.0.1:54010/mod
--- FAIL: TestScript (1.35s)
    --- FAIL: TestScript/install_cmd_gobin (124.82s)
        script_test.go:134: 2023-05-25T09:36:44Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-992791127/tmpdir2479475108/install_cmd_gobin1895728745
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.414s)
...
            r12    0x16
            r13    0x0
            r14    0x1f0100002000
            r15    0x1f00
            rip    0x7ff81bf953ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-24 23:56 darwin-amd64-race go@371ebe73 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:55392
https://vcs-test.golang.org rerouted to https://127.0.0.1:55393
go test proxy running at GOPROXY=http://127.0.0.1:55394/mod
--- FAIL: TestScript (1.26s)
    --- FAIL: TestScript/install_cmd_gobin (202.07s)
        script_test.go:134: 2023-05-25T08:12:06Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3179816628/tmpdir3316481185/install_cmd_gobin3927153130
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.497s)
...
            r12    0xc000140e88
            r13    0x21b1100
            r14    0xc0000081a0
            r15    0x5
            rip    0x10c794e
            rflags 0x202
            cs     0x2b
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-24 23:56 darwin-amd64-race go@6824765b cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54146
https://vcs-test.golang.org rerouted to https://127.0.0.1:54147
go test proxy running at GOPROXY=http://127.0.0.1:54148/mod
--- FAIL: TestScript (1.39s)
    --- FAIL: TestScript/install_cmd_gobin (147.99s)
        script_test.go:134: 2023-05-25T07:52:08Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3252776576/tmpdir820373639/install_cmd_gobin2132348927
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.552s)
...
            r12    0x16
            r13    0x0
            r14    0x170100001800
            r15    0x1700
            rip    0x7ff81f9f83ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-25 00:04 darwin-amd64-race go@04c62893 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:53977
https://vcs-test.golang.org rerouted to https://127.0.0.1:53978
go test proxy running at GOPROXY=http://127.0.0.1:53979/mod
--- FAIL: TestScript (1.49s)
    --- FAIL: TestScript/install_cmd_gobin (136.69s)
        script_test.go:134: 2023-05-25T00:50:06Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-151728066/tmpdir300127239/install_cmd_gobin2289763841
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.454s)
...
            r12    0x16
            r13    0x0
            r14    0x20100000300
            r15    0x200
            rip    0x7ff810c1b3ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-25 00:13 darwin-amd64-race go@b267db08 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54154
https://vcs-test.golang.org rerouted to https://127.0.0.1:54155
go test proxy running at GOPROXY=http://127.0.0.1:54156/mod
--- FAIL: TestScript (1.29s)
    --- FAIL: TestScript/install_cmd_gobin (145.26s)
        script_test.go:134: 2023-05-25T05:36:59Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-181925657/tmpdir2791064128/install_cmd_gobin3513855899
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.230s)
...
            r12    0x16
            r13    0x0
            r14    0x120100001300
            r15    0x1200
            rip    0x7ff8156eb3ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-25 00:14 darwin-amd64-race go@d4bd855c cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54294
https://vcs-test.golang.org rerouted to https://127.0.0.1:54295
go test proxy running at GOPROXY=http://127.0.0.1:54296/mod
--- FAIL: TestScript (1.41s)
    --- FAIL: TestScript/prevent_sys_unix_import (2.43s)
        script_test.go:134: 2023-05-25T01:29:29Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-603332044/tmpdir3517492091/prevent_sys_unix_import190775261
        script_test.go:154: 
            # Policy decision: we shouldn't vendor golang.org/x/sys/unix in std
            # See https://golang.org/issue/32102 (2.340s)
...
    --- FAIL: TestScript/install_cmd_gobin (338.50s)
        script_test.go:134: 2023-05-25T01:23:53Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-603332044/tmpdir3517492091/install_cmd_gobin4117662701
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (2.115s)
            # Check that tools are installed to $GOTOOLDIR, not $GOBIN. (336.236s)
            > go list -f '{{.Target}}' cmd/compile
            [stderr]
            SIGQUIT: quit
...
    --- FAIL: TestScript/mod_list_update_nolatest (0.58s)
        script_test.go:134: 2023-05-25T01:29:35Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-603332044/tmpdir3517492091/mod_list_update_nolatest1818451856
        script_test.go:154: 
        script_test.go:154: FAIL: mod_list_update_nolatest.txt:0: context deadline exceeded
    --- FAIL: TestScript/mod_tidy_convergence_loop (0.44s)
        script_test.go:134: 2023-05-25T01:29:36Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-603332044/tmpdir3517492091/mod_tidy_convergence_loop3524938675
        script_test.go:154: 
        script_test.go:154: FAIL: mod_tidy_convergence_loop.txt:0: context deadline exceeded

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-24 22:37 darwin-amd64-race go@7d96475d cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54781
https://vcs-test.golang.org rerouted to https://127.0.0.1:54782
go test proxy running at GOPROXY=http://127.0.0.1:54783/mod
--- FAIL: TestScript (1.31s)
    --- FAIL: TestScript/autocgo (2.27s)
        script_test.go:134: 2023-05-26T11:41:29Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3412735443/tmpdir1475125216/autocgo1577812008
        script_test.go:154: 
            # Test automatic setting of CGO_ENABLED based on $CC and what's in $PATH. (0.000s)
            # Assume we're on a system that can enable cgo normally. (1.143s)
...
    --- FAIL: TestScript/install_cmd_gobin (332.84s)
        script_test.go:134: 2023-05-26T11:35:58Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3412735443/tmpdir1475125216/install_cmd_gobin3445978679
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.448s)
            # Check that tools are installed to $GOTOOLDIR, not $GOBIN. (331.260s)
            > go list -f '{{.Target}}' cmd/compile
            [stderr]
            SIGQUIT: quit
...
            r12    0x1
            r13    0x11672e0
            r14    0xc0000081a0
            r15    0x4
            rip    0x7ff8050fbe1c
            rflags 0x246
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: build_cd_gopath_different.txt:6: exec ./run_go /tmp/buildlet/tmp/cmd-go-test-3412735443/tmpdir1475125216/build_cd_gopath_different3011591364/gopath/src/my.pkg/main /tmp/buildlet/tmp/cmd-go-test-3412735443/tmpdir1475125216/build_cd_gopath_different3011591364/gopath IDENTITY build -o /tmp/buildlet/tmp/cmd-go-test-3412735443/tmpdir1475125216/build_cd_gopath_different3011591364/tmp/a.exe -ldflags -X=my.pkg.Text=linkXworked: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-24 22:27 darwin-amd64-race go@1ddab592 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54617
https://vcs-test.golang.org rerouted to https://127.0.0.1:54618
go test proxy running at GOPROXY=http://127.0.0.1:54619/mod
--- FAIL: TestScript (1.35s)
    --- FAIL: TestScript/install_cmd_gobin (134.92s)
        script_test.go:134: 2023-05-26T12:04:00Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-1014744865/tmpdir3414433187/install_cmd_gobin2545617787
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.372s)
...
            r12    0x16
            r13    0x0
            r14    0x190100001a00
            r15    0x1900
            rip    0x7ff81e0403ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-24 22:24 darwin-amd64-race go@15a4e0d9 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:53049
https://vcs-test.golang.org rerouted to https://127.0.0.1:53050
go test proxy running at GOPROXY=http://127.0.0.1:53051/mod
--- FAIL: TestScript (1.35s)
    --- FAIL: TestScript/install_cmd_gobin (177.91s)
        script_test.go:134: 2023-05-26T12:17:36Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-228421012/tmpdir3556378722/install_cmd_gobin2327268921
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.739s)
...
            r12    0x16
            r13    0x0
            r14    0x2b0100002c00
            r15    0x2b00
            rip    0x7ff80e2c23ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2

— watchflakes

@prattmic
Copy link
Member

Odd. I happened to notice one of these on the dashboard the other day, but didn't realize that setPGOProfilePath was a pattern. I'll take a look.

@prattmic
Copy link
Member

prattmic commented May 26, 2023 •
edited

It's not trivially reproducible on a gomote. I'll leave it going for a while and see if it makes progress. FWIW, this test takes ~150s to pass in race mode, pretty close to the timeout.

Edit: it’s possible that this runtime is itself indicative of the problem. I haven’t checked where the time is going or if it recently increased. The test takes ~15s in non-race mode.

@bcmills
Copy link
Member Author

bcmills commented May 26, 2023

I would expect the test to take quite a bit longer now that cmd/compile is built with a PGO profile.

However, most of that time should be spent in rebuilding the imported packages, not in load.PackagesAndErrors. 🤔

@bcmills
Copy link
Member Author

bcmills commented May 26, 2023

I suspect that something is going wrong with the split recursion:
https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/load/pkg.go;l=2978-2982;drc=227e7126857df9f73863fc60090976b98fa9dd4e

Perhaps we're somehow ending up with O(N²) splits instead of O(N), or something like that?

@bcmills bcmills mentioned this issue May 26, 2023
Closed
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-24 21:48 darwin-amd64-race go@05cc9e55 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54682
https://vcs-test.golang.org rerouted to https://127.0.0.1:54683
go test proxy running at GOPROXY=http://127.0.0.1:54684/mod
--- FAIL: TestScript (1.44s)
    --- FAIL: TestScript/mod_all (25.51s)
        script_test.go:134: 2023-05-26T14:17:05Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-738889591/tmpdir1408696733/mod_all2888371318
        script_test.go:154: 
            # This test illustrates the relationship between the 'all' pattern and
            # the dependencies of the main module.
...
    --- FAIL: TestScript/install_cmd_gobin (145.55s)
        script_test.go:134: 2023-05-26T14:15:05Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-738889591/tmpdir1408696733/install_cmd_gobin73950562
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.581s)
            # Check that tools are installed to $GOTOOLDIR, not $GOBIN. (143.960s)
            > go list -f '{{.Target}}' cmd/compile
            [stderr]
            SIGQUIT: quit
...
            r12    0x16
            r13    0x0
            r14    0x150100001600
            r15    0x1500
            rip    0x7ff8149373ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-26 03:21 darwin-amd64-race go@f90b4cd6 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54423
https://vcs-test.golang.org rerouted to https://127.0.0.1:54424
go test proxy running at GOPROXY=http://127.0.0.1:54425/mod
--- FAIL: TestScript (1.32s)
    --- FAIL: TestScript/install_cmd_gobin (167.00s)
        script_test.go:134: 2023-05-26T04:16:19Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3979188139/tmpdir1008178390/install_cmd_gobin1785419065
        script_test.go:158: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.346s)
...
            r12    0x16
            r13    0x0
            r14    0x1b0100001c00
            r15    0x1b00
            rip    0x7ff8055d63ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:158: FAIL: testdata/script/install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-26 13:43 darwin-amd64-race go@f89d575d cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54109
https://vcs-test.golang.org rerouted to https://127.0.0.1:54110
go test proxy running at GOPROXY=http://127.0.0.1:54111/mod
--- FAIL: TestScript (1.29s)
    --- FAIL: TestScript/mod_invalid_path_plus (4.99s)
        script_test.go:134: 2023-05-26T15:07:56Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-1935871773/tmpdir2183697108/mod_invalid_path_plus2412670347
        script_test.go:158: 
            # https://golang.org/issue/44776
            # The '+' character should be disallowed in module paths, but allowed in package
...
    --- FAIL: TestScript/test_chatty_parallel_success_run (2.99s)
        script_test.go:134: 2023-05-26T15:07:58Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-1935871773/tmpdir2183697108/test_chatty_parallel_success_run938483472
        script_test.go:158: 
            # Run parallel chatty tests. Assert on CONT or NAME lines. This test makes sure that
            # multiple parallel outputs have the appropriate CONT lines between them. (2.928s)
            > go test -parallel 3 chatty_parallel -v
            [stdout]
            === RUN   TestInterruptor
            === PAUSE TestInterruptor
...
            r12    0x16
            r13    0x0
            r14    0x320100003300
            r15    0x3100
            rip    0x7ff81f3943ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:158: FAIL: testdata/script/build_GOTMPDIR.txt:9: go build -x hello.go: exit status 2

— watchflakes

@prattmic
Copy link
Member

The fix for #60455 reduces the (non-race) run time of this test from ~7s to ~0.2s, so I am assume it is the same root cause.

@gopherbot
Copy link

Change https://go.dev/cl/498735 mentions this issue: cmd/go: always track visited packages in setPGOProfilePath

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-26 23:31 darwin-amd64-race go@c2bb350d cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54304
https://vcs-test.golang.org rerouted to https://127.0.0.1:54305
go test proxy running at GOPROXY=http://127.0.0.1:54306/mod
--- FAIL: TestScript (1.47s)
    --- FAIL: TestScript/mod_tagged_import_cycle (1.41s)
        script_test.go:134: 2023-05-27T00:22:56Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-1133565943/tmpdir1074259705/mod_tagged_import_cycle4057736281
        script_test.go:158: 
            # Because 'go mod' subcommands ignore build constraints, they can encounter
            # package-import cycles that are not possible in an ordinary build. This test
...
    --- FAIL: TestScript/install_cmd_gobin (276.76s)
        script_test.go:134: 2023-05-27T00:18:21Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-1133565943/tmpdir1074259705/install_cmd_gobin1845131694
        script_test.go:158: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.439s)
            # Check that tools are installed to $GOTOOLDIR, not $GOBIN. (275.266s)
            > go list -f '{{.Target}}' cmd/compile
            [stderr]
            SIGQUIT: quit
...
    --- FAIL: TestScript/mod_tidy_downgrade_ambiguous (0.02s)
        script_test.go:134: 2023-05-27T00:23:00Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-1133565943/tmpdir1074259705/mod_tidy_downgrade_ambiguous306671598
        script_test.go:158: 
        script_test.go:158: FAIL: testdata/script/mod_tidy_downgrade_ambiguous.txt:0: context deadline exceeded
    --- FAIL: TestScript/test_fuzz_fuzztime (0.04s)
        script_test.go:134: 2023-05-27T00:23:00Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-1133565943/tmpdir1074259705/test_fuzz_fuzztime2129241170
        script_test.go:158: 
        script_test.go:158: FAIL: testdata/script/test_fuzz_fuzztime.txt:0: context deadline exceeded

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-26 16:19 darwin-amd64-race go@76bb0caa cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54413
https://vcs-test.golang.org rerouted to https://127.0.0.1:54414
go test proxy running at GOPROXY=http://127.0.0.1:54415/mod
--- FAIL: TestScript (1.34s)
    --- FAIL: TestScript/install_cmd_gobin (307.66s)
        script_test.go:134: 2023-05-26T17:03:27Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-813348838/tmpdir1280727065/install_cmd_gobin4081563801
        script_test.go:158: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.982s)
...
    --- FAIL: TestScript/mod_lazy_test_of_test_dep (30.56s)
        script_test.go:134: 2023-05-26T17:08:04Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-813348838/tmpdir1280727065/mod_lazy_test_of_test_dep2649590518
        script_test.go:158: 
            # This file demonstrates the effect of lazy loading on the reproducibility of
            # tests (and tests of test dependencies) outside the main module.
            #
            # It is similar to the cases in mod_all.txt and mod_lazy_test_horizon.txt, but
            # focuses on the effect of "go test" on specific packages instead of the "all"
            # pattern.
...
            r12    0x16
            r13    0x0
            r14    0x70100000800
            r15    0x700
            rip    0x7ff812b8c3ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:158: FAIL: testdata/script/mod_list_retract.txt:73: go list -m -f '{{.Version}}{{with .Retracted}} retracted{{end}}' example.com/retract/self/prev@<v1.10: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-26 16:17 darwin-amd64-race go@4c1d8bf5 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54217
https://vcs-test.golang.org rerouted to https://127.0.0.1:54218
go test proxy running at GOPROXY=http://127.0.0.1:54219/mod
--- FAIL: TestScript (1.30s)
    --- FAIL: TestScript/install_cmd_gobin (136.30s)
        script_test.go:134: 2023-05-27T15:06:31Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-4286586166/tmpdir4287155885/install_cmd_gobin1585049426
        script_test.go:158: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.316s)
...
            r12    0x16
            r13    0x0
            r14    0x140100001500
            r15    0x1400
            rip    0x7ff800ec33ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:158: FAIL: testdata/script/install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-24 14:36 darwin-amd64-race go@220c396e cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54477
https://vcs-test.golang.org rerouted to https://127.0.0.1:54478
go test proxy running at GOPROXY=http://127.0.0.1:54479/mod
--- FAIL: TestScript (1.31s)
    --- FAIL: TestScript/install_cmd_gobin (119.38s)
        script_test.go:134: 2023-05-28T10:38:08Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-1559842784/tmpdir1953250670/install_cmd_gobin1762001044
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.808s)
...
            r12    0x16
            r13    0x0
            r14    0x1f0100002000
            r15    0x1f00
            rip    0x7ff8118803ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2
2023-05-24 15:02 darwin-amd64-race go@8c30460b cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54341
https://vcs-test.golang.org rerouted to https://127.0.0.1:54342
go test proxy running at GOPROXY=http://127.0.0.1:54343/mod
--- FAIL: TestScript (1.32s)
    --- FAIL: TestScript/install_cmd_gobin (131.49s)
        script_test.go:134: 2023-05-28T09:13:05Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-959327/tmpdir1592139398/install_cmd_gobin2553308649
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.354s)
...
            r12    0x16
            r13    0x0
            r14    0x130100001400
            r15    0x1300
            rip    0x7ff8139ab3ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-23 22:13 darwin-amd64-race go@948f11b8 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:53963
https://vcs-test.golang.org rerouted to https://127.0.0.1:53964
go test proxy running at GOPROXY=http://127.0.0.1:53965/mod
--- FAIL: TestScript (1.42s)
    --- FAIL: TestScript/install_cmd_gobin (147.96s)
        script_test.go:134: 2023-05-28T16:06:45Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-1275349835/tmpdir3200389271/install_cmd_gobin3890680163
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (0.392s)
...
            r12    0x16
            r13    0x0
            r14    0x200100002100
            r15    0x2000
            rip    0x7ff80df0f3ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-23 21:35 darwin-amd64-race go@94c75232 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:55316
https://vcs-test.golang.org rerouted to https://127.0.0.1:55317
go test proxy running at GOPROXY=http://127.0.0.1:55318/mod
--- FAIL: TestScript (1.36s)
    --- FAIL: TestScript/install_cmd_gobin (111.66s)
        script_test.go:134: 2023-05-28T18:03:18Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-560454353/tmpdir851601012/install_cmd_gobin4283097477
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.664s)
...
            r12    0x16
            r13    0x0
            r14    0xf0100001000
            r15    0xf00
            rip    0x7ff800e3c3ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-23 19:43 darwin-amd64-race go@c0af7cd0 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:55287
https://vcs-test.golang.org rerouted to https://127.0.0.1:55288
go test proxy running at GOPROXY=http://127.0.0.1:55289/mod
--- FAIL: TestScript (1.40s)
    --- FAIL: TestScript/install_cmd_gobin (76.74s)
        script_test.go:134: 2023-05-28T22:07:49Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-2775904570/tmpdir2910857291/install_cmd_gobin4078419656
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.642s)
...
            r12    0x16
            r13    0x0
            r14    0x270100002800
            r15    0x2700
            rip    0x7ff81b2f83ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-23 19:39 darwin-amd64-race go@0aedfc19 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54768
https://vcs-test.golang.org rerouted to https://127.0.0.1:54769
go test proxy running at GOPROXY=http://127.0.0.1:54770/mod
--- FAIL: TestScript (1.34s)
    --- FAIL: TestScript/install_cmd_gobin (132.12s)
        script_test.go:134: 2023-05-28T23:13:45Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-2486034320/tmpdir1021977060/install_cmd_gobin3064884006
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.348s)
...
    --- FAIL: TestScript/env_write (40.23s)
        script_test.go:134: 2023-05-28T23:15:17Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-2486034320/tmpdir1021977060/env_write1186283583
        script_test.go:154: 
            > env GO111MODULE=off
            # go env should default to the right places (1.091s)
            # Now override it to something writable. (1.096s)
            # go env shows all variables (1.298s)
            # go env ignores invalid flag in GOFLAGS environment variable (1.429s)
            # checking errors (0.634s)
...
            r12    0xc0000af6f8
            r13    0x219cee0
            r14    0x0
            r15    0x7ff7bfeff5d0
            rip    0x7ff8119462be
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: env_write.txt:201: go env -u UNKNOWN: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-23 19:15 darwin-amd64-race go@8b51eb51 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:54483
https://vcs-test.golang.org rerouted to https://127.0.0.1:54484
go test proxy running at GOPROXY=http://127.0.0.1:54485/mod
--- FAIL: TestScript (1.38s)
    --- FAIL: TestScript/work (2.10s)
        script_test.go:134: 2023-05-29T02:01:33Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3822885147/tmpdir3451379025/work1077871819
        script_test.go:154: 
            > ! go work init doesnotexist
            [stderr]
...
    --- FAIL: TestScript/test_trimpath_test_suffix (0.01s)
        script_test.go:134: 2023-05-29T02:01:35Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3822885147/tmpdir3451379025/test_trimpath_test_suffix568243653
        script_test.go:154: 
        script_test.go:154: FAIL: test_trimpath_test_suffix.txt:0: context deadline exceeded
    --- FAIL: TestScript/test_match_only_tests (0.17s)
        script_test.go:134: 2023-05-29T02:01:35Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3822885147/tmpdir3451379025/test_match_only_tests1416476630
        script_test.go:154: 
            # Matches only tests (0.155s)
...
            r12    0x7ff7bfeff4f0
            r13    0xffffffffffffffff
            r14    0x219bc60
            r15    0x214a2a0
            rip    0x1084937
            rflags 0x10202
            cs     0x2b
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: vendor_outside_module.txt:3: go build -x -mod=readonly my-module/vendor/example.com/another-module/foo/bar/baz.go: exit status 2

— watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && log ~ `install_cmd_gobin` && log ~ `^\s*cmd/go/internal/load\.setPGOProfilePath`
2023-05-23 19:01 darwin-amd64-race go@ef23bd11 cmd/go.TestScript (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:53766
https://vcs-test.golang.org rerouted to https://127.0.0.1:53767
go test proxy running at GOPROXY=http://127.0.0.1:53768/mod
--- FAIL: TestScript (1.45s)
    --- FAIL: TestScript/install_cmd_gobin (127.57s)
        script_test.go:134: 2023-05-29T04:17:17Z
        script_test.go:136: $WORK=/tmp/buildlet/tmp/cmd-go-test-3314202992/tmpdir3308659548/install_cmd_gobin2799637916
        script_test.go:154: 
            # Check that commands in cmd are install to $GOROOT/bin, not $GOBIN.
            # Verifies golang.org/issue/32674. (1.461s)
...
            r12    0x16
            r13    0x0
            r14    0x170100001800
            r15    0x1700
            rip    0x7ff815a6c3ea
            rflags 0x247
            cs     0x7
            fs     0x0
            gs     0x0
        script_test.go:154: FAIL: install_cmd_gobin.txt:9: go list -f {{.Target}} cmd/compile: exit status 2

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@prattmic @bcmills @gopherbot