New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: apparent livelock in TestScript/install_cmd_gobin via setPGOProfilePath
#60428
Comments
(CC @cherrymui @prattmic @matloob) |
Found new dashboard test flakes for:
2023-05-23 18:36 darwin-amd64-race go@db83768f cmd/go.TestScript (log)
2023-05-23 21:46 darwin-amd64-race go@26f25692 cmd/go.TestScript (log)
2023-05-24 01:03 darwin-amd64-race go@bdc5533f cmd/go.TestScript (log)
2023-05-24 14:13 darwin-amd64-race go@227e7126 cmd/go.TestScript (log)
2023-05-24 16:23 darwin-amd64-race go@0adcc5ac cmd/go.TestScript (log)
2023-05-24 17:35 darwin-amd64-race go@bfdd3bf3 cmd/go.TestScript (log)
2023-05-24 20:26 darwin-amd64-race go@a7cb7df4 cmd/go.TestScript (log)
2023-05-24 20:58 darwin-amd64-race go@9b57b335 cmd/go.TestScript (log)
2023-05-24 23:23 linux-s390x-ibm-race go@08458804 cmd/go.TestScript (log)
2023-05-24 23:56 darwin-amd64-race go@6b020be6 cmd/go.TestScript (log)
2023-05-24 23:56 darwin-amd64-race go@371ebe73 cmd/go.TestScript (log)
2023-05-24 23:56 darwin-amd64-race go@6824765b cmd/go.TestScript (log)
2023-05-25 00:04 darwin-amd64-race go@04c62893 cmd/go.TestScript (log)
2023-05-25 00:13 darwin-amd64-race go@b267db08 cmd/go.TestScript (log)
2023-05-25 00:14 darwin-amd64-race go@d4bd855c cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-24 22:37 darwin-amd64-race go@7d96475d cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-24 22:27 darwin-amd64-race go@1ddab592 cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-24 22:24 darwin-amd64-race go@15a4e0d9 cmd/go.TestScript (log)
|
Odd. I happened to notice one of these on the dashboard the other day, but didn't realize that setPGOProfilePath was a pattern. I'll take a look. |
It's not trivially reproducible on a gomote. I'll leave it going for a while and see if it makes progress. FWIW, this test takes ~150s to pass in race mode, pretty close to the timeout. Edit: it’s possible that this runtime is itself indicative of the problem. I haven’t checked where the time is going or if it recently increased. The test takes ~15s in non-race mode. |
I would expect the test to take quite a bit longer now that However, most of that time should be spent in rebuilding the imported packages, not in |
I suspect that something is going wrong with the Perhaps we're somehow ending up with O(N²) splits instead of O(N), or something like that? |
Found new dashboard test flakes for:
2023-05-24 21:48 darwin-amd64-race go@05cc9e55 cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-26 03:21 darwin-amd64-race go@f90b4cd6 cmd/go.TestScript (log)
2023-05-26 13:43 darwin-amd64-race go@f89d575d cmd/go.TestScript (log)
|
The fix for #60455 reduces the (non-race) run time of this test from ~7s to ~0.2s, so I am assume it is the same root cause. |
Change https://go.dev/cl/498735 mentions this issue: |
Found new dashboard test flakes for:
2023-05-26 23:31 darwin-amd64-race go@c2bb350d cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-26 16:19 darwin-amd64-race go@76bb0caa cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-26 16:17 darwin-amd64-race go@4c1d8bf5 cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-24 14:36 darwin-amd64-race go@220c396e cmd/go.TestScript (log)
2023-05-24 15:02 darwin-amd64-race go@8c30460b cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-23 22:13 darwin-amd64-race go@948f11b8 cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-23 21:35 darwin-amd64-race go@94c75232 cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-23 19:43 darwin-amd64-race go@c0af7cd0 cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-23 19:39 darwin-amd64-race go@0aedfc19 cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-23 19:15 darwin-amd64-race go@8b51eb51 cmd/go.TestScript (log)
|
Found new dashboard test flakes for:
2023-05-23 19:01 darwin-amd64-race go@ef23bd11 cmd/go.TestScript (log)
|
The text was updated successfully, but these errors were encountered: