Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: add debugger hook for fatal signals [freeze exception] #60538

Closed
hyangah opened this issue May 31, 2023 · 2 comments
Closed

runtime: add debugger hook for fatal signals [freeze exception] #60538

hyangah opened this issue May 31, 2023 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented May 31, 2023

@aarzilli 's https://go.dev/cl/495736 refactors sighandler and moves fatal signal handling code to a separate fatalsignal function.
This allows debuggers like Delve to continue to check and intercept fatal signals when necessary. It would be nice if this change is merged to go1.21.

cc @golang/release

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 31, 2023
@dmitshur dmitshur added this to the Go1.21 milestone May 31, 2023
@dmitshur dmitshur added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 31, 2023
@cagedmantis
Copy link
Contributor

Approved after discussion within the group. This would help avoid a bug.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jun 2, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Jun 5, 2023

CL 495736 is submitted, closing. Please comment if something more is needed for this freeze exception.

@dmitshur dmitshur closed this as completed Jun 5, 2023
@golang golang locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

4 participants