Skip to content

runtime: extraMInUse overcounted #60540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
prattmic opened this issue May 31, 2023 · 1 comment
Closed

runtime: extraMInUse overcounted #60540

prattmic opened this issue May 31, 2023 · 1 comment
Assignees
@prattmic
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge release-blocker
Milestone
Go1.21

Comments

@prattmic
Copy link
Member

https://go.dev/cl/492743 introduced extraMInUse to help exclude extra Ms from SetMaxThread. The implementation is buggy, as lockextra will increment extraMInUse even when returning nil.
@prattmic prattmic added this to the Go1.21 milestone May 31, 2023
@prattmic prattmic self-assigned this May 31, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 31, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/499677 mentions this issue: runtime: only increment extraMInUse when actually in use

@mknyszek mknyszek moved this from Todo to In Progress in Go Compiler / Runtime May 31, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Jun 1, 2023
@golang golang locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@prattmic prattmic

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@prattmic @gopherbot