Open
Description
What version of Go are you using (go version
)?
go1.20.4 windows/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env
)?
N/A
What did you do?
reviewed the function validateNamedValueName in go/src/database/sql/convert.go
What did you expect to see?
The function does not make the incorrect assumption that procedure parameters always start with a letter.
What did you see instead?
The function should not reject valid parameter names.
For example, $foo
, and #bar
are valid stored procedure parameters in SQL Server.
This means that the function needs to support all valid parameter names (which is unknowable), or should be eliminated.
I believe it acceptable to not perform a check and leave it to the database to generate an error.