Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: mayMoreStackPreempt failures [1.19 backport] #60643

Closed
gopherbot opened this issue Jun 6, 2023 · 1 comment
Closed

runtime: mayMoreStackPreempt failures [1.19 backport] #60643

gopherbot opened this issue Jun 6, 2023 · 1 comment
Labels
CherryPickCandidate Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.19.11

Comments

@gopherbot
Copy link
Contributor

@prattmic requested issue #55160 to be considered for backport to the next 1.19 minor release.

I believe this is a bug in https://go.dev/cl/7314062. (Yes, a 10 year old bug).

The "delicate dance" when a spinning M transitions to non-spinning is supposed to check all sources of work, but it doesn't check the global run queue: https://cs.opensource.google/go/go/+/master:src/runtime/proc.go;l=3084;drc=5b6e6d2b3d4d6877c86471209e249f1b6e36d0ca

gosched / mayMoreStack put the preempted goroutine on the global run queue, increasing the chance of failure (in addition to the extra stress it puts on the scheduler in general). Still, I am surprised this bug could go unnoticed for so long.

With that issue fixed, I can no longer reproduce this hang.

@gopherbot Please open backports to 1.20 and 1.19. This is a hang in the scheduler with no work around.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 6, 2023
@gopherbot gopherbot mentioned this issue Jun 6, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jun 6, 2023
@gopherbot gopherbot added this to the Go1.19.11 milestone Jun 6, 2023
@dmitshur dmitshur added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jun 28, 2023
@prattmic
Copy link
Member

We have decided to wait for 1.22 for this: #55160 (comment)

@prattmic prattmic reopened this Jun 30, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Go Compiler / Runtime Jun 30, 2023
@prattmic prattmic closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Jun 30, 2023
@golang golang locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Go1.19.11
Development

No branches or pull requests
3 participants
@prattmic @dmitshur @gopherbot