Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: statements become slower to invoke over time as new connections are opened #6081

Closed
anacrolix opened this issue Aug 8, 2013 · 7 comments
Assignees
Milestone

Comments

@anacrolix
Copy link
Contributor

@anacrolix anacrolix commented Aug 8, 2013

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 8, 2013

Comment 1:

You forgot to run "hg mail 12646044".

Labels changed: removed priority-triage.

Owner changed to @bradfitz.

Status changed to Accepted.

@anacrolix
Copy link
Contributor Author

@anacrolix anacrolix commented Aug 9, 2013

Comment 2:

I didn't even realise this was necessary. Cheers
@anacrolix
Copy link
Contributor Author

@anacrolix anacrolix commented Aug 12, 2013

Comment 3:

What's left to get this in? It's a serious performance concern.
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 12, 2013

Comment 4:

As I said on golang-dev, this can't go in without a test.
I wrote a test to help out, though:
https://golang.org/cl/12810043
Please review that and reply "LGTM" if it's good.
Then you can update your CL to just remove the t.Skip line from the test and then I can
submit your fix.
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 13, 2013

Comment 5:

This issue was updated by revision ca3ed9f.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/12810043
@anacrolix
Copy link
Contributor Author

@anacrolix anacrolix commented Aug 14, 2013

Comment 6:

I updated the patch and submitted CLA.
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 14, 2013

Comment 7:

This issue was closed by revision 13c7896.

Status changed to Fixed.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.