dl/gotip: download output includes an unhelpful, misleading "*** You need to ..." message

[dmitshur]

Running gotip download now, I'm seeing in its output:

$ gotip download
[...]
*** You need to add /Users/gopher/sdk/gotip/bin to your PATH.
Success. You may now run 'gotip'!
$ 

"Success. You may now run 'gotip'!" is coming from gotip download and is right.

The "*** You need to ..." line above is coming from make.bash, but doesn't apply in the context of using gotip. When running subsequent gotip commands, they'll correctly add "/Users/gopher/sdk/gotip/bin" to PATH automatically.

gotip download should arrange the way it calls make.{bash,bat,rc} such that the misleading message won't show up in the output.

I'll send a fix. This is most likely a side-effect of me fixing #42563 recently. 😅

[gopherbot]

Change https://go.dev/cl/504037 mentions this issue: gotip: silence misplaced "*** You need to ..." suggestion