Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: getImportPackage crash (PackagePath == "unsafe", id != "unsafe") (Bazel?) #60890

Closed
rossb83 opened this issue Jun 18, 2023 · 93 comments
Assignees
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@rossb83
Copy link

rossb83 commented Jun 18, 2023

#!stacks
"bug.Reportf" &&
("buildMetadata:+7" && "buildMetadata:+166" ||
 "buildMetadata:+63" && "buildMetadata:+166" ||
 "getImportPackage:43" || "getImportPackage:+43" ||
 "getImportPackage:44" || "getImportPackage:+44" ||
 "getPackageHandles:+98")

gopls version: v0.12.2 (go1.20.4)
gopls flags: -logfile /home/user/gopls.log -rpc.trace
update flags: off
extension version: 0.38.0-upstream-0.1.7-uber
go version: 1.20.4
environment: Visual Studio Code linux
initialization error: undefined
issue timestamp: Sun, 18 Jun 2023 04:57:07 GMT
restart history:
Sun, 18 Jun 2023 04:56:23 GMT: activation (enabled: true)

ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.

Describe what you observed.

panic: cannot export package unsafe

goroutine 2285 [running]:
golang.org/x/tools/internal/gcimporter.iexportCommon.func1()
	  iexport.go:93  0x8a
panic({0xd82ea0, 0x114f800})
	  panic.go:884  0x213
golang.org/x/tools/internal/gcimporter.(*iexporter).pushDecl(0xc004730000, {0x11617f8, 0xc000037270})
	  iexport.go:395  0xf6
golang.org/x/tools/internal/gcimporter.iexportCommon({0x1151100, 0xc002cd1a10}, 0xc004f8aa40, 0x0, 0x1, 0x2, {0xc005ff5ca8, 0x1, 0xc002cd1980%3F})
	  iexport.go:124  0x93a
golang.org/x/tools/internal/gcimporter.IExportShallow(0xdc6300%3F, 0xc000036230)
	  iexport.go:43  0x75
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage.func1()
	  check.go:646  0x2b1
created by golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage
	  check.go:638  0x305
[Error - 4:56:54 AM] 

OPTIONAL: If you would like to share more information, you can attach your complete gopls logs.

NOTE: THESE MAY CONTAIN SENSITIVE INFORMATION ABOUT YOUR CODEBASE.
DO NOT SHARE LOGS IF YOU ARE WORKING IN A PRIVATE REPOSITORY.

<OPTIONAL: ATTACH LOGS HERE>

Dups: WyBEVw 8IUuxg gGL_Og s38AiQ g1WTiA kaOGFA M1Fsyg eMTo4g 4jVSEw DdusYg 2wkHKQ bexi2A Hf_uxA WAPo2A 7eM7_A PhUfgg JInHxA xwn1Jg OdVCcg mYyn3yw IdUP_g qbPZnw hHYY5A xvGtWg H2awJg LhpC0g Yy4aKQ PbxusA i-qkVg fF_MIA s22TCw NOX_YQ wRPq1w ZWkRNQ Yyn3yw ZWkRNQ Yyn3yw 6-MKJQ gkuQUg 138-Ow OpRVTQ Xb0U6w 4jr9sA MvEEmQ KAVPYA 1mE0sg PkqU2A uenBJg HU5Q-Q Ywq8Dw WsakRw jE3s2Q 2W-IrQ TYioIw Uf_DKg

Dups without stacks (volume too great): kDcQPA pPHxjg Et04NQ lAne1w 5q1iTA Bo56Rg flcnug s_ayTw PCuJOA ZnegMg IsWiAw
Dups: nSD9CA mGs3Rg WWsZMg ZBPYCA DESvAg 6IAPOw m6NDdA i0tR-Q BJbmzw rGALVg haDN2Q vaj6OA 05l8Ag cgRtZA JImRiw ugaMgQ EMv0yw kZU18Q 8Chkbw VO-3_A HYLWAQ ThIiZA qAI8kA XQcuPg iQX0Dw rQta-Q dm1LXg 3bpqaw 6rHvAw Q_Q6wg VS4dOA TYUXOQ kq7BNw edVRKw _jGWwQ PV0Tug c7YvIQ SoRmmw fGHMBg V2oXUg OYxA7A 10mQbg no1QsA 13ADSQ PTwXmA RbhLJA grIzbg 2R60mA DrZJsQ dNKXJg Ic03cA EJzn_g dKdDQA -8-fGw LJNitw IdKMfQ zkb6qg rOr9mA 0UG84w R-PT1g Ath4qQ 1zpQyw Xlm2oQ 4XuTFA RWTrBg VUi5lg pddM6A nQ2HQg gVfysA rsVUVg mvqlsg QblXZw t7Y8uQ d7miAg k8qR_A 7KCNbg zz8SRw WWD0sQ zOysOg kcBR7A ynNUDg 4dfGPg wqarWQ rMmP1A tOnEpw XBQYdg S9_PvA Hj4zaQ G0_iow i70XcA rG0l3Q 9CAMjg nzs98w _lEsOw uHsT6Q XGXXsQ q-UVfg 2rzsAA La_X0A 58kcYQ 8xB-8g HBpgew

@findleyr findleyr changed the title gopls: automated issue report (crash) x/tools/gopls: crash exporting unsafe Jun 20, 2023
@findleyr
Copy link
Member

Thank you for the report.

This is an interesting crash. There is code explicitly guarding against exporting unsafe in this control flow, but it checks only the package ID, not package path, which could theoretically misidentify a variant of the "unsafe" package.. However, there should not be any variants of the "unsafe" package. An exception to this is PGO variants, but these were explicitly avoided in #60456, and in any case you are using go1.20.

So, I think I can probably fix this, but I don't know how to repro.

Can you share anything about the code you were editing when you encountered this crash?

Do you have anything interesting in your settings.json?

@findleyr findleyr transferred this issue from golang/vscode-go Jun 20, 2023
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 20, 2023
@findleyr findleyr added this to the gopls/v0.12.3 milestone Jun 20, 2023
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jun 20, 2023
@gopherbot gopherbot modified the milestones: gopls/v0.12.3, Unreleased Jun 20, 2023
@findleyr findleyr self-assigned this Jun 20, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/504555 mentions this issue: gopls/internal/lsp/cache: guard against "unsafe" by package path, not ID

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/504556 mentions this issue: internal/gcimporter: avoid a crash when exporting a struct with no pkg

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.12.3 Jun 20, 2023
gopherbot pushed a commit to golang/tools that referenced this issue Jun 20, 2023
The crash in golang/go#60890 suggests that a user encountered a variant
of the unsafe package. I'm not sure how to reproduce this, but in any
case we should be checking package path, not ID, when guarding against
exporting "unsafe".

For golang/go#60890

Change-Id: Ib6c546b8f74ba513f5ee3df09b5ba29cea0c1b85
Reviewed-on: https://go-review.googlesource.com/c/tools/+/504555
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@findleyr
Copy link
Member

Absent a repro, I'm not sure if this is fixed, but I will optimistically close this. We can reopen if we get another report.

@JamyDev
Copy link

JamyDev commented Jul 14, 2023

@findleyr this was reproable in 0.12.4 for us, but not in latest master branch. Would it be possible to get a 0.12.5 or 0.13 release out? we're currently stuck in 0.11 land, and I'd like to take advantage of the perf updates in 0.12

@findleyr
Copy link
Member

@JamyDev we're aiming for 12.5 soon -- either next week or the week after. You can of course also install gopls at master.

Thanks for confirming that it is fixed at master.

@adonovan
Copy link
Member

adonovan commented Jan 2, 2024

Reopening since we hit an "encountered unsafe as %s" assertion.

This stack WyBEVw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Reportf:1
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).getImportPackage:43
golang.org/x/tools/gopls/internal/lsp/cache.(*snapshot).forEachPackageInternal.func1:1
golang.org/x/sync/errgroup.(*Group).Go.func1:3
runtime.goexit:0
golang.org/x/tools/gopls@v0.14.2 go1.21.1 darwin/amd64 (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member

This stack 8IUuxg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Reportf:1
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).getImportPackage:43
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).typesConfig.func1:20
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:29
go/types.(*Checker).Files:?372
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackageForImport:50
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).getImportPackage:50
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).typesConfig.func1:20
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
golang.org/x/tools/gopls@v0.14.2 go1.22.0 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member

This stack WyBEVw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Reportf:1
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).getImportPackage:43
golang.org/x/tools/gopls/internal/lsp/cache.(*snapshot).forEachPackageInternal.func1:1
golang.org/x/sync/errgroup.(*Group).Go.func1:3
runtime.goexit:0
golang.org/x/tools/gopls@v0.14.2 go1.22.0 darwin/arm64 vscode (13)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member

adonovan commented Mar 9, 2024

This stack gGL_Og was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+43
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=372
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).checkPackageForImport:+50
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+50
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
golang.org/x/tools/gopls@v0.15.0 go1.22.0 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.15.1 go1.22.0 darwin/arm64 other,vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member

adonovan commented Mar 9, 2024

This stack s38AiQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+43
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.15.1 go1.22.0 darwin/arm64 other,vscode (6)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member

This stack g1WTiA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+43
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+32
go/types.(*Checker).Files:=341
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).checkPackageForImport:+50
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+50
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
golang.org/x/tools/gopls@v0.15.1 go1.21.7 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member

This stack kaOGFA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+43
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+32
go/types.(*Checker).Files:=341
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).checkPackageForImport:+50
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+50
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
golang.org/x/tools/gopls@v0.15.2 go1.21.8 darwin/arm64 other,vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member

This stack M1Fsyg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+43
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=372
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).checkPackageForImport:+50
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+50
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
golang.org/x/tools/gopls@v0.15.2 go1.22.0 darwin/arm64 other,vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan adonovan changed the title x/tools/gopls: crash exporting unsafe x/tools/gopls: getImportPackage crash (PackagePath == "unsafe", id != "unsafe") Mar 21, 2024
@adonovan
Copy link
Member

This stack eMTo4g was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+43
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).handleSyntaxPackage.func2:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.15.2 go1.22.0 darwin/arm64 vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member

This stack JImRiw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

This stack ugaMgQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

This stack EMv0yw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

This stack kZU18Q was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member

This stack HYLWAQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

This stack ThIiZA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (3)

This stack qAI8kA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

This stack XQcuPg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

This stack iQX0Dw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 other,vscode (1)

This stack rQta-Q was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 other,vscode (1)

This stack dm1LXg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (3)

This stack 3bpqaw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

This stack 6rHvAw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

@adonovan
Copy link
Member

adonovan commented Oct 3, 2024

This stack Q_Q6wg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

This stack VS4dOA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

This stack TYUXOQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member

adonovan commented Oct 4, 2024

This stack kq7BNw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 vscode (1)

This stack edVRKw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 vscode (2)

This stack _jGWwQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 vscode (1)

This stack PV0Tug was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 vscode (1)

@adonovan
Copy link
Member

This stack c7YvIQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

This stack SoRmmw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

@adonovan
Copy link
Member

This stack fGHMBg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack V2oXUg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (2)

This stack OYxA7A was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (2)

This stack 10mQbg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack no1QsA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack 13ADSQ was reported by telemetry:

golang.org/x/tools/gopls@v0.15.3 go1.22.3 darwin/arm64 vscode (1)

This stack PTwXmA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack RbhLJA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (2)

This stack grIzbg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (2)

@adonovan
Copy link
Member

This stack 2R60mA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.1 go1.21.3 darwin/arm64 other (1)

This stack DrZJsQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack dNKXJg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack Ic03cA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack EJzn_g was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack dKdDQA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack -8-fGw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

@adonovan
Copy link
Member

This stack LJNitw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

This stack IdKMfQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

1 similar comment
@adonovan
Copy link
Member

This stack rOr9mA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

This stack 0UG84w was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack R-PT1g was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

This stack Ath4qQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

@adonovan
Copy link
Member

This stack 1zpQyw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 other,vscode (1)

This stack Xlm2oQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 other,vscode (1)

This stack 4XuTFA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.1 linux/amd64 vscode (1)

This stack RWTrBg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.1 linux/amd64 vscode (1)

@adonovan
Copy link
Member

This stack VUi5lg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

This stack pddM6A was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member

This stack nQ2HQg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 other (1)

This stack gVfysA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 other (1)

This stack rsVUVg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 other (1)

This stack mvqlsg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 other (1)

@adonovan
Copy link
Member

adonovan commented Nov 4, 2024

This stack QblXZw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 other,vscode (1)

This stack t7Y8uQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 other,vscode (1)

@adonovan
Copy link
Member

adonovan commented Nov 7, 2024

This stack k8qR_A was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack 7KCNbg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack zz8SRw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack WWD0sQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

@adonovan
Copy link
Member

adonovan commented Dec 2, 2024

This stack 4dfGPg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 other,vscode (1)

This stack wqarWQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 linux/amd64 vscode (1)

This stack rMmP1A was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 other,vscode (1)

This stack tOnEpw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 linux/amd64 vscode (1)

@adonovan
Copy link
Member

adonovan commented Dec 3, 2024

This stack XBQYdg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.3 linux/amd64 vscode (1)

This stack S9_PvA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.3 linux/amd64 vscode (1)

@adonovan
Copy link
Member

This stack Hj4zaQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 linux/amd64 vscode (1)

This stack G0_iow was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 linux/amd64 vscode (1)

@adonovan
Copy link
Member

This stack i70XcA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 other,vscode (1)

This stack rG0l3Q was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 other,vscode (1)

This stack 9CAMjg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 other,vscode (1)

This stack nzs98w was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 other,vscode (1)

@adonovan
Copy link
Member

This stack _lEsOw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack uHsT6Q was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.0 linux/amd64 neovim (1)

This stack XGXXsQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

@adonovan
Copy link
Member

This stack q-UVfg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack 2rzsAA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

@adonovan
Copy link
Member

This stack La_X0A was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 linux/amd64 vscode (1)

This stack 58kcYQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 linux/amd64 vscode (1)

This stack 8xB-8g was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 linux/amd64 vscode (1)

This stack HBpgew was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 linux/amd64 vscode (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

5 participants