Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: fix homepage link in local mode #60916

Closed
amine7536 opened this issue Jun 21, 2023 · 2 comments
Closed

x/pkgsite: fix homepage link in local mode #60916

amine7536 opened this issue Jun 21, 2023 · 2 comments

Comments

@amine7536
Copy link

What is the URL of the page with the issue?

Run pkgsite locally http://localhost:9999

export GOPROXY='https://proxy.golang.org'
pkgsite -proxy -http localhost:9999 -list=false

What is your user agent?

Any

Screenshot

Screenshot 2023-06-21 at 11 38 54

What did you do?

What did you expect to see?

The link to the homepage points to https://go.dev instead of localhost:9999

@gopherbot gopherbot added this to the Unreleased milestone Jun 21, 2023
@amine7536
Copy link
Author

I can work on a fix :)

amine7536 added a commit to amine7536/pkgsite that referenced this issue Jun 21, 2023
Change the homepage link based on whether we are running in LocalMode or not. If pkgsite or frontend are running in LocalMode, set the href link to "/", otherwise keep it as "https://go.dev".

Fixes golang/go#60916
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/504795 mentions this issue: static/frontend: fix homepage link when running in LocalMode

@findleyr findleyr changed the title x/pkgsite: x/pkgsite: fix homepage link in local mode Jun 21, 2023
@golang golang locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants