New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/xml: more tests #6094

Open
rsc opened this Issue Aug 9, 2013 · 14 comments

Comments

Projects
None yet
5 participants
@rsc
Copy link
Contributor

rsc commented Aug 9, 2013

encoding/xml is under-tested. Now that we have go tool cover, it might be nice to write
some more tests, especially of things like name spaces, custom marshalers, custom
unmarshalers, and the interaction between all those.
@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Sep 10, 2013

Comment 1:

Labels changed: added testing.

@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Oct 2, 2013

Comment 2:

Labels changed: added go1.3, removed go1.2maybe.

@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added release-go1.3.

@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 4:

Labels changed: removed go1.3.

@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added repo-main.

@shawnps

This comment has been minimized.

Copy link
Member

shawnps commented Feb 24, 2014

Comment 6:

Updated by https://golang.org/cl/47870043
@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Apr 3, 2014

Comment 7:

Labels changed: removed release-go1.3.

@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Apr 3, 2014

Comment 8:

Labels changed: added release-none.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 11, 2014

Comment 9:

CL https://golang.org/cl/92230043 mentions this issue.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@odeke-em

This comment has been minimized.

Copy link
Member

odeke-em commented Feb 11, 2016

I think this issue can now be closed, we are at 86.2% coverage at commit 0ed70ef

$ pwd
/Users/emmanuelodeke/go/src/go.googlesource.com/go/src/encoding/xml
$ go version
go version devel +0ed70ef Wed Feb 3 04:33:08 2016 +0000 darwin/amd64
$ go test -cover
PASS
coverage: 86.2% of statements
ok      encoding/xml    0.012s
@Thomasdezeeuw

This comment has been minimized.

Copy link
Contributor

Thomasdezeeuw commented Feb 11, 2016

Shouldn't it be closed at 100%?

@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Feb 11, 2016

@Thomasdezeeuw

This comment has been minimized.

Copy link
Contributor

Thomasdezeeuw commented Feb 11, 2016

I agree that 100% coverage isn't a guarantee for much, but I would see it as a minimum.

@odeke-em

This comment has been minimized.

Copy link
Member

odeke-em commented Feb 11, 2016

Gotcha, sounds like a plan. I'll try taking a stab at this for Go1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment