Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/getgo: deprecate and remove it #60951

Closed
hyangah opened this issue Jun 22, 2023 · 9 comments
Closed

x/tools/cmd/getgo: deprecate and remove it #60951

hyangah opened this issue Jun 22, 2023 · 9 comments
Labels
Proposal Proposal-Accepted Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 22, 2023

The infrastructure to support this experimental tool hadn't been maintained. (get.golang.org)
We are now recommending golang.org/dl/* or, after go1.21, we have a better story.
Delete and remove it.
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 22, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jun 22, 2023
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 22, 2023
@cannona cannona mentioned this issue Aug 17, 2023
Closed
@findleyr
Copy link
Contributor

I think there's still a need for a tool like cmd/getgo -- the instructions for linux at https://go.dev/doc/install are surprisingly manual. Could we instead fix it?

@hyangah hyangah added Proposal and removed NeedsFix The path to resolution is known, but the work has not been done. labels Sep 6, 2023
@hyangah
Copy link
Contributor Author

hyangah commented Sep 6, 2023

Added "Proposal" label because there are some users depending on this.

@seankhliao seankhliao modified the milestones: Unreleased, Proposal Sep 6, 2023
@seankhliao seankhliao changed the title x/tools/cmd/getgo: deprecate and remove it proposal: x/tools/cmd/getgo: deprecate and remove it Sep 6, 2023
This was referenced Sep 7, 2023
Closed
Closed
@zigo101 zigo101 mentioned this issue Oct 4, 2023
Closed
@rsc
Copy link
Contributor

rsc commented Jan 25, 2024

Most of us didn't even know this existed. Especially with the new forward compatibility toolchain downloads, deleting it makes sense.

@rsc
Copy link
Contributor

rsc commented Jan 26, 2024

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented Feb 2, 2024

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

The proposal is to deprecate and remove x/tools/cmd/getgo,
probably tagging it first so that existing references keep working.

@rsc
Copy link
Contributor

rsc commented Feb 8, 2024

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

The proposal is to deprecate and remove x/tools/cmd/getgo,
probably tagging it first so that existing references keep working.

@rsc rsc changed the title proposal: x/tools/cmd/getgo: deprecate and remove it x/tools/cmd/getgo: deprecate and remove it Feb 8, 2024
@rsc rsc modified the milestones: Proposal, Backlog Feb 8, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/563398 mentions this issue: cmd/getgo: create a module in preparation for deprecation

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/563455 mentions this issue: Ubuntu.md: remove getgo option

gopherbot pushed a commit to golang/wiki that referenced this issue Feb 12, 2024
@hyangah @gopherbot
Ubuntu.md: remove getgo option
dd26168 
Getgo is deprecated.

For golang/go#60951

Change-Id: I3b92e0d90cae8ec4623199b63e9aca98883db477
Reviewed-on: https://go-review.googlesource.com/c/wiki/+/563455
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopherbot pushed a commit to golang/tools that referenced this issue Feb 16, 2024
@hyangah
cmd/getgo: create a module in preparation for deprecation
c61f99f 
And add deprecation notice.
Updates golang/go#60951

Change-Id: I9d4ffffc03201b038db5cc11563ea1cc5330e668
Reviewed-on: https://go-review.googlesource.com/c/tools/+/563398
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/564657 mentions this issue: cmd/getgo: delete package

This was referenced Feb 16, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@rsc rsc mentioned this issue Mar 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal Proposal-Accepted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Proposals
Status: Accepted
Milestone
Backlog
Development

No branches or pull requests
6 participants
@rsc @dmitshur @hyangah @gopherbot @seankhliao @findleyr