x/telemetry/internal/counter: TestNewFile persistently failing on GOOS=solaris GOARCH=amd64 using Go 1.20 and Go tip

[dmitshur]

#!watchflakes
post <- pkg == "golang.org/x/telemetry/internal/counter" && test == "TestNewFile" && goos == "solaris" && `days = 7`

From https://build.golang.org/log/466ee94eb52ce64476d1b75d9a3fc1c26f4a9094:

--- FAIL: TestNewFile (0.01s)
    counter_test.go:164: GOOS solaris GARCH amd64
    counter_test.go:220: 2: days = 7, want 7 < days <= 14
    counter_test.go:220: 9: days = 7, want 7 < days <= 14
    counter_test.go:220: 11: days = 7, want 7 < days <= 14
2023/06/23 14:12:34 closing /tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestRotate1832009220/001/local/counter.test-go1.20.5-solaris-amd64-2023-06-23.v1.count
FAIL
FAIL	golang.org/x/telemetry/internal/counter	0.159s

This happens on Go 1.20 release branch at Go tip. Very similar to #60966.

CC @golang/solaris, @rorth.

[gopherbot]

Change https://go.dev/cl/505580 mentions this issue: internal/counter: skip tests on solaris, android, and GOARCH=386

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/telemetry/internal/counter" && test == "TestNewFile" && goos == "solaris" && `days = 7`

2023-06-23 12:10 solaris-amd64-oraclerel telemetry@09c2e0cd go@48dbb622 x/telemetry/internal/counter.TestNewFile (log)

--- FAIL: TestNewFile (0.01s)
    counter_test.go:164: GOOS solaris GARCH amd64
    counter_test.go:220: 0: days = 7, want 7 < days <= 14
    counter_test.go:220: 3: days = 7, want 7 < days <= 14
    counter_test.go:220: 9: days = 7, want 7 < days <= 14
2023/06/23 19:22:52 closing /tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestRotate3757461153/001/local/counter.test-devel-solaris-amd64-2023-06-23.v1.count

2023-06-23 12:10 solaris-amd64-oraclerel telemetry@09c2e0cd go@3adcce5a x/telemetry/internal/counter.TestNewFile (log)

--- FAIL: TestNewFile (0.01s)
    counter_test.go:164: GOOS solaris GARCH amd64
    counter_test.go:220: 0: days = 7, want 7 < days <= 14
    counter_test.go:220: 15: days = 7, want 7 < days <= 14
2023/06/23 18:39:09 closing /tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestRotate3987462832/001/local/counter.test-devel-solaris-amd64-2023-06-23.v1.count

2023-06-23 12:10 solaris-amd64-oraclerel telemetry@09c2e0cd go@6dce882b x/telemetry/internal/counter.TestNewFile (log)

--- FAIL: TestNewFile (0.01s)
    counter_test.go:164: GOOS solaris GARCH amd64
    counter_test.go:220: 6: days = 7, want 7 < days <= 14
    counter_test.go:220: 12: days = 7, want 7 < days <= 14
    counter_test.go:220: 16: days = 7, want 7 < days <= 14
2023/06/23 17:00:45 closing /tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestRotate4122084287/001/local/counter.test-devel-solaris-amd64-2023-06-23.v1.count

— watchflakes

[gopherbot]

Change https://go.dev/cl/508499 mentions this issue: internal/counter: add test logging to debug TestNewFile flakiness

[gopherbot]

Change https://go.dev/cl/508501 mentions this issue: internal/counter: fix TestNewFile test

[findleyr]

I believe this is done, or obsolete with other work to get telemetry passing on the LUCI builders.