Skip to content

testing: TestTBHelper fails if run with -failfast #61016

Description

@bcmills

What version of Go are you using (go version)?

~$ go1.21rc2 version
go version go1.21rc2 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/usr/local/google/home/bcmills/.cache/go-build'
GOENV='/usr/local/google/home/bcmills/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/usr/local/google/home/bcmills/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/usr/local/google/home/bcmills'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/google/home/bcmills/sdk/go1.21rc2'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/google/home/bcmills/sdk/go1.21rc2/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21rc2'
GCCGO='/usr/bin/gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='c++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2889092914=/tmp/go-build -gno-record-gcc-switches'

What did you do?

go1.21rc2 test testing -failfast

What did you expect to see?

Test passing.

What did you see instead?

--- FAIL: TestTBHelper (0.00s)
    helper_test.go:52: got output:
        
        --- FAIL: Test (?s)
        helperfuncs_test.go:12: 0
        helperfuncs_test.go:40: 1
        helperfuncs_test.go:21: 2
        helperfuncs_test.go:42: 3
        helperfuncs_test.go:49: 4
        --- FAIL: Test/sub (?s)
        helperfuncs_test.go:52: 5
        helperfuncs_test.go:21: 6
        helperfuncs_test.go:51: 7
        helperfuncs_test.go:63: 8
        helperfuncs_test.go:82: recover 12
        helperfuncs_test.go:84: GenericFloat64
        helperfuncs_test.go:85: GenericInt
        helperfuncs_test.go:71: 9
        helperfuncs_test.go:67: 10
        
        want:
        
        --- FAIL: Test (?s)
        helperfuncs_test.go:12: 0
        helperfuncs_test.go:40: 1
        helperfuncs_test.go:21: 2
        helperfuncs_test.go:42: 3
        helperfuncs_test.go:49: 4
        --- FAIL: Test/sub (?s)
        helperfuncs_test.go:52: 5
        helperfuncs_test.go:21: 6
        helperfuncs_test.go:51: 7
        helperfuncs_test.go:63: 8
        --- FAIL: Test/sub2 (?s)
        helperfuncs_test.go:78: 11
        helperfuncs_test.go:82: recover 12
        helperfuncs_test.go:84: GenericFloat64
        helperfuncs_test.go:85: GenericInt
        helperfuncs_test.go:71: 9
        helperfuncs_test.go:67: 10
FAIL
FAIL	testing	0.007s
FAIL

Activity

  1. added
    TestingAn issue that has been verified to require only test changes, not just a test failure.
    NeedsFixThe path to resolution is known, but the work has not been done.
    on Jun 26, 2023
  2. added this to the Go1.22 milestone on Jun 26, 2023
  3. self-assigned this
    on Jun 26, 2023
  4. added
    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
    and removed
    TestingAn issue that has been verified to require only test changes, not just a test failure.
    on Jun 26, 2023
  5. removed their assignment
    on Jun 26, 2023
  6. removed
    NeedsFixThe path to resolution is known, but the work has not been done.
    on Jun 26, 2023
  7. added
    TestingAn issue that has been verified to require only test changes, not just a test failure.
    on Jun 28, 2023
  8. self-assigned this
    on Jun 28, 2023
  9. added
    NeedsFixThe path to resolution is known, but the work has not been done.
    on Jun 28, 2023
  10. removed
    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
    on Jun 28, 2023
  11. gopherbot commented on Jun 28, 2023

    @gopherbot
    Contributor

    Change https://go.dev/cl/506955 mentions this issue: testing: use subprocesses in TestTBHelper and TestTBHelperParallel

  12. locked and limited conversation to collaborators on Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.TestingAn issue that has been verified to require only test changes, not just a test failure.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions