Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: Tricium should not enforce Go style rules on testdata/*.go #61214

Open
adonovan opened this issue Jul 6, 2023 · 4 comments
Open

x/build: Tricium should not enforce Go style rules on testdata/*.go #61214

adonovan opened this issue Jul 6, 2023 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@adonovan
Copy link
Member

adonovan commented Jul 6, 2023

The new Tricium CI system keeps pointing out that *.go files don't have a copyright header, even when they are in a testdata directory. Test data files sometimes need to be subtly invalid Go for a wide variety of reasons, and the CI system shouldn't try to make them look like production code.
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 6, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 6, 2023
@erifan
Copy link

erifan commented Jul 7, 2023

Also include automatically generated files.

@joedian joedian added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 7, 2023
@bcmills
Copy link
Contributor

bcmills commented Jul 10, 2023

I think @rsc suggested that we disable the Tricium check entirely. Its spell-checker has a number of idiosyncrasies specific to Chromium that don't really apply to Go.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/508865 mentions this issue: recipes/recipes: disable tricium copyright check

gopherbot pushed a commit to golang/build that referenced this issue Jul 12, 2023
@cagedmantis @gopherbot
recipes/recipes: disable tricium copyright check
a807443 
This change temporarily disables the tricium copyright check. It will
be enabled again when it can be customized to work with the Go project.

Updates golang/go#61214

Change-Id: Ia69bc19f34b9f253c393ebf3b5b81e10b7aef0b8
Reviewed-on: https://go-review.googlesource.com/c/build/+/508865
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
@cagedmantis
Copy link
Contributor

The copyright check has been temporarily disabled.

@cagedmantis cagedmantis removed their assignment Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Status: Planned
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@cagedmantis @bcmills @adonovan @gopherbot @joedian @erifan